Skip to content

Commit ff28482

Browse files
committed
fix: correct CI format check and dart:format task ordering
- Add --output=none to dart format CI check so it doesn't modify files (--set-exit-if-changed alone still writes) - Remove mise fmt --check from CI: mise is not installed in the CI environment (setup-flutter-app uses subosito/flutter-action directly) - Make dart:format depend on generate so mock files are formatted after codegen, not before
1 parent a2b419a commit ff28482

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

.github/workflows/ci.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,10 +67,9 @@ jobs:
6767

6868
- name: Check formatting
6969
run: |
70-
dart format --set-exit-if-changed .
70+
dart format --output=none --set-exit-if-changed .
7171
npm ci
7272
npx prettier --check "**/*.{js,ts,mjs}"
73-
mise fmt --check
7473
7574
- name: Analyze code
7675
run: flutter analyze --no-fatal-infos

mise.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,8 @@ exit $EXIT_CODE
4545
'''
4646

4747
[tasks."dart:format"]
48-
description = "Format all Dart code in place"
48+
description = "Format all Dart code in place (depends on generate so mock files are formatted too)"
49+
depends = ['generate']
4950
run = 'dart format .'
5051

5152
[tasks."prettier:format"]

0 commit comments

Comments
 (0)