Missing id/name in JSON parsed as "null" string

[richardthe3rd]

Severity: Low

Depends on upstream data quality.

Summary

Producer.fromJson (lib/models/drink.dart:30-31) and Product.fromJson (lib/models/drink.dart:140-141) parse identifiers with json['id'].toString() / json['name'].toString(). If id or name is missing or null, null.toString() produces the literal string "null".

Impact

Multiple records with a missing id all collapse to the id "null", causing:

• ValueKey(drink.id) collisions in list builders (lib/screens/drinks_screen.dart:477, lib/main.dart:435), which can corrupt list rendering/state.
• getDrinkById('null') and brewery lookups matching the wrong record.

Suggested fix

Handle null/empty id and name explicitly — skip the record, or generate a stable synthetic id — rather than coercing to "null".

[richardthe3rd]

Triage: P1 bug — fix next

Root cause: Producer.fromJson (lines 30–31) and Product.fromJson (lines 142–143) in drink.dart call .toString() on potentially-null JSON values. null.toString() produces the literal "null", so multiple records missing id share the same ValueKey, corrupting list rendering and drink lookups.

Fix: replace json['id'].toString() with (json['id'] as String?) ?? '' (and similarly for name). Consider skipping records with an empty id in the repository layer rather than passing them through.

File: lib/models/drink.dart lines 30–31 and 142–143.

---

Generated by Claude Code