Skip to content

Commit e42d350

Browse files
authored
Fix smoke tests (kedacore#7304)
* Fix smoke tests To use `go.mod` version for restoring golang, checkout must happen before golang installation task Signed-off-by: Jorge Turrado Ferrero <[email protected]> * Remove duplicate checkout step in workflow Signed-off-by: Jorge Turrado Ferrero <[email protected]> * Apply suggestions from code review Signed-off-by: Jorge Turrado Ferrero <[email protected]> * Update pr-e2e.yml Signed-off-by: Jorge Turrado Ferrero <[email protected]> --------- Signed-off-by: Jorge Turrado Ferrero <[email protected]>
1 parent ddad469 commit e42d350

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

.github/workflows/pr-e2e.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ env:
1010

1111
jobs:
1212
triage:
13-
runs-on: ubuntu-slim
13+
runs-on: ubuntu-latest
1414
name: Comment evaluate
1515
container: ghcr.io/kedacore/keda-tools:1.25.5
1616
outputs:

.github/workflows/template-s390x-smoke-tests.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,11 @@ jobs:
88
name: Validate k8s
99
runs-on: s390x
1010
steps:
11+
- name: Check out code
12+
uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
13+
with:
14+
fetch-depth: 1
15+
1116
- name: Setup Go
1217
uses: actions/setup-go@4dc6199c7b1a012772edbd06daecab0f50c9053c # v6.1.0
1318
with:
@@ -20,11 +25,6 @@ jobs:
2025
env:
2126
DEBIAN_FRONTEND: noninteractive
2227

23-
- name: Check out code
24-
uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
25-
with:
26-
fetch-depth: 1
27-
2828
- name: Install Kubernetes
2929
run: |
3030
go install sigs.k8s.io/[email protected]

.github/workflows/template-smoke-tests.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,11 @@ jobs:
1818
name: Validate k8s-${{ inputs.kubernetesVersion }}
1919
runs-on: ${{ inputs.runs-on }}
2020
steps:
21+
- name: Check out code
22+
uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
23+
with:
24+
fetch-depth: 1
25+
2126
- name: Setup Go
2227
uses: actions/setup-go@4dc6199c7b1a012772edbd06daecab0f50c9053c # v6.1.0
2328
with:
@@ -30,11 +35,6 @@ jobs:
3035
env:
3136
DEBIAN_FRONTEND: noninteractive
3237

33-
- name: Check out code
34-
uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
35-
with:
36-
fetch-depth: 1
37-
3838
- name: Create k8s ${{ inputs.kubernetesVersion }} Kind Cluster
3939
uses: helm/kind-action@92086f6be054225fa813e0a4b13787fc9088faab # v1.13.0
4040
with:

0 commit comments

Comments
 (0)