Fix joystick rotation (vanilla bug)

Author: rickfay

README.md

@@ -81,6 +81,7 @@ A randomizer for The Legend of Zelda: A Link Between Worlds.
   - Rosso
     - Now appears properly inside his house when rescued, instead of the "Crooked Chest".
   - Rupees will now be named correctly in shops instead of being referred to as "Play Coins"
+  - Fix the vanilla joystick bug that causes all inputs to be rotated 5 degrees counterclockwise.
 - **Logic Changes**
   - All:
     - Dungeons now expect a certain amount of health to be available before entering logic.

presets/Example.json

@@ -1,7 +1,7 @@
 {
   // "Visit the project GitHub for details about each option: https://github.com/rickfay/z17-randomizer/tree/dev#game-options"
   "seed": 0,
-  "version": "v0.4.0 - Beta Build 2024-09-05",
+  "version": "v0.4.0 - Beta Build 2024-12-02",
   "settings": {
 
 

randomizer/src/constants.rs

@@ -1,5 +1,5 @@
 //! Application Constants
 
 /// Build Version
-pub const VERSION: &str = "v0.4.0 - Beta Build 2024-09-05";
+pub const VERSION: &str = "v0.4.0 - Beta Build 2024-12-02";
 pub const CONFIG_FILE_NAME: &str = "config.json";

randomizer/src/patch/code/mod.rs

@@ -178,6 +178,7 @@ pub fn create(patcher: &Patcher, seed_info: &SeedInfo) -> Code {
     // instant text
     code.overwrite(0x17A430, [0xFF]);
 
+    fix_joystick_rotation(&mut code);
     rental_items(&mut code);
     progressive_items(&mut code);
     bracelet(&mut code, &seed_info.settings);
@@ -350,6 +351,19 @@ fn do_dev_stuff(code: &mut Code, seed_info: &SeedInfo) {
     code.patch(0x2559c0, [add(R2, R2, amount)]);
 }
 
+/// For what are certainly reasons, Nintendo decided to rotate all of Link's movements ever so
+/// slightly (about 5 degrees) counterclockwise in the vanilla game. This isn't often complained
+/// about by people who play on physical 3DS hardware because reasons, but is very jarring to folks
+/// who play on Emulators, and makes navigating the Ice Cave much more difficult than intended.
+///
+/// This code sets the rotation angle for each direction to zero, eliminating the issue.
+fn fix_joystick_rotation(code: &mut Code) {
+    code.overwrite(0x6c3ae8, [0x0; 8]); // Fix Down
+    code.overwrite(0x6c3ef0, [0x0; 8]); // Fix Right
+    code.overwrite(0x6c42e8, [0x0; 8]); // Fix Up
+    code.overwrite(0x6c46f0, [0x0; 8]); // Fix Left
+}
+
 /// File Select Screen Background
 /// TODO Figure out how to make background permanent
 #[allow(unused)]