Improve live match fetching logic

ricknout · ricknout · commit 8e66991fdbb4 · 2020-12-21T07:50:58.000+02:00
diff --git a/live/src/main/java/dev/ricknout/rugbyranker/live/ui/LiveMatchViewModel.kt b/live/src/main/java/dev/ricknout/rugbyranker/live/ui/LiveMatchViewModel.kt
@@ -43,7 +43,7 @@ open class LiveMatchViewModel(
     fun refreshLiveMatches(showRefresh: Boolean = true, onComplete: (success: Boolean) -> Unit) {
         if (showRefresh) _refreshingLiveMatches.value = true
         repository.fetchLatestMatchesAsync(sport, status, viewModelScope) { success, matches ->
-            if (success) _liveMatches.value = matches
+            if (success || _liveMatches.value == null) _liveMatches.value = matches
             if (showRefresh) _refreshingLiveMatches.value = false
             onComplete(success)
         }

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ open class LiveMatchViewModel(`
`43`	`43`	`fun refreshLiveMatches(showRefresh: Boolean = true, onComplete: (success: Boolean) -> Unit) {`
`44`	`44`	`if (showRefresh) _refreshingLiveMatches.value = true`
`45`	`45`	`repository.fetchLatestMatchesAsync(sport, status, viewModelScope) { success, matches ->`
`46`		`- if (success) _liveMatches.value = matches`
	`46`	`+ if (success \|\| _liveMatches.value == null) _liveMatches.value = matches`
`47`	`47`	`if (showRefresh) _refreshingLiveMatches.value = false`
`48`	`48`	`onComplete(success)`
`49`	`49`	`}`