Fix App Insights API version, retention parity, bootstrap auth, budget validation

- Revert App Insights API to 2020-02-02 (2020-11-20 does not exist)
- Fix App Insights RetentionInDays 90->30 to match TF parity
- Add Azure auth check to bootstrap-backend.sh
- Add UUID validation to management group subscription ID variables
- Add @minValue(1) to monthlyBudgetAmount in Bicep
- Add @minlength(1) to budgetAlertEmails in Bicep

Author: ricmmartins

examples/api-first-startup/main.bicep

@@ -47,15 +47,15 @@ resource law 'Microsoft.OperationalInsights/workspaces@2023-09-01' = {
   }
 }
 
-resource appInsights 'Microsoft.Insights/components@2020-11-20' = {
+resource appInsights 'Microsoft.Insights/components@2020-02-02' = {
   name: 'ai-${appName}-${environment}'
   location: location
   tags: tags
   kind: 'web'
   properties: {
     Application_Type: 'web'
     WorkspaceResourceId: law.id
-    RetentionInDays: 90
+    RetentionInDays: 30
   }
 }
 

infra/bicep/main.bicep

@@ -18,9 +18,11 @@ param companyName string
 param environment string
 
 @description('Monthly budget amount in USD')
+@minValue(1)
 param monthlyBudgetAmount int
 
 @description('Email addresses for budget alerts')
+@minLength(1)
 param budgetAlertEmails array
 
 @description('Deploy VNet and networking resources')

infra/terraform/modules/management-groups/variables.tf

@@ -10,8 +10,16 @@ variable "display_name" {
 variable "prod_subscription_id" {
   description = "Production subscription ID to place under this management group"
   type        = string
+  validation {
+    condition     = can(regex("^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$", var.prod_subscription_id))
+    error_message = "prod_subscription_id must be a valid UUID."
+  }
 }
 variable "nonprod_subscription_id" {
   description = "Non-production subscription ID to place under this management group"
   type        = string
+  validation {
+    condition     = can(regex("^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$", var.nonprod_subscription_id))
+    error_message = "nonprod_subscription_id must be a valid UUID."
+  }
 }

scripts/bootstrap-backend.sh

@@ -55,6 +55,12 @@ if ! [[ "$STORAGE_ACCOUNT" =~ ^[a-z0-9]{3,24}$ ]]; then
   exit 1
 fi
 
+# Verify Azure CLI authentication
+if ! az account show &>/dev/null; then
+  echo "Error: Not logged in to Azure. Run: az login"
+  exit 1
+fi
+
 echo "=== Bootstrapping Terraform Backend ==="
 echo "  Location:        $LOCATION"
 echo "  Resource Group:  $RESOURCE_GROUP"