Skip to content

Commit 785bd6a

Browse files
committed
Fix storage HTTPS parity and integration test subscription secrets
1 parent 756e738 commit 785bd6a

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

.github/workflows/integration-test.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,10 @@ permissions:
3030

3131
env:
3232
ARM_CLIENT_ID: ${{ secrets.AZURE_CLIENT_ID }}
33-
ARM_SUBSCRIPTION_ID: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
33+
ARM_SUBSCRIPTION_ID: ${{ secrets.AZURE_SUBSCRIPTION_ID_NONPROD }}
3434
ARM_TENANT_ID: ${{ secrets.AZURE_TENANT_ID }}
3535
ARM_USE_OIDC: true
36-
TF_VAR_subscription_id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
36+
TF_VAR_subscription_id: ${{ secrets.AZURE_SUBSCRIPTION_ID_NONPROD }}
3737
TF_VAR_company_name: "lztest"
3838
TF_VAR_environment: "nonprod"
3939
TF_VAR_budget_alert_emails: '["landing-zone-test@contoso.com"]'
@@ -55,7 +55,7 @@ jobs:
5555
with:
5656
client-id: ${{ secrets.AZURE_CLIENT_ID }}
5757
tenant-id: ${{ secrets.AZURE_TENANT_ID }}
58-
subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
58+
subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID_NONPROD }}
5959

6060
- name: Bicep What-If
6161
run: |
@@ -89,7 +89,7 @@ jobs:
8989
with:
9090
client-id: ${{ secrets.AZURE_CLIENT_ID }}
9191
tenant-id: ${{ secrets.AZURE_TENANT_ID }}
92-
subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
92+
subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID_NONPROD }}
9393

9494
- name: Set budget start date
9595
run: echo "TF_VAR_budget_start_date=$(date -u +%Y-%m-01T00:00:00Z)" >> "$GITHUB_ENV"
@@ -131,7 +131,7 @@ jobs:
131131
with:
132132
client-id: ${{ secrets.AZURE_CLIENT_ID }}
133133
tenant-id: ${{ secrets.AZURE_TENANT_ID }}
134-
subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
134+
subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID_NONPROD }}
135135

136136
- name: Set budget start date
137137
run: echo "TF_VAR_budget_start_date=$(date -u +%Y-%m-01T00:00:00Z)" >> "$GITHUB_ENV"

examples/ai-startup/terraform/main.tf

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -303,6 +303,7 @@ resource "azurerm_storage_account" "this" {
303303
account_tier = "Standard"
304304
account_replication_type = "LRS"
305305
min_tls_version = "TLS1_2"
306+
https_traffic_only_enabled = true
306307
allow_nested_items_to_be_public = false
307308
tags = local.tags
308309
}

0 commit comments

Comments
 (0)