Skip to content

Commit 7dababa

Browse files
committed
Fix GPU node count parity, add Bicep RG outputs, update docs accuracy
- Fix GPU node pool initial count: Bicep 1->0 to match TF (avoid surprise cost) - Add resource group name outputs to Bicep main (parity with TF outputs) - Add @description to all Bicep root outputs - Fix docs/networking.md: add port 5432 (PostgreSQL) to data subnet NSG rules - Fix docs/security.md: Defender for Key Vault enabled on both subs, not prod only
1 parent 1755f0d commit 7dababa

File tree

4 files changed

+12
-4
lines changed

4 files changed

+12
-4
lines changed

docs/networking.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,8 +92,8 @@ No inbound rules needed — VNet integration is outbound only.
9292

9393
**For data subnet:**
9494
```
95-
110 Inbound Allow snet-aks snet-data 1433,6380,443 (SQL, Redis, Storage)
96-
120 Inbound Allow snet-app snet-data 1433,6380,443
95+
110 Inbound Allow snet-aks snet-data 1433,5432,6380,443 (SQL, PostgreSQL, Redis, Storage)
96+
120 Inbound Allow snet-app snet-data 1433,5432,6380,443
9797
```
9898

9999
**For shared subnet:**

docs/security.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ Security that protects you without slowing you down. Every recommendation here i
1212
| Defender for Servers P2 | Prod only | ~$15/server/month | EDR via Defender for Endpoint, vulnerability assessment, JIT VM access, adaptive application controls. |
1313
| Defender for Containers | If running AKS | ~$7/vCPU/month | Runtime threat detection, image vulnerability scanning, Kubernetes audit log monitoring. |
1414
| Defender for Databases | Prod only | Varies | SQL/Postgres threat detection — alerts on SQL injection, anomalous access, brute force. |
15-
| Defender for Key Vault | Prod only | ~$0.02/10k transactions | Alerts on unusual access patterns to secrets. Cheap insurance. |
15+
| Defender for Key Vault | Both subs | ~$0.02/10k transactions | Alerts on unusual access patterns to secrets. Cheap insurance. Always enabled by default. |
1616
| Defender for ARM | Both subs | ~$4/sub/month | Detects suspicious control-plane operations (mass deletions, privilege escalation). Always enabled by this landing zone. |
1717
| Defender for Storage | No | ~$10/month per account | Malware scanning. Skip unless you accept user file uploads. |
1818
| Defender for App Service | No | ~$15/month per instance | Limited value compared to other plans. Revisit later. |

examples/ai-startup/main.bicep

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ resource gpuNodePool 'Microsoft.ContainerService/managedClusters/agentPools@2024
118118
name: 'gpu'
119119
properties: {
120120
mode: 'User'
121-
count: 1
121+
count: 0
122122
minCount: 0
123123
maxCount: 3
124124
enableAutoScaling: true

infra/bicep/main.bicep

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,15 @@ module policies 'modules/policy-assignments.bicep' = {
174174
// Outputs
175175
// ============================================================================
176176

177+
@description('Monitoring resource group name')
178+
output resourceGroupMonitoring string = rgMonitoring
179+
@description('Networking resource group name')
180+
output resourceGroupNetworking string = deployNetworking ? rgNetworking : ''
181+
@description('Log Analytics workspace resource ID')
177182
output logAnalyticsWorkspaceId string = logAnalytics.outputs.workspaceId
183+
@description('Log Analytics workspace name')
178184
output logAnalyticsWorkspaceName string = logAnalytics.outputs.workspaceName
185+
@description('Virtual network resource ID')
179186
output vnetId string = deployNetworking ? networking.outputs.vnetId : ''
187+
@description('Virtual network name')
180188
output vnetName string = deployNetworking ? networking.outputs.vnetName : ''

0 commit comments

Comments
 (0)