Fix CI nits ✅ (AFLplusplus#3475)

* Un-shared

* Fix all the rest

* more just?

* more

* more fix

* nau?

Author: domenukk

.github/workflows/asan-prepare/action.yml

@@ -45,9 +45,7 @@ runs:
           wget
     - uses: dtolnay/rust-toolchain@stable
     - name: install just
-      uses: extractions/setup-just@v2
-      with:
-        just-version: '1.40.0'
+      uses: extractions/setup-just@v3
     - name: Install cargo-binstall
       shell: bash
       run: |

.github/workflows/fuzzer-tester-prepare/action.yml

@@ -32,9 +32,7 @@ runs:
       shell: bash
       run: sudo apt update && sudo apt install -y libgtk-3-dev pax-utils python3-msgpack python3-jinja2 libcapstone-dev
     - name: install just
-      uses: extractions/setup-just@v2
-      with:
-        just-version: '1.40.0'
+      uses: extractions/setup-just@v3
     - name: Add wasm target
       if: ${{ inputs.fuzzer-name == 'fuzz_anything/baby_fuzzer_wasm' }}
       shell: bash

.github/workflows/qemu-fuzzer-tester-prepare/action.yml

@@ -17,9 +17,7 @@ runs:
       shell: bash
       run: export MAKEFLAGS="-j$(expr $(nproc) \+ 1)"
     - name: install just
-      uses: extractions/setup-just@v2
-      with:
-        just-version: '1.40.0'
+      uses: extractions/setup-just@v3
     - uses: actions/checkout@v4
       with:
         submodules: true

.github/workflows/ubuntu-prepare/action.yml

@@ -40,9 +40,7 @@ runs:
     # -----------------------------------------
 
     - name: Install just
-      uses: extractions/setup-just@v2
-      with:
-        just-version: '1.40.0'
+      uses: extractions/setup-just@v3
 
     - uses: taiki-e/install-action@cargo-hack
 

.github/workflows/windows-tester-prepare/action.yml

@@ -16,6 +16,4 @@ runs:
       shell: pwsh
       run: echo "LIBCLANG_PATH=$((gcm clang).source -replace "clang.exe")" >> $env:GITHUB_ENV
     - name: install just
-      uses: extractions/setup-just@v2
-      with:
-        just-version: '1.40.0'
+      uses: extractions/setup-just@v3

Dockerfile

@@ -1,5 +1,5 @@
 # syntax=docker/dockerfile:1.2
-FROM rust:1.87.0 AS libafl
+FROM rust:1.91.0 AS libafl
 LABEL "maintainer"="afl++ team <afl@aflplus.plus>"
 LABEL "about"="LibAFL Docker image"
 
@@ -63,7 +63,6 @@ RUN apt-get update && \
     python3 \
     python3-pip \
     python3-venv \
-    software-properties-common \
     ca-certificates \
     wget
 RUN set -ex &&\

crates/libafl/src/executors/command.rs

@@ -215,7 +215,7 @@ impl CommandConfigurator<Child> for StdCommandConfigurator {
 
 /// Linux specific [`CommandConfigurator`] that leverages `ptrace`
 ///
-/// This configurator was primarly developed to be used in conjunction with
+/// This configurator was primarily developed to be used in conjunction with
 /// [`crate::executors::hooks::intel_pt::IntelPTHook`]
 #[cfg(all(feature = "intel_pt", target_os = "linux"))]
 #[derive(Debug, Clone, PartialEq, Eq, TypedBuilder)]
@@ -305,7 +305,7 @@ impl CommandConfigurator<Pid> for PTraceCommandConfigurator {
         Duration::from_secs(u64::from(self.timeout))
     }
 
-    /// Use [`PTraceCommandConfigurator::builder().timeout`] instead
+    /// Use [`PTraceCommandConfigurator::builder()`](PTraceCommandConfigurator) instead
     fn exec_timeout_mut(&mut self) -> &mut Duration {
         unimplemented!("Use [`PTraceCommandConfigurator::builder().timeout`] instead")
     }

crates/libafl_bolts/src/anymap.rs

@@ -2,8 +2,8 @@
 
 use core::{any::TypeId, mem::size_of, ptr::read_unaligned};
 
-/// Get a `type_id` from its previously unpacked `u128`.
-/// Opposite of [`unpack_type_id(id)`].
+/// Get a [`TypeId`] from its previously unpacked `u128`.
+/// Opposite of [`unpack_type_id`].
 ///
 /// # Note
 /// Probably not safe for future compilers, fine for now.
@@ -16,8 +16,8 @@ pub const fn pack_type_id(id: u128) -> TypeId {
     unsafe { *(&raw const id as *const TypeId) }
 }
 
-/// Unpack a `type_id` to an `u128`
-/// Opposite of [`pack_type_id(id)`].
+/// Unpack a [`TypeId`] to an `u128`
+/// Opposite of [`pack_type_id`].
 ///
 /// # Note
 /// Probably not safe for future compilers, fine for now.

crates/libafl_bolts/src/llmp.rs

@@ -1326,7 +1326,7 @@ where
     }
 
     /// Create this client on an existing map from the given description.
-    /// Acquired with [`self.describe`].
+    /// Acquired with [`LlmpSender::describe`].
     pub fn on_existing_from_description(
         mut shmem_provider: SP,
         description: &LlmpDescription,
@@ -3005,7 +3005,7 @@ where
     }
 
     /// Registers a new client for the given sharedmap str and size.
-    /// Returns the id of the new client in [`broker.client_shmem`]
+    /// Returns the [`ClientId`] of the newly registered client.
     pub fn register_client(&mut self, mut client_page: LlmpSharedMap<SHM>) -> ClientId {
         // Tell the client it may unmap its initial allocated shmem page now.
         // Since we now have a handle to it, it won't be umapped too early (only after we also unmap it)
@@ -3614,7 +3614,7 @@ where
         })
     }
 
-    /// Recreate this client from a previous [`client.to_env()`]
+    /// Recreate this client from a previous [`LlmpClient::to_env`]
     #[cfg(feature = "std")]
     pub fn on_existing_from_env(shmem_provider: SP, env_name: &str) -> Result<Self, Error> {
         Ok(Self {

crates/libafl_bolts/src/target_args.rs

@@ -24,7 +24,7 @@ pub enum InputLocation {
         input_file: Option<InputFile>,
     },
     /// Deliver the input via the specified [`InputFile`]
-    /// You can use specify [`InputFile::create(INPUTFILE_STD)`] to use a default filename.
+    /// You can use [`InputFile::create`] with [`crate::fs::INPUTFILE_STD`] to use a default filename.
     File {
         /// The file to write input to. The target should read input from this location.
         out_file: InputFile,