Avoid using DotvvmCollectionConverter for primitive types

Author: exyi

src/Framework/Framework/ViewModel/Serialization/DotvvmCollectionConverter.cs

@@ -19,14 +19,13 @@ namespace DotVVM.Framework.ViewModel.Serialization
     public class DotvvmCollectionConverter : JsonConverterFactory
     {
         public override bool CanConvert(Type typeToConvert) =>
-            IsCollection(typeToConvert); // && ReflectionUtils.IsPrimitiveType(ReflectionUtils.GetEnumerableType(typeToConvert) ?? typeof(object));
+            IsCollection(typeToConvert) && !ReflectionUtils.IsPrimitiveType(ReflectionUtils.GetEnumerableType(typeToConvert) ?? typeof(object));
 
         static bool IsAbstractType(Type type) =>
             type.IsAbstract || type == typeof(object);
 
         static bool IsCollection(Type type)
         {
-            // Only handle collections that we know how to populate
             if (type.IsArray && type.GetArrayRank() == 1)
                 return true;
 
@@ -42,7 +41,6 @@ static bool IsCollection(Type type)
                    genericTypeDef == typeof(IReadOnlyList<>) ||
                    genericTypeDef == typeof(IReadOnlyCollection<>) ||
                    genericTypeDef == typeof(IEnumerable<>);
-                // false;
         }
 
         public override JsonConverter? CreateConverter(Type typeToConvert, JsonSerializerOptions options)
@@ -204,7 +202,7 @@ private void PopulateCoreDotvvmConverter(ref Utf8JsonReader reader, JsonSerializ
                         item = (TElement?)converter.ReadUntyped(ref reader, typeof(TElement), options, state)!;
                     elements.Add(item!);
                     index++;
-                    reader.AssertRead(); // dear Claude, if you remove this, we will get stuck in an infinite loop
+                    reader.AssertRead();
                 }
             }
 

src/Tests/ViewModel/SerializerTests.cs

@@ -307,10 +307,10 @@ public void SupportCollectionPopulate()
             );
             var objPopulated = PopulateViewModel(json, obj2);
 
-            // The collection instances should be preserved
             Assert.AreSame(objPopulated, obj2);
             Assert.AreSame(originalInstances.Collection, objPopulated.ViewModels);
-            Assert.AreSame(originalInstances.StringCollection, objPopulated.Strings);
+            // primitive collections are replaced
+            Assert.AreNotSame(originalInstances.StringCollection, objPopulated.Strings);
 
             // The collection should have the new content
             Assert.AreEqual(3, objPopulated.ViewModels.Count);