Skip to content

Commit 42d0479

Browse files
committed
Fix #140 getting Error on emitWithAck() in v2 beta
1 parent 4a7cd1c commit 42d0479

File tree

3 files changed

+9
-3
lines changed

3 files changed

+9
-3
lines changed

CHANGELOG.md

+6
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,9 @@
1+
## 2.0.0-beta.2
2+
3+
**Bug fix:**
4+
5+
* [#140](https://github.com/rikulo/socket.io-client-dart/issues/140) getting Error on emitWithAck() in v2 beta
6+
17
## 2.0.0-beta.1
28

39
**New Feature:**

lib/src/socket.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -302,7 +302,7 @@ class Socket extends EventEmitter {
302302
/// @param {Object} packet
303303
/// @api private
304304
void onack(Map packet) {
305-
var ack = acks.remove(packet['id']);
305+
var ack = acks.remove('${packet['id']}');
306306
if (ack is Function) {
307307
_logger.fine('''calling ack ${packet['id']} with ${packet['data']}''');
308308

pubspec.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: socket_io_client
22
description: Dartlang port of socket.io-client for web, flutter, dartvm to use
3-
version: 2.0.0-beta.1
3+
version: 2.0.0-beta.2
44
homepage: https://www.zkoss.org
55
repository: https://github.com/rikulo/socket.io-client-dart
66
issue_tracker: https://github.com/rikulo/socket.io-client-dart/issues
@@ -10,7 +10,7 @@ environment:
1010

1111
dependencies:
1212
logging: ^0.11.3+2
13-
socket_io_common: ^2.0.0-beta.0
13+
socket_io_common: ^2.0.0-beta.1
1414

1515
dev_dependencies:
1616
test: ">=1.3.0 <2.0.0"

0 commit comments

Comments
 (0)