Skip to content

Commit 577c55d

Browse files
committed
Fix for pub scores about formatting
1 parent 3239014 commit 577c55d

File tree

7 files changed

+73
-64
lines changed

7 files changed

+73
-64
lines changed

lib/src/engine/socket.dart

+22-22
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,6 @@ class Socket extends EventEmitter {
9999
...opts,
100100
};
101101

102-
103102
this.opts['path'] =
104103
this.opts['path'].toString().replaceFirst(RegExp(r'/$'), '') +
105104
(this.opts['addTrailingSlash'] ? '/' : '');
@@ -128,7 +127,6 @@ class Socket extends EventEmitter {
128127
/// @api public
129128
static int protocol = parser.protocol; // this is an int
130129

131-
132130
///
133131
/// Creates transport of the given type.
134132
///
@@ -250,21 +248,21 @@ class Socket extends EventEmitter {
250248

251249
_logger.fine('pausing current transport "${transport?.name}"');
252250
this.transport?.pause(() {
253-
if (failed) return;
254-
if ('closed' == readyState) return;
255-
_logger.fine('changing transport and sending upgrade packet');
256-
257-
cleanup();
258-
259-
setTransport(transport);
260-
transport!.send([
261-
{'type': 'upgrade'}
262-
]);
263-
emit('upgrade', transport);
264-
transport = null;
265-
upgrading = false;
266-
flush();
267-
});
251+
if (failed) return;
252+
if ('closed' == readyState) return;
253+
_logger.fine('changing transport and sending upgrade packet');
254+
255+
cleanup();
256+
257+
setTransport(transport);
258+
transport!.send([
259+
{'type': 'upgrade'}
260+
]);
261+
emit('upgrade', transport);
262+
transport = null;
263+
upgrading = false;
264+
flush();
265+
});
268266
} else {
269267
_logger.fine('probe transport "$name" failed');
270268
emitReserved('upgradeError',
@@ -428,10 +426,13 @@ class Socket extends EventEmitter {
428426
///
429427
void resetPingTimeout() {
430428
pingTimeoutTimer?.cancel();
431-
pingTimeoutTimer =
432-
Timer(Duration(milliseconds: pingInterval != null && pingTimeout != null ? (pingInterval! + pingTimeout!) : 0), () {
433-
onClose('ping timeout');
434-
});
429+
pingTimeoutTimer = Timer(
430+
Duration(
431+
milliseconds: pingInterval != null && pingTimeout != null
432+
? (pingInterval! + pingTimeout!)
433+
: 0), () {
434+
onClose('ping timeout');
435+
});
435436
}
436437

437438
///
@@ -462,7 +463,6 @@ class Socket extends EventEmitter {
462463
transport!.writable == true &&
463464
upgrading != true &&
464465
writeBuffer.isNotEmpty) {
465-
466466
final packets = getWritablePackets();
467467
_logger.fine('flushing ${packets.length} packets in socket');
468468
transport!.send(packets);

lib/src/engine/transport.dart

+3-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,8 @@ abstract class Transport extends EventEmitter {
3131
/// @param {String} str
3232
/// @return {Transport} for chaining
3333
onError(msg, [desc]) {
34-
super.emitReserved('error', {'msg': msg, 'desc': desc, 'type': 'TransportError'});
34+
super.emitReserved(
35+
'error', {'msg': msg, 'desc': desc, 'type': 'TransportError'});
3536
return this;
3637
}
3738

@@ -102,6 +103,7 @@ abstract class Transport extends EventEmitter {
102103
readyState = 'closed';
103104
emitReserved('close', details);
104105
}
106+
105107
get name;
106108

107109
void pause(Function() onPause) {}

lib/src/engine/transport/polling_transport.dart

+8-11
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,15 @@ import 'package:socket_io_client/src/engine/transport.dart';
1717
import 'package:socket_io_common/src/engine/parser/parser.dart';
1818
import 'package:socket_io_common/src/util/event_emitter.dart';
1919

20-
2120
final Logger _logger = Logger('socket_io:transport.PollingTransport');
2221

2322
bool _hasXHR2() {
2423
try {
2524
// Dart's HttpRequest doesn't expose a direct way to check for XHR2 features,
2625
// but attempting to use features like setting `responseType` could serve as a proxy.
2726
final xhr = HttpRequest();
28-
xhr.responseType = 'arraybuffer'; // Attempting to set a responseType supported by XHR2
27+
xhr.responseType =
28+
'arraybuffer'; // Attempting to set a responseType supported by XHR2
2929
return true;
3030
} catch (e) {
3131
return false;
@@ -240,14 +240,10 @@ class PollingTransport extends Transport {
240240

241241
Request request([Map? opts]) {
242242
opts = opts ?? {};
243-
final mergedOpts = {
244-
...opts,
245-
xd: xd,
246-
cookieJar: cookieJar,
247-
...this.opts
248-
};
243+
final mergedOpts = {...opts, xd: xd, cookieJar: cookieJar, ...this.opts};
249244
return Request(uri(), mergedOpts);
250245
}
246+
251247
///
252248
/// Sends data.
253249
///
@@ -279,6 +275,7 @@ class PollingTransport extends Transport {
279275
pollXhr = req;
280276
}
281277
}
278+
282279
class Request extends EventEmitter {
283280
late Map opts;
284281
late String method;
@@ -322,7 +319,8 @@ class Request extends EventEmitter {
322319
xhr.open(method, uri, async: true);
323320

324321
try {
325-
if (this.opts.containsKey('extraHeaders') && this.opts['extraHeaders']?.isNotEmpty == true) {
322+
if (this.opts.containsKey('extraHeaders') &&
323+
this.opts['extraHeaders']?.isNotEmpty == true) {
326324
this.opts['extraHeaders'].forEach((k, v) {
327325
xhr.setRequestHeader(k, v);
328326
});
@@ -333,7 +331,7 @@ class Request extends EventEmitter {
333331

334332
if ('POST' == method) {
335333
try {
336-
xhr.setRequestHeader('Content-type', 'text/plain;charset=UTF-8');
334+
xhr.setRequestHeader('Content-type', 'text/plain;charset=UTF-8');
337335
} catch (e) {
338336
// ignore
339337
}
@@ -433,5 +431,4 @@ class Request extends EventEmitter {
433431
///
434432
/// @api public
435433
void abort() => cleanup();
436-
437434
}

lib/src/engine/transport/websocket_transport.dart

+3-3
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,9 @@ class WebSocketTransport extends Transport {
5151
ws!
5252
..onOpen.listen((_) => onOpen())
5353
..onClose.listen((closeEvent) => onClose({
54-
'description': "websocket connection closed",
55-
'context': closeEvent,
56-
}))
54+
'description': "websocket connection closed",
55+
'context': closeEvent,
56+
}))
5757
..onMessage.listen((MessageEvent evt) => onData(evt.data))
5858
..onError.listen((e) {
5959
onError('websocket error', e);

lib/src/manager.dart

+17-14
Original file line numberDiff line numberDiff line change
@@ -171,18 +171,21 @@ class Manager extends EventEmitter {
171171

172172
Function(dynamic error) onError;
173173
// emit `connect_error`
174-
var errorSub = util.on(socket, 'error', onError = (error) {
175-
_logger.fine('error');
176-
cleanup();
177-
readyState = 'closed';
178-
emitReserved('error', error);
179-
if (callback != null) {
180-
callback({'error': 'Connection error', 'data': error});
181-
} else {
182-
// Only do this if there is no fn to handle the error
183-
maybeReconnectOnOpen();
184-
}
185-
});
174+
var errorSub = util.on(
175+
socket,
176+
'error',
177+
onError = (error) {
178+
_logger.fine('error');
179+
cleanup();
180+
readyState = 'closed';
181+
emitReserved('error', error);
182+
if (callback != null) {
183+
callback({'error': 'Connection error', 'data': error});
184+
} else {
185+
// Only do this if there is no fn to handle the error
186+
maybeReconnectOnOpen();
187+
}
188+
});
186189

187190
// emit `connect_timeout`
188191
if (timeout != null) {
@@ -209,12 +212,12 @@ class Manager extends EventEmitter {
209212
return this;
210213
}
211214

212-
213215
/// Alias for open()
214216
///
215217
/// @return self
216218
/// @public
217-
Manager connect({callback, Map? opts}) => open(callback: callback, opts: opts);
219+
Manager connect({callback, Map? opts}) =>
220+
open(callback: callback, opts: opts);
218221

219222
///
220223
/// Called upon transport open.

lib/src/socket.dart

+12-9
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ import 'package:socket_io_client/src/manager.dart';
1818
import 'package:socket_io_client/src/on.dart' as util;
1919
import 'package:socket_io_common/src/parser/parser.dart';
2020

21-
2221
const reservedEvents = <String, int>{
2322
'connect': 1,
2423
'connect_error': 1,
@@ -158,15 +157,16 @@ class Socket extends EventEmitter {
158157
sendData.add(data);
159158
}
160159

161-
if (_opts?['retries'] != null && !flags.containsKey('fromQueue') && !flags.containsKey('volatile')) {
160+
if (_opts?['retries'] != null &&
161+
!flags.containsKey('fromQueue') &&
162+
!flags.containsKey('volatile')) {
162163
if (ack != null) {
163164
sendData.add(ack);
164165
}
165166
_addToQueue(sendData);
166167
return;
167168
}
168169

169-
170170
var packet = {
171171
'type': EVENT,
172172
'data': sendData,
@@ -187,16 +187,14 @@ class Socket extends EventEmitter {
187187
final discardPacket =
188188
flags['volatile'] != null && (!isTransportWritable || !connected);
189189
if (discardPacket) {
190-
_logger
191-
.fine('discard packet as the transport is not currently writable');
190+
_logger.fine('discard packet as the transport is not currently writable');
192191
} else if (connected) {
193192
notifyOutgoingListeners(packet);
194193
this.packet(packet);
195194
} else {
196195
sendBuffer.add(packet);
197196
}
198197
flags = {};
199-
200198
}
201199

202200
/// Emits an event and waits for an acknowledgement
@@ -245,7 +243,8 @@ class Socket extends EventEmitter {
245243
if (packet['tryCount'] is int &&
246244
_opts!['retries'] is int &&
247245
(packet['tryCount'] as int) > (_opts!['retries'] as int)) {
248-
_logger.fine("packet [${packet['id']}] is discarded after ${packet['tryCount']} tries");
246+
_logger.fine(
247+
"packet [${packet['id']}] is discarded after ${packet['tryCount']} tries");
249248
_queue.removeAt(0);
250249
if (ack != null) {
251250
ack(err);
@@ -265,25 +264,29 @@ class Socket extends EventEmitter {
265264
_queue.add(packet);
266265
_drainQueue();
267266
}
267+
268268
void _drainQueue([bool force = false]) {
269269
_logger.fine("draining queue");
270270
if (!connected || _queue.isEmpty) {
271271
return;
272272
}
273273
var packet = _queue.first;
274274
if (packet['pending'] && !force) {
275-
_logger.fine("packet [${packet['id']}] has already been sent and is waiting for an ack");
275+
_logger.fine(
276+
"packet [${packet['id']}] has already been sent and is waiting for an ack");
276277
return;
277278
}
278279
packet['pending'] = true;
279280
packet['tryCount']++;
280-
_logger.fine("sending packet [${packet['id']}] (try n°${packet['tryCount']})");
281+
_logger
282+
.fine("sending packet [${packet['id']}] (try n°${packet['tryCount']})");
281283
flags = packet['flags'];
282284
var args = packet['args'] as List;
283285
final evt = args.removeAt(0);
284286
final ack = args.last is Function ? args.removeLast() : null;
285287
emitWithAck(evt, args, ack: ack);
286288
}
289+
287290
void _registerAckCallback(int id, Function ack) {
288291
final sid = '$id';
289292
final timeout = flags['timeout'] ?? _opts?['ackTimeout'];

web/main.dart

+8-4
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,11 @@ import 'package:socket_io_common/socket_io_common.dart';
1717
void main() {
1818
var socket = io.io(
1919
'http://localhost:3000',
20-
io.OptionBuilder().setTransports(['polling'])
21-
.setParser(io.ParserOptions(encoder: () => MyEncoder(), decoder: () => MyDecoder()))
22-
// .disableAutoConnect()
20+
io.OptionBuilder()
21+
.setTransports(['polling'])
22+
.setParser(io.ParserOptions(
23+
encoder: () => MyEncoder(), decoder: () => MyDecoder()))
24+
// .disableAutoConnect()
2325
.build());
2426

2527
// socket.connect();
@@ -37,17 +39,19 @@ void main() {
3739
socket.on('disconnect', (_) => print('disconnect'));
3840
socket.on('fromServer', (_) => print(_));
3941
}
42+
4043
class MyEncoder extends Encoder {
4144
@override
4245
List<Object?> encode(Object? obj) {
4346
print('MyEncoder: $obj');
4447
return super.encode(obj);
4548
}
4649
}
50+
4751
class MyDecoder extends Decoder {
4852
@override
4953
add(obj) {
5054
print('MyDecoder: $obj');
5155
return super.add(obj);
5256
}
53-
}
57+
}

0 commit comments

Comments
 (0)