Skip to content

Commit 740b0ed

Browse files
committed
1. Fixed #394 Incorrect argument matching in notifyOutgoingListeners
2. Bump 3.0.0-beta.4
1 parent fcd1a36 commit 740b0ed

File tree

4 files changed

+10
-2
lines changed

4 files changed

+10
-2
lines changed

CHANGELOG.md

+5
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
## 3.0.0-beta.4
2+
3+
**Bug fix:**
4+
* [#394](https://github.com/rikulo/socket.io-client-dart/issues/394) Incorrect argument matching in notifyOutgoingListeners
5+
16
## 3.0.0-beta.3
27

38
**Bug fix:**

lib/src/socket.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -319,7 +319,7 @@ class Socket extends EventEmitter {
319319
if (_anyOutgoingListeners.isNotEmpty) {
320320
final listeners = List.from(_anyOutgoingListeners);
321321
for (final listener in listeners) {
322-
Function.apply(listener, [packet['data']]);
322+
Function.apply(listener, packet['data']);
323323
}
324324
}
325325
}

pubspec.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: socket_io_client
22
description: Dartlang port of socket.io-client for web, flutter, dartvm to use
3-
version: 3.0.0-beta.3
3+
version: 3.0.0-beta.4
44
homepage: https://www.zkoss.org
55
repository: https://github.com/rikulo/socket.io-client-dart
66
issue_tracker: https://github.com/rikulo/socket.io-client-dart/issues

test/io_client.dart

+3
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,9 @@ void main() {
1313

1414
// socket.connect();
1515

16+
// Test for #394
17+
socket.onAnyOutgoing((event, data) => print('outgoing: $event, data: $data'));
18+
1619
socket.onConnect((_) {
1720
socket.emit('toServer', 'init');
1821

0 commit comments

Comments
 (0)