fix: canvas analyst chat not showing up in embed (#8938)

* fix: canvas analyst chat not showing up in embed

* fix lint

Author: AdityaHegde

web-admin/src/features/embeds/TopNavigationBarEmbed.svelte

@@ -6,7 +6,6 @@
   import { featureFlags } from "@rilldata/web-common/features/feature-flags";
   import LastRefreshedDate from "@rilldata/web-admin/features/dashboards/listing/LastRefreshedDate.svelte";
   import ChatToggle from "@rilldata/web-common/features/chat/layouts/sidebar/ChatToggle.svelte";
-  import { ResourceKind } from "@rilldata/web-common/features/entity-management/resource-selectors.ts";
   import type {
     V1Resource,
     V1ResourceName,
@@ -19,12 +18,9 @@
   const { twoTieredNavigation, dashboardChat } = featureFlags;
 
   $: onProjectPage = !activeResource;
+  $: showDashboardChat = $dashboardChat && !onProjectPage;
 
-  $: shouldRender =
-    navigationEnabled ||
-    ($dashboardChat &&
-      (activeResource?.kind === ResourceKind.Explore.toString() ||
-        activeResource?.kind === ResourceKind.MetricsView.toString()));
+  $: shouldRender = navigationEnabled || showDashboardChat;
 
   // Dashboard breadcrumb
   $: dashboardsQuery = useValidDashboards(instanceId);
@@ -87,7 +83,7 @@
       <div class="flex-1" />
     {/if}
 
-    {#if $dashboardChat && (activeResource?.kind === ResourceKind.Explore.toString() || activeResource?.kind === ResourceKind.MetricsView.toString())}
+    {#if showDashboardChat}
       <div class="flex gap-x-4 items-center">
         <LastRefreshedDate dashboard={activeResource?.name} />
         <ChatToggle />

web-admin/src/routes/-/embed/+layout.svelte

@@ -46,13 +46,20 @@
     name: $page.params.name,
   };
 
-  $: showTopBar =
-    navigationEnabled ||
-    ($dashboardChat &&
-      (activeResource?.kind === ResourceKind.Explore.toString() ||
-        activeResource?.kind === ResourceKind.MetricsView.toString()));
   $: onProjectPage = !activeResource;
 
+  $: showDashboardChat = $dashboardChat && !onProjectPage;
+  // Resource kind can be metrics view in some cases. But internally to render it will have to have an equivalent explore.
+  $: correctedKindForChat =
+    activeResource?.kind === ResourceKind.MetricsView
+      ? ResourceKind.Explore
+      : (activeResource?.kind as
+          | ResourceKind.Explore
+          | ResourceKind.Canvas
+          | undefined);
+
+  $: showTopBar = navigationEnabled || showDashboardChat;
+
   // Suppress browser back/forward
   beforeNavigate((nav) => {
     if (!navigationEnabled) {
@@ -143,8 +150,8 @@
       <div class="flex-1 overflow-hidden">
         <slot />
       </div>
-      {#if $dashboardChat && activeResource?.kind === ResourceKind.Explore}
-        <DashboardChat />
+      {#if showDashboardChat && correctedKindForChat}
+        <DashboardChat kind={correctedKindForChat} />
       {/if}
     </div>
   </RuntimeProvider>