Skip to content

Conversation

@briangregoryholmes
Copy link
Contributor

@briangregoryholmes briangregoryholmes commented Aug 28, 2025

This PR adds a UI path (via the range selection dropdown) for changing the time dimension used for measure and dimension queries on the Explore surface. The currently selected time dimension is synced to the URL state using the key td.

In a follow up PR:

  • Add support for secondary time dimension selection on Canvas

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@briangregoryholmes briangregoryholmes self-assigned this Aug 28, 2025
@ericpgreen2 ericpgreen2 changed the title [APP-157] feat: secondary time column selection on explore [APP-183] feat: secondary time column selection on explore Sep 16, 2025
@ericpgreen2
Copy link
Contributor

I believe I missed the demo of this feature when I was OOO, so I'm a little out-of-the-loop. What's the status on this?

@briangregoryholmes
Copy link
Contributor Author

This is ready. Just need #7779 and #7857 to merge first.

@briangregoryholmes briangregoryholmes marked this pull request as ready for review September 30, 2025 15:57
@bito-code-review
Copy link

The suggestion is to rename the newly added time_column field to time_dimension for consistency with existing terminology. Looking at the ExplorePreset struct, there are already fields like dimensions and comparison_dimension that use the "dimension" terminology to represent aggregatable fields in the metrics layer, which may not correspond to actual database table columns.

proto/gen/rill/runtime/v1/resources.pb.go

// Current addition:
+	TimeColumn      *string `protobuf:"bytes,33,opt,name=time_column,json=timeColumn,proto3,oneof" json:"time_column,omitempty"`

// Should be renamed to:
+	TimeDimension   *string `protobuf:"bytes,33,opt,name=time_dimension,json=timeDimension,proto3,oneof" json:"time_dimension,omitempty"`

@ericpgreen2
Copy link
Contributor

@mindspank, can you please do the Product review? For one, can you ensure all views (e.g. leaderboards, time dimension detail, pivot) are consistent?

@AdityaHegde, can you please do the code review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants