Project share user count #8625
Draft
Project share user count #8625
+20
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd pageSize: 1. Co-authored-by: eric.okuma <[email protected]>
|
Cursor Agent can help with this pull request. Just |
…re popover The project share popover was displaying a maximum of 20 users because it was counting members.length from a paginated API response with default pageSize of 20. Changed to use ListOrganizationMemberUsergroups with includeCounts: true to get the usersCount from the autogroup:members group, which: - Returns the accurate total count (not limited by pagination) - Specifically excludes guest users (autogroup:members = non-guests only) Also fixed a bug where queries were using enabled: open but the dropdown was bound to accessDropdownOpen, causing queries to never execute. Resolves APP-524
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-524. The project share popover incorrectly displayed a maximum of 20 users.
This PR updates
GeneralAccessSelectorDropdown.svelteto correctly display the total user count by:createAdminServiceListUsergroupMemberUserstocreateAdminServiceListOrganizationMemberUsersto leverage itstotalCountfield.ListOrganizationMemberUserswithpageSize: 1to efficiently retrieve only the total count.accessDropdownOpento ensure the API call triggers when the dropdown is visible.Checklist:
Linear Issue: APP-524