Code Review Agent Run Status

• Limitations and other issues: ❌ Failure - Bito Automatic Review Skipped - Draft PR
  
  Bito didn't auto-review because this pull request is in draft status.
  To trigger review, mark the PR as ready or type /review in the comment and save.
  You can change draft PR review settings here, or contact the agent instance creator at [email protected].

Code Review Agent Run Status

• Limitations and other issues: ❌ Failure - Bito Automatic Review Skipped - Draft PR
  
  Bito didn't auto-review because this pull request is in draft status.
  To trigger review, mark the PR as ready or type /review in the comment and save.
  You can change draft PR review settings here, or contact the agent instance creator at [email protected].

I don't necessarily think this should hold anything up, but my impression was that we wanted to default to a donut chart visualization rather than a pie chart, which would mean our default inner radius should be something other than 0.

I also think inner radius is maybe the wrong control to expose. It should be relative to the outer radius of the pie chart, which is not user controllable and determined responsively by the size/positioning of the widget. It's more a "thickness" property that goes from, you know, 10% to 100%. You can see the issue when you set the inner radius to something large and then resize the widget container to something small.

I also think inner radius is maybe the wrong control to expose. It should be relative to the outer radius of the pie chart, which is not user controllable and determined responsively by the size/positioning of the widget. It's more a "thickness" property that goes from, you know, 10% to 100%. You can see the issue when you set the inner radius to something large and then resize the widget container to something small.

This makes sense. Vega doesn't support percentage values for radius out of the box but I think there's a way to have relative inner radius using expression functions. I will take this as a follow up so that this and the legend PR are unblocked.