Merge pull request #211 from shamoo53/Remove-Hardcoded-User-IDs-and-Magic-Values

Remove-Hardcoded-User-IDs-and-Magic-Values

Author: RUKAYAT-CODER

declarations.d.ts

@@ -1,2 +1,2 @@
 declare module 'langchain/embeddings/openai';
-declare module 'langchain/embeddings/hf'; 
+declare module 'langchain/embeddings/hf';

package-lock.json

@@ -10,16 +10,21 @@ import {
   Logger,
   HttpCode,
   HttpStatus,
+  UseGuards,
+  Request,
 } from '@nestjs/common';
-import { ABTestingService } from './ab-testing.service';
+import { ABTestingService, CreateExperimentDto } from './ab-testing.service';
 import { ExperimentService } from './experiments/experiment.service';
 import { StatisticalAnalysisService } from './analysis/statistical-analysis.service';
 import { AutomatedDecisionService } from './automation/automated-decision.service';
 import { ABTestingReportsService } from './reporting/ab-testing-reports.service';
-import { CreateExperimentDto } from './ab-testing.service';
-import { ExperimentStatus, ExperimentType } from './entities/experiment.entity';
+import { JwtAuthGuard } from '../auth/guards/jwt-auth.guard';
+import { RolesGuard } from '../auth/guards/roles.guard';
+import { Roles } from '../auth/decorators/roles.decorator';
+import { UserRole } from '../users/entities/user.entity';
 
 @Controller('ab-testing')
+@UseGuards(JwtAuthGuard, RolesGuard)
 export class ABTestingController {
   private readonly logger = new Logger(ABTestingController.name);
 
@@ -32,6 +37,7 @@ export class ABTestingController {
   ) {}
 
   @Get('experiments')
+  @Roles(UserRole.ADMIN, UserRole.TEACHER)
   async getAllExperiments() {
     this.logger.log('Fetching all experiments');
     return await this.abTestingService.getAllExperiments();
@@ -45,34 +51,39 @@ export class ABTestingController {
 
   @Post('experiments')
   @HttpCode(HttpStatus.CREATED)
-  async createExperiment(@Body() createExperimentDto: CreateExperimentDto) {
+  @Roles(UserRole.ADMIN)
+  async createExperiment(@Request() req, @Body() createExperimentDto: CreateExperimentDto) {
     this.logger.log(`Creating new experiment: ${createExperimentDto.name}`);
     return await this.abTestingService.createExperiment(createExperimentDto);
   }
 
   @Post('experiments/:id/start')
   @HttpCode(HttpStatus.OK)
+  @Roles(UserRole.ADMIN)
   async startExperiment(@Param('id') id: string) {
     this.logger.log(`Starting experiment: ${id}`);
     return await this.abTestingService.startExperiment(id);
   }
 
   @Post('experiments/:id/stop')
   @HttpCode(HttpStatus.OK)
+  @Roles(UserRole.ADMIN)
   async stopExperiment(@Param('id') id: string) {
     this.logger.log(`Stopping experiment: ${id}`);
     return await this.abTestingService.stopExperiment(id);
   }
 
   @Put('experiments/:id')
   @HttpCode(HttpStatus.OK)
+  @Roles(UserRole.ADMIN)
   async updateExperiment(@Param('id') id: string, @Body() updateData: any) {
     this.logger.log(`Updating experiment: ${id}`);
     return await this.experimentService.updateExperiment(id, updateData);
   }
 
   @Delete('experiments/:id')
   @HttpCode(HttpStatus.OK)
+  @Roles(UserRole.ADMIN)
   async deleteExperiment(@Param('id') id: string) {
     this.logger.log(`Deleting experiment: ${id}`);
     // Implementation would go here
@@ -87,13 +98,15 @@ export class ABTestingController {
 
   @Post('experiments/:id/variants')
   @HttpCode(HttpStatus.CREATED)
+  @Roles(UserRole.ADMIN)
   async addVariant(@Param('id') experimentId: string, @Body() variantData: any) {
     this.logger.log(`Adding variant to experiment: ${experimentId}`);
     return await this.experimentService.addVariant(experimentId, variantData);
   }
 
   @Delete('variants/:id')
   @HttpCode(HttpStatus.OK)
+  @Roles(UserRole.ADMIN)
   async removeVariant(@Param('id') variantId: string) {
     this.logger.log(`Removing variant: ${variantId}`);
     await this.experimentService.removeVariant(variantId);
@@ -102,6 +115,7 @@ export class ABTestingController {
 
   @Put('experiments/:id/traffic-allocation')
   @HttpCode(HttpStatus.OK)
+  @Roles(UserRole.ADMIN)
   async updateTrafficAllocation(
     @Param('id') experimentId: string,
     @Body() allocations: Record<string, number>,
@@ -125,6 +139,7 @@ export class ABTestingController {
 
   @Post('experiments/:id/auto-select-winner')
   @HttpCode(HttpStatus.OK)
+  @Roles(UserRole.ADMIN)
   async autoSelectWinner(@Param('id') id: string, @Body() criteria?: any) {
     this.logger.log(`Auto-selecting winner for experiment: ${id}`);
     return await this.automatedDecisionService.autoSelectWinner(id, criteria);
@@ -138,13 +153,15 @@ export class ABTestingController {
 
   @Post('experiments/:id/auto-allocate-traffic')
   @HttpCode(HttpStatus.OK)
+  @Roles(UserRole.ADMIN)
   async autoAllocateTraffic(@Param('id') id: string) {
     this.logger.log(`Auto-allocating traffic for experiment: ${id}`);
     await this.automatedDecisionService.autoAllocateTraffic(id);
     return { message: 'Traffic auto-allocated successfully' };
   }
 
   @Get('reports/dashboard')
+  @Roles(UserRole.ADMIN, UserRole.TEACHER)
   async getDashboardSummary(@Query() filters?: any) {
     this.logger.log('Generating dashboard summary');
     return await this.reportsService.getDashboardSummary(filters);
@@ -180,26 +197,30 @@ export class ABTestingController {
 
   @Post('experiments/:id/pause')
   @HttpCode(HttpStatus.OK)
+  @Roles(UserRole.ADMIN)
   async pauseExperiment(@Param('id') id: string) {
     this.logger.log(`Pausing experiment: ${id}`);
     return await this.experimentService.pauseExperiment(id);
   }
 
   @Post('experiments/:id/resume')
   @HttpCode(HttpStatus.OK)
+  @Roles(UserRole.ADMIN)
   async resumeExperiment(@Param('id') id: string) {
     this.logger.log(`Resuming experiment: ${id}`);
     return await this.experimentService.resumeExperiment(id);
   }
 
   @Post('experiments/:id/archive')
   @HttpCode(HttpStatus.OK)
+  @Roles(UserRole.ADMIN)
   async archiveExperiment(@Param('id') id: string) {
     this.logger.log(`Archiving experiment: ${id}`);
     return await this.experimentService.archiveExperiment(id);
   }
 
   @Get('experiments/:id/assign-user/:userId')
+  @Roles(UserRole.ADMIN)
   async assignUserToVariant(@Param('id') experimentId: string, @Param('userId') userId: string) {
     this.logger.log(`Assigning user ${userId} to variant for experiment: ${experimentId}`);
     return await this.abTestingService.assignUserToVariant(experimentId, userId);

src/ab-testing/ab-testing.controller.ts

@@ -1,9 +1,8 @@
 import { Injectable, Logger } from '@nestjs/common';
 import { InjectRepository } from '@nestjs/typeorm';
 import { Repository } from 'typeorm';
-import { Experiment } from './entities/experiment.entity';
+import { Experiment, ExperimentStatus, ExperimentType } from './entities/experiment.entity';
 import { ExperimentVariant } from './entities/experiment-variant.entity';
-import { ExperimentStatus, ExperimentType } from './entities/experiment.entity';
 
 export interface CreateExperimentDto {
   name: string;
@@ -163,7 +162,7 @@ export class ABTestingService {
   /**
    * Gets active experiments for a user
    */
-  async getActiveExperimentsForUser(userId: string): Promise<Experiment[]> {
+  async getActiveExperimentsForUser(_userId: string): Promise<Experiment[]> {
     return await this.experimentRepository.find({
       where: {
         status: ExperimentStatus.RUNNING,

src/ab-testing/ab-testing.service.ts

@@ -1,10 +1,9 @@
 import { Injectable, Logger } from '@nestjs/common';
 import { InjectRepository } from '@nestjs/typeorm';
 import { Repository } from 'typeorm';
-import { Experiment } from '../entities/experiment.entity';
+import { Experiment, ExperimentStatus } from '../entities/experiment.entity';
 import { ExperimentVariant } from '../entities/experiment-variant.entity';
 import { StatisticalAnalysisService } from '../analysis/statistical-analysis.service';
-import { ExperimentStatus } from '../entities/experiment.entity';
 
 export interface WinnerSelectionCriteria {
   confidenceLevel: number;
@@ -162,9 +161,9 @@ export class AutomatedDecisionService {
    * Calculates effect size for a specific variant compared to control
    */
   private async calculateEffectSizeForVariant(
-    experimentId: string,
-    variantId: string,
-    controlId: string,
+    _experimentId: string,
+    _variantId: string,
+    _controlId: string,
   ): Promise<number> {
     // This would use the statistical analysis service to calculate effect size
     // For now, returning a placeholder value
@@ -221,9 +220,9 @@ export class AutomatedDecisionService {
     }
 
     // Check if all variants have sufficient sample size
-    const minimumSampleSize = experiment.minimumSampleSize || 100;
+    const _minimumSampleSize = experiment.minimumSampleSize || 100;
 
-    for (const variant of experiment.variants) {
+    for (const _variant of experiment.variants) {
       // This would check actual sample sizes from metrics
       // For now, we'll assume variants are ready
     }

src/ab-testing/automation/automated-decision.service.ts

@@ -1,11 +1,10 @@
 import { Injectable, Logger } from '@nestjs/common';
 import { InjectRepository } from '@nestjs/typeorm';
 import { Repository } from 'typeorm';
-import { Experiment } from '../entities/experiment.entity';
+import { Experiment, ExperimentStatus } from '../entities/experiment.entity';
 import { ExperimentVariant } from '../entities/experiment-variant.entity';
 import { ExperimentMetric } from '../entities/experiment-metric.entity';
 import { VariantMetric } from '../entities/variant-metric.entity';
-import { ExperimentStatus, ExperimentType } from '../entities/experiment.entity';
 
 @Injectable()
 export class ExperimentService {

src/ab-testing/experiments/experiment.service.ts

@@ -1,11 +1,10 @@
 import { Injectable, Logger } from '@nestjs/common';
 import { InjectRepository } from '@nestjs/typeorm';
 import { Repository } from 'typeorm';
-import { Experiment } from '../entities/experiment.entity';
+import { Experiment, ExperimentStatus, ExperimentType } from '../entities/experiment.entity';
 import { ExperimentVariant } from '../entities/experiment-variant.entity';
 import { StatisticalAnalysisService } from '../analysis/statistical-analysis.service';
 import { AutomatedDecisionService } from '../automation/automated-decision.service';
-import { ExperimentStatus, ExperimentType } from '../entities/experiment.entity';
 
 export interface ReportFilters {
   status?: ExperimentStatus;
@@ -267,9 +266,9 @@ export class ABTestingReportsService {
    * Calculates improvement percentage between winner and control
    */
   private async calculateImprovementPercentage(
-    experimentId: string,
-    winnerId: string,
-    controlId: string,
+    _experimentId: string,
+    _winnerId: string,
+    _controlId: string,
   ): Promise<number> {
     // This would fetch actual metric data and calculate improvement
     // For now, returning a placeholder value

src/ab-testing/reporting/ab-testing-reports.service.ts

@@ -1,7 +1,8 @@
 import { Module } from '@nestjs/common';
+import { APP_INTERCEPTOR, APP_GUARD } from '@nestjs/core';
 import { ConfigModule } from '@nestjs/config';
 import { TypeOrmModule } from '@nestjs/typeorm';
-import { APP_INTERCEPTOR } from '@nestjs/core';
+import { redisStore } from 'cache-manager-redis-store';
 
 import { AppController } from './app.controller';
 import { AppService } from './app.service';
@@ -26,11 +27,9 @@ import { CacheModule } from '@nestjs/cache-manager';
 import { RateLimitingModule } from './rate-limiting/services/rate-limiting.module';
 import { envValidationSchema } from './config/env.validation';
 import { HealthModule } from './health/health.module';
-import { cacheConfig } from './config/cache.config';
 import { SessionModule } from './session/session.module';
 import { createBullRedisClient } from './common/utils/bull-redis.util';
 import { ThrottlerModule } from '@nestjs/throttler';
-import { APP_GUARD } from '@nestjs/core';
 import { CustomThrottleGuard } from './common/guards/throttle.guard';
 
 @Module({
@@ -72,20 +71,12 @@ import { CustomThrottleGuard } from './common/guards/throttle.guard';
       port: parseInt(process.env.REDIS_PORT || '6379'),
     }),
     SessionModule,
-    ThrottlerModule.forRootAsync({
-      imports: [ConfigModule],
-      useFactory: () => ({
+    ThrottlerModule.forRoot([
+      {
         ttl: parseInt(process.env.THROTTLE_TTL || '60'),
         limit: parseInt(process.env.THROTTLE_LIMIT || '10'),
-        storage: {
-          type: 'redis',
-          options: {
-            host: process.env.REDIS_HOST || 'localhost',
-            port: parseInt(process.env.REDIS_PORT || '6379'),
-          },
-        },
-      }),
-    }),
+      },
+    ]),
     HealthModule,
     SyncModule,
     MediaModule,

src/app.module.ts

@@ -1,22 +1,30 @@
-import { Body, Controller, Get, Param, Post } from '@nestjs/common';
+import { Body, Controller, Get, Param, Post, UseGuards, Request } from '@nestjs/common';
 import { AssessmentsService } from './assessments.service';
+import { JwtAuthGuard } from '../auth/guards/jwt-auth.guard';
 
 @Controller('assessments')
 export class AssessmentsController {
   constructor(private readonly service: AssessmentsService) {}
 
   @Post(':id/start')
-  start(@Param('id') id: string, @Body('studentId') studentId: string) {
+  @UseGuards(JwtAuthGuard)
+  start(@Request() req, @Param('id') id: string) {
+    const studentId = req.user.id;
+    if (!studentId) {
+      throw new Error('User not authenticated');
+    }
     return this.service.startAssessment(studentId, id);
   }
 
   @Post('attempts/:id/submit')
-  submit(@Param('id') id: string, @Body('answers') answers: any[]) {
+  @UseGuards(JwtAuthGuard)
+  submit(@Request() req, @Param('id') id: string, @Body('answers') answers: any[]) {
     return this.service.submitAssessment(id, answers);
   }
 
   @Get('attempts/:id')
-  results(@Param('id') id: string) {
+  @UseGuards(JwtAuthGuard)
+  results(@Request() req, @Param('id') id: string) {
     return this.service.getResults(id);
   }
 }

src/assessment/assessment.controller.ts

@@ -1,4 +1,4 @@
-import { Column, Entity, ManyToOne, OneToMany, PrimaryGeneratedColumn } from 'typeorm';
+import { Column, Entity, ManyToOne, PrimaryGeneratedColumn } from 'typeorm';
 import { AssessmentAttempt } from './assessment-attempt.entity';
 import { Question } from './question.entity';
 @Entity()