Skip to content

Commit a2cf6d2

Browse files
mvadarimvadari
committed
update new tests
1 parent 904fb14 commit a2cf6d2

File tree

8 files changed

+62
-57
lines changed

8 files changed

+62
-57
lines changed

‎src/containers/shared/components/Transaction/OracleDelete/Simple.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ export const Simple: TransactionSimpleComponent = ({
88
const { t } = useTranslation()
99
const { OracleDocumentID } = data.instructions
1010
return (
11-
<SimpleRow label={t('oracle_document_id')} data-test="oracle-document-id">
11+
<SimpleRow label={t('oracle_document_id')} data-testid="oracle-document-id">
1212
{OracleDocumentID}
1313
</SimpleRow>
1414
)

‎src/containers/shared/components/Transaction/OracleDelete/TableDetail.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ export const TableDetail = ({
77
}: TransactionTableDetailProps<OracleDelete>) => {
88
const { t } = useTranslation()
99
return (
10-
<div className="oracle-document-id">
10+
<div className="oracle-document-id" data-testid="oracle-document-id">
1111
<span className="label">{t('oracle_document_id')}: </span>
1212
<span className="case-sensitive">{tx.OracleDocumentID}</span>
1313
</div>

‎src/containers/shared/components/Transaction/OracleDelete/test/OracleDeleteSimple.test.tsx‎

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,13 @@
1-
import { createSimpleWrapperFactory, expectSimpleRowText } from '../../test'
1+
import { screen, cleanup } from '@testing-library/react'
2+
import { createSimpleRenderFactory, expectSimpleRowText } from '../../test'
23
import { Simple } from '../Simple'
34
import OracleDelete from './mock_data/OracleDelete.json'
45

5-
const createWrapper = createSimpleWrapperFactory(Simple)
6+
const renderComponent = createSimpleRenderFactory(Simple)
67
describe('OracleDelete: Simple', () => {
8+
afterEach(cleanup)
79
it('renders', () => {
8-
const wrapper = createWrapper(OracleDelete)
9-
expectSimpleRowText(wrapper, 'oracle-document-id', '1')
10-
wrapper.unmount()
10+
renderComponent(OracleDelete)
11+
expectSimpleRowText(screen, 'oracle-document-id', '1')
1112
})
1213
})

‎src/containers/shared/components/Transaction/OracleDelete/test/OracleDeleteTableDetail.test.tsx‎

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,16 @@
1-
import { createTableDetailWrapperFactory } from '../../test'
1+
import { screen, cleanup } from '@testing-library/react'
2+
import { createTableDetailRenderFactory } from '../../test'
23
import { TableDetail } from '../TableDetail'
34
import OracleDelete from './mock_data/OracleDelete.json'
45

5-
const createWrapper = createTableDetailWrapperFactory(TableDetail)
6+
const renderComponent = createTableDetailRenderFactory(TableDetail)
67

78
describe('OracleDelete: TableDetail', () => {
9+
afterEach(cleanup)
810
it('renders', () => {
9-
const wrapper = createWrapper(OracleDelete)
10-
expect(wrapper).toHaveText('oracle_document_id: 1')
11-
wrapper.unmount()
11+
renderComponent(OracleDelete)
12+
expect(screen.getByTestId('oracle-document-id')).toHaveTextContent(
13+
`oracle_document_id: 1`,
14+
)
1215
})
1316
})

‎src/containers/shared/components/Transaction/OracleSet/Simple.tsx‎

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -22,23 +22,26 @@ export const Simple: TransactionSimpleComponent = ({
2222
} = data.instructions
2323
return (
2424
<>
25-
<SimpleRow label={t('oracle_document_id')} data-test="oracle-document-id">
25+
<SimpleRow
26+
label={t('oracle_document_id')}
27+
data-testid="oracle-document-id"
28+
>
2629
{oracleDocumentID}
2730
</SimpleRow>
2831

2932
{provider && (
30-
<SimpleRow label={t('provider')} data-test="provider">
33+
<SimpleRow label={t('provider')} data-testid="provider">
3134
{provider}
3235
</SimpleRow>
3336
)}
3437

3538
{uri && (
36-
<SimpleRow label={t('uri')} data-test="uri">
39+
<SimpleRow label={t('uri')} data-testid="uri">
3740
{uri}
3841
</SimpleRow>
3942
)}
4043

41-
<SimpleRow label={t('last_update_time')} data-test="last-update-time">
44+
<SimpleRow label={t('last_update_time')} data-testid="last-update-time">
4245
{localizeDate(
4346
new Date(lastUpdateTime * MILLIS_PER_SECOND),
4447
language,
@@ -47,14 +50,14 @@ export const Simple: TransactionSimpleComponent = ({
4750
</SimpleRow>
4851

4952
{assetClass && (
50-
<SimpleRow label={t('asset_class')} data-test="asset-class">
53+
<SimpleRow label={t('asset_class')} data-testid="asset-class">
5154
{assetClass}
5255
</SimpleRow>
5356
)}
5457

55-
<SimpleRow label={t('trading_pairs')} data-test="trading-pairs">
58+
<SimpleRow label={t('trading_pairs')} data-testid="trading-pairs">
5659
{priceDataSeries.map((priceDataObj) => (
57-
<div className="amount list" data-test="amount">
60+
<div className="amount list" data-testid="amount">
5861
{priceDataObj.assetPrice ?? t('deleted')}
5962
<div className="one-line">
6063
<Currency currency={priceDataObj.baseAsset} />/

‎src/containers/shared/components/Transaction/OracleSet/TableDetail.tsx‎

Lines changed: 20 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -12,35 +12,31 @@ export const TableDetail = ({
1212
const { t } = useTranslation()
1313
const language = useLanguage()
1414
return (
15-
<>
15+
<div data-testid="table-detail">
1616
<div className="oracle-document-id">
1717
<span className="label">{t('oracle_document_id')}: </span>
1818
<span className="case-sensitive">{tx.oracleDocumentID}</span>
1919
</div>
20-
<>
21-
{tx.provider && (
22-
<>
23-
<span className="label">{t('provider')}: </span>
24-
<span className="case-sensitive">{tx.provider}</span>
25-
</>
26-
)}
27-
{tx.assetClass && (
28-
<>
29-
<span className="label">{t('asset_class')}: </span>
30-
<span className="case-sensitive">{tx.assetClass}</span>
31-
</>
32-
)}
20+
{tx.provider && (
21+
<>
22+
<span className="label">{t('provider')}: </span>
23+
<span className="case-sensitive">{tx.provider}</span>
24+
</>
25+
)}
26+
{tx.assetClass && (
3327
<>
34-
<span className="label">{t('last_update_time')}: </span>
35-
<span className="case-sensitive">
36-
{localizeDate(
37-
new Date(tx.lastUpdateTime * MILLIS_PER_SECOND),
38-
language,
39-
DATE_OPTIONS,
40-
)}
41-
</span>
28+
<span className="label">{t('asset_class')}: </span>
29+
<span className="case-sensitive">{tx.assetClass}</span>
4230
</>
43-
</>
31+
)}
32+
<span className="label">{t('last_update_time')}: </span>
33+
<span className="case-sensitive">
34+
{localizeDate(
35+
new Date(tx.lastUpdateTime * MILLIS_PER_SECOND),
36+
language,
37+
DATE_OPTIONS,
38+
)}
39+
</span>
4440
<div className="trading-pair">
4541
<span className="label">{t('trading_pairs')}: </span>
4642
{tx.priceDataSeries.map((priceDataObj, index) => (
@@ -58,6 +54,6 @@ export const TableDetail = ({
5854
</>
5955
))}
6056
</div>
61-
</>
57+
</div>
6258
)
6359
}

‎src/containers/shared/components/Transaction/OracleSet/test/OracleSetSimple.test.tsx‎

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,25 @@
1-
import { createSimpleWrapperFactory, expectSimpleRowText } from '../../test'
1+
import { cleanup, screen } from '@testing-library/react'
2+
import { createSimpleRenderFactory, expectSimpleRowText } from '../../test'
23
import { Simple } from '../Simple'
34
import OracleSet from './mock_data/OracleSet.json'
45

5-
const createWrapper = createSimpleWrapperFactory(Simple)
6+
const renderComponent = createSimpleRenderFactory(Simple)
67
describe('OracleSet: Simple', () => {
8+
afterEach(cleanup)
79
it('renders', () => {
8-
const wrapper = createWrapper(OracleSet)
9-
expectSimpleRowText(wrapper, 'oracle-document-id', '1')
10-
expectSimpleRowText(wrapper, 'provider', 'provider')
10+
renderComponent(OracleSet)
11+
expectSimpleRowText(screen, 'oracle-document-id', '1')
12+
expectSimpleRowText(screen, 'provider', 'provider')
1113
expectSimpleRowText(
12-
wrapper,
14+
screen,
1315
'last-update-time',
1416
'May 13, 2024 at 9:05:10 PM',
1517
)
16-
expectSimpleRowText(wrapper, 'asset-class', 'currency')
18+
expectSimpleRowText(screen, 'asset-class', 'currency')
1719
expectSimpleRowText(
18-
wrapper,
20+
screen,
1921
'trading-pairs',
2022
'74.2\uE900 XRP/USD1.03BTC/AUDT',
2123
)
22-
wrapper.unmount()
2324
})
2425
})

‎src/containers/shared/components/Transaction/OracleSet/test/OracleSetTableDetail.test.tsx‎

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,20 @@
1-
import { createTableDetailWrapperFactory } from '../../test'
1+
import { cleanup, screen } from '@testing-library/react'
2+
import { createTableDetailRenderFactory } from '../../test'
23
import { TableDetail } from '../TableDetail'
34
import OracleSet from './mock_data/OracleSet.json'
45

5-
const createWrapper = createTableDetailWrapperFactory(TableDetail)
6+
const renderComponent = createTableDetailRenderFactory(TableDetail)
67

78
describe('OracleDelete: TableDetail', () => {
9+
afterEach(cleanup)
810
it('renders', () => {
9-
const wrapper = createWrapper(OracleSet)
10-
expect(wrapper).toHaveText(
11+
renderComponent(OracleSet)
12+
expect(screen.getByTestId('table-detail')).toHaveTextContent(
1113
'oracle_document_id: 1' +
1214
'provider: provider' +
1315
'asset_class: currency' +
1416
'last_update_time: May 13, 2024 at 9:05:10 PM' +
1517
'trading_pairs: 74.2\uE900 XRP/USD, 1.03BTC/AUDT',
1618
)
17-
wrapper.unmount()
1819
})
1920
})

0 commit comments

Comments
 (0)