refactor: convert new TS files to async/await (#1270)

## High Level Overview of Change

This PR is a fast follow from #1269 to refactor the files converted to
TS to use proper async/await structure instead of `then` structure.

There is no functionality change, only refactors.

### Context of Change

Best practices, easier to read/write

### Type of Change

- [x] Refactor (non-breaking change that only restructures code)

### Codebase Modernization

Already done ;)

## Before / After

No changes

## Test Plan

CI passes.

Author: mvadari

src/rippled/accountTransactions.ts

@@ -17,7 +17,7 @@ export interface AccountTransactionsResult {
   marker?: any
 }
 
-const getAccountTransactions = (
+const getAccountTransactions = async (
   account: string,
   currency: string | undefined,
   marker: any,
@@ -62,35 +62,39 @@ const getAccountTransactions = (
   }
 
   log.info(`get transactions: ${account} -> ${classicAddress}`)
-  return getAccountTxs(rippledSocket, classicAddress, limit, marker)
-    .then((data) => {
-      const transactions = data.transactions
-        .map((tx: any) => {
-          const txn = formatTransaction(tx)
-          return summarize(txn, true)
-        })
-        .filter((tx: any) => {
-          // No filter - return all transactions
-          if (!currency) {
-            return true
-          }
+  try {
+    const data = await getAccountTxs(
+      rippledSocket,
+      classicAddress,
+      limit,
+      marker,
+    )
+    const transactions = data.transactions
+      .map((tx: any) => {
+        const txn = formatTransaction(tx)
+        return summarize(txn, true)
+      })
+      .filter((tx: any) => {
+        // No filter - return all transactions
+        if (!currency) {
+          return true
+        }
 
-          // Filter by currency (IOU) or MPT issuance ID (passed as currency)
-          const txString = JSON.stringify(tx)
-          return (
-            txString.includes(`"currency":"${currency.toUpperCase()}"`) ||
-            txString.includes(`"${currency}"`)
-          )
-        })
-      return {
-        transactions,
-        marker: data.marker,
-      }
-    })
-    .catch((error: any) => {
-      log.error(error.toString())
-      throw error
-    })
+        // Filter by currency (IOU) or MPT issuance ID (passed as currency)
+        const txString = JSON.stringify(tx)
+        return (
+          txString.includes(`"currency":"${currency.toUpperCase()}"`) ||
+          txString.includes(`"${currency}"`)
+        )
+      })
+    return {
+      transactions,
+      marker: data.marker,
+    }
+  } catch (error: any) {
+    log.error(error.toString())
+    throw error
+  }
 }
 
 export default getAccountTransactions

src/rippled/index.ts

@@ -1,19 +1,9 @@
-import getAccountState from './accountState'
-import getAccountTransactions from './accountTransactions'
-import getLedger from './ledgers'
-import getTransaction from './transactions'
-import getQuorum from './quorum'
-import getNegativeUNL from './nUNL'
-import getOffers from './offers'
-
-export {
-  getAccountState,
-  getAccountTransactions,
-  getLedger,
-  getTransaction,
-  getQuorum,
-  getNegativeUNL,
-  getOffers,
-}
+export { default as getAccountState } from './accountState'
+export { default as getAccountTransactions } from './accountTransactions'
+export { default as getLedger } from './ledgers'
+export { default as getTransaction } from './transactions'
+export { default as getQuorum } from './quorum'
+export { default as getNegativeUNL } from './nUNL'
+export { default as getOffers } from './offers'
 
 export { getAccountInfo, getAMMInfoByAssets } from './lib/rippled'

src/rippled/ledgers.ts

@@ -5,10 +5,10 @@ import type { ExplorerXrplClient } from '../containers/shared/SocketContext'
 
 const log = logger({ name: 'ledgers' })
 
-const getLedger = (
+const getLedger = async (
   identifier: string | number,
   rippledSocket: ExplorerXrplClient,
-) => {
+): Promise<any> => {
   const parameters: any = {}
   if (!isNaN(Number(identifier))) {
     parameters.ledger_index = Number(identifier)
@@ -22,13 +22,13 @@ const getLedger = (
   }
 
   log.info(`get ledger: ${JSON.stringify(parameters)}`)
-  return getRippledLedger(rippledSocket, parameters)
-    .then((ledger) => summarizeLedger(ledger, true))
-    .then((data) => data)
-    .catch((error: any) => {
-      log.error(error.toString())
-      throw error
-    })
+  try {
+    const ledger = await getRippledLedger(rippledSocket, parameters)
+    return summarizeLedger(ledger, true)
+  } catch (error: any) {
+    log.error(error.toString())
+    throw error
+  }
 }
 
 export default getLedger