Skip to content

Commit ef4c025

Browse files
achowdhry-rippleachowdhry-ripple
committed
alias properties for clarity
1 parent f5ef32d commit ef4c025

File tree

11 files changed

+67
-43
lines changed

11 files changed

+67
-43
lines changed

‎src/containers/shared/components/Transaction/CredentialAccept/Simple.tsx‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,16 +9,16 @@ export const Simple: TransactionSimpleComponent = (
99
) => {
1010
const { t } = useTranslation()
1111
const { data } = props
12-
const { Issuer, CredentialType } = data.instructions
12+
const { Issuer: issuer, CredentialType: credentialType } = data.instructions
1313

1414
return (
1515
<>
1616
<SimpleRow label={t('issuer')} data-test="issuer">
17-
{Issuer}
17+
{issuer}
1818
</SimpleRow>
1919

2020
<SimpleRow label={t('credential_type')} data-test="credential-type">
21-
{convertHexToString(CredentialType)}
21+
{convertHexToString(credentialType)}
2222
</SimpleRow>
2323
</>
2424
)

‎src/containers/shared/components/Transaction/CredentialAccept/TableDetail.tsx‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,18 +7,18 @@ export const TableDetail = ({
77
instructions,
88
}: TransactionTableDetailProps<CredentialAccept>) => {
99
const { t } = useTranslation()
10-
const { Issuer, CredentialType } = instructions
10+
const { Issuer: issuer, CredentialType: credentialType } = instructions
1111
return (
1212
<div className="credentialAccept">
1313
<div className="issuer">
1414
<span className="label">{t('issuer')}: </span>
15-
<span className="case-sensitive">{Issuer}</span>
15+
<span className="case-sensitive">{issuer}</span>
1616
</div>
1717

1818
<div className="credential-type">
1919
<span className="label">{t('credential_type')}: </span>
2020
<span className="case-sensitive">
21-
{convertHexToString(CredentialType)}
21+
{convertHexToString(credentialType)}
2222
</span>
2323
</div>
2424
</div>

‎src/containers/shared/components/Transaction/CredentialCreate/Simple.tsx‎

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,26 +9,31 @@ const Simple: TransactionSimpleComponent = (
99
) => {
1010
const { t } = useTranslation()
1111
const { data } = props
12-
const { Subject, CredentialType, Expiration, URI } = data.instructions
12+
const {
13+
Subject: subject,
14+
CredentialType: credentialType,
15+
Expiration: expiration,
16+
URI: uri,
17+
} = data.instructions
1318

1419
return (
1520
<>
1621
<SimpleRow label={t('subject')} data-test="subject">
17-
{Subject}
22+
{subject}
1823
</SimpleRow>
1924

2025
<SimpleRow label={t('credential_type')} data-test="credential-type">
21-
{convertHexToString(CredentialType)}
26+
{convertHexToString(credentialType)}
2227
</SimpleRow>
2328

24-
{Expiration && (
29+
{expiration && (
2530
<SimpleRow label={t('expiration')} data-test="expiration">
26-
{Expiration}
31+
{expiration}
2732
</SimpleRow>
2833
)}
29-
{URI && (
34+
{uri && (
3035
<SimpleRow label={t('uri')} data-test="uri">
31-
{convertHexToString(URI)}
36+
{convertHexToString(uri)}
3237
</SimpleRow>
3338
)}
3439
</>

‎src/containers/shared/components/Transaction/CredentialCreate/TableDetail.tsx‎

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,31 +7,36 @@ export const TableDetail = ({
77
instructions,
88
}: TransactionTableDetailProps<CredentialCreate>) => {
99
const { t } = useTranslation()
10-
const { Subject, CredentialType, Expiration, URI } = instructions
10+
const {
11+
Subject: subject,
12+
CredentialType: credentialType,
13+
Expiration: expiration,
14+
URI: uri,
15+
} = instructions
1116
return (
1217
<div className="credentialCreate">
1318
<div className="issuer">
1419
<span className="label">{t('subject')}: </span>
15-
<span className="case-sensitive">{Subject}</span>
20+
<span className="case-sensitive">{subject}</span>
1621
</div>
1722

1823
<div className="credential-type">
1924
<span className="label">{t('credential_type')}: </span>
2025
<span className="case-sensitive">
21-
{convertHexToString(CredentialType)}
26+
{convertHexToString(credentialType)}
2227
</span>
2328
</div>
2429

25-
{Expiration && (
30+
{expiration && (
2631
<div className="expiration">
2732
<span className="label">{t('expiration')}: </span>
28-
<span className="case-sensitive">{Expiration}</span>
33+
<span className="case-sensitive">{expiration}</span>
2934
</div>
3035
)}
31-
{URI && (
36+
{uri && (
3237
<div className="uri">
3338
<span className="label">{t('uri')}: </span>
34-
<span className="case-sensitive">{convertHexToString(URI)}</span>
39+
<span className="case-sensitive">{convertHexToString(uri)}</span>
3540
</div>
3641
)}
3742
</div>

‎src/containers/shared/components/Transaction/CredentialDelete/Simple.tsx‎

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,22 +9,27 @@ const Simple: TransactionSimpleComponent = (
99
) => {
1010
const { t } = useTranslation()
1111
const { data } = props
12-
const { Account, Subject, CredentialType, Issuer } = data.instructions
12+
const {
13+
Account: account,
14+
Subject: subject,
15+
CredentialType: credentialType,
16+
Issuer: issuer,
17+
} = data.instructions
1318

1419
return (
1520
<>
1621
<SimpleRow label={t('subject')} data-test="subject">
17-
{Subject || Account}
22+
{subject || account}
1823
</SimpleRow>
1924

20-
{Issuer && (
25+
{issuer && (
2126
<SimpleRow label={t('issuer')} data-test="issuer">
22-
{Issuer || Account}
27+
{issuer || account}
2328
</SimpleRow>
2429
)}
2530

2631
<SimpleRow label={t('credential_type')} data-test="credential-type">
27-
{convertHexToString(CredentialType)}
32+
{convertHexToString(credentialType)}
2833
</SimpleRow>
2934
</>
3035
)

‎src/containers/shared/components/Transaction/CredentialDelete/TableDetail.tsx‎

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,23 +7,28 @@ export const TableDetail = ({
77
instructions,
88
}: TransactionTableDetailProps<CredentialDelete>) => {
99
const { t } = useTranslation()
10-
const { Account, Subject, Issuer, CredentialType } = instructions
10+
const {
11+
Account: account,
12+
Subject: subject,
13+
Issuer: issuer,
14+
CredentialType: credentialType,
15+
} = instructions
1116
return (
1217
<div className="credentialDelete">
1318
<div className="subject">
1419
<span className="label">{t('subject')}: </span>
15-
<span className="case-sensitive">{Subject || Account}</span>
20+
<span className="case-sensitive">{subject || account}</span>
1621
</div>
1722

1823
<div className="issuer">
1924
<span className="label">{t('issuer')}: </span>
20-
<span className="case-sensitive">{Issuer || Account}</span>
25+
<span className="case-sensitive">{issuer || account}</span>
2126
</div>
2227

2328
<div className="credential-type">
2429
<span className="label">{t('credential_type')}: </span>
2530
<span className="case-sensitive">
26-
{convertHexToString(CredentialType)}
31+
{convertHexToString(credentialType)}
2732
</span>
2833
</div>
2934
</div>

‎src/containers/shared/components/Transaction/PermissionedDomainDelete/Simple.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,11 @@ const Simple: TransactionSimpleComponent = (
88
) => {
99
const { t } = useTranslation()
1010
const { data } = props
11-
const { DomainID } = data.instructions
11+
const { DomainID: domainID } = data.instructions
1212

1313
return (
1414
<SimpleRow label={t('domain_id')} data-test="domain-id">
15-
{DomainID}
15+
{dataomainID}
1616
</SimpleRow>
1717
)
1818
}

‎src/containers/shared/components/Transaction/PermissionedDomainDelete/TableDetail.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,12 @@ export const TableDetail = ({
66
instructions,
77
}: TransactionTableDetailProps<PermissionedDomainDelete>) => {
88
const { t } = useTranslation()
9-
const { DomainID } = instructions
9+
const { DomainID: domainID } = instructions
1010
return (
1111
<div className="permissionedDomainDelete">
1212
<div className="domainId">
1313
<span className="label">{t('domain_id')}: </span>
14-
<span className="case-sensitive">{DomainID}</span>
14+
<span className="case-sensitive">{domainID}</span>
1515
</div>
1616
</div>
1717
)

‎src/containers/shared/components/Transaction/PermissionedDomainSet/Simple.tsx‎

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,21 +8,22 @@ const Simple: TransactionSimpleComponent = (
88
) => {
99
const { t } = useTranslation()
1010
const { data } = props
11-
const { DomainID, AcceptedCredentials } = data.instructions
11+
const { DomainID: domainID, AcceptedCredentials: acceptedCredentials } =
12+
data.instructions
1213

1314
return (
1415
<>
15-
{DomainID && (
16+
{domainID && (
1617
<SimpleRow label={t('domain_id')} data-test="domain-id">
17-
{DomainID}
18+
{domainID}
1819
</SimpleRow>
1920
)}
2021

2122
<SimpleRow
2223
label={t('accepted_credentials')}
2324
data-test="accepted-credentials"
2425
>
25-
{AcceptedCredentials.map((credential) => (
26+
{acceptedCredentials.map((credential) => (
2627
<div>{credential}</div>
2728
))}
2829
</SimpleRow>

‎src/containers/shared/components/Transaction/PermissionedDomainSet/TableDetail.tsx‎

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,17 +6,20 @@ export const TableDetail = ({
66
instructions,
77
}: TransactionTableDetailProps<PermissionedDomainSet>) => {
88
const { t } = useTranslation()
9-
const { DomainID, AcceptedCredentials } = instructions
9+
const { DomainID: domainID, AcceptedCredentials: acceptedCredentials } =
10+
instructions
1011
return (
1112
<div className="permissionedDomainSet">
12-
<div className="domainId">
13-
<span className="label">{t('domain_id')}: </span>
14-
<span className="case-sensitive">{DomainID}</span>
15-
</div>
13+
{domainID && (
14+
<div className="domainId">
15+
<span className="label">{t('domain_id')}: </span>
16+
<span className="case-sensitive">{domainID}</span>
17+
</div>
18+
)}
1619

1720
<div className="acceptedCredentials">
1821
<span className="label">{t('accepted_credentials')}: </span>
19-
<span className="case-sensitive">{AcceptedCredentials}</span>
22+
<span className="case-sensitive">{acceptedCredentials}</span>
2023
</div>
2124
</div>
2225
)

0 commit comments

Comments
 (0)