[FIX] fix parsing incoming trust lines

JsonRewriter: correctly parse limit, limit_peer and noRipple properties of
incoming trust line transaction
Trust Tab: correctly show "Rippling" field for incoming trust lines

Author: darkdarkdragon

src/js/entry/web.js

@@ -1,4 +1,5 @@
-var types = require('../util/types');
+var types = require('../util/types'),
+    rewriter = require('../util/jsonrewriter');
 
 // Load app modules
 require('../controllers/app');
@@ -137,6 +138,8 @@ var app = angular
 var rippleclient = window.rippleclient = {};
 rippleclient.app = app;
 rippleclient.types = types;
+// for unit tests
+rippleclient.rewriter = rewriter;
 
 // Install basic page template
 angular.element('body').prepend(require('../../jade/client/index.jade')());

src/js/tabs/trust.js

@@ -332,7 +332,10 @@ TrustTab.prototype.angular = function (module)
         }
 
         obj[line.currency].components.push(line);
-
+        // correctly show "Rippling" flag for incoming trust lines
+        if (_.has(line, 'no_ripple_peer')) {
+          line.no_ripple = line.no_ripple_peer;
+        }
       });
 
       $scope.accountLines = obj;

src/js/util/jsonrewriter.js

@@ -386,20 +386,17 @@ var JsonRewriter = module.exports = {
 
           var high = node.fields.HighLimit;
           var low = node.fields.LowLimit;
+          var viewHigh = high.issuer === account;
 
-          var which = high.issuer === account ? 'HighNoRipple' : 'LowNoRipple';
+          var which = obj.transaction.type == 'trusting' ? (high.issuer === account ? 'HighNoRipple' : 'LowNoRipple') :
+                                                           (high.issuer === account ? 'LowNoRipple' : 'HighNoRipple');
 
           // New trust line
           if (node.diffType === 'CreatedNode') {
-            effect.limit = ripple.Amount.from_json(high.value > 0 ? high : low);
-            effect.limit_peer = ripple.Amount.from_json(high.value > 0 ? low : high);
-
-            if ((high.value > 0 && high.issuer === account)
-                || (low.value > 0 && low.issuer === account)) {
-              effect.type = 'trust_create_local';
-            } else {
-              effect.type = 'trust_create_remote';
-            }
+            effect.limit = ripple.Amount.from_json(viewHigh ? high : low);
+            effect.limit_peer = ripple.Amount.from_json(viewHigh ? low : high);
+
+            effect.type = obj.transaction.type == 'trusting' ? 'trust_create_local' : 'trust_create_remote';
           }
 
           // Modified trust line