improve error handling

Author: shekenahglory

import/hbase/history.js

@@ -140,7 +140,6 @@ var HistoricalImport = function () {
 
       } else if (resp) {
         self.importer.backFill(resp.startIndex, resp.stopIndex, function(err) {
-          console.log(err);
           if (err) {
             if (cb) cb(err);
           }

import/postgres/history.js

@@ -75,7 +75,7 @@ var HistoricalImport = function () {
         if (err) {
           log.error('failed to get latest validated ledger');
           callback('failed to get latest validated ledger');
-          return;
+          process.exit(1);
         }
 
         var index = parseInt(ledger.ledger_index, 10) - 1;
@@ -128,7 +128,13 @@ var HistoricalImport = function () {
           resp.stopIndex = GENESIS_LEDGER;
         }
 
-        self.importer.backFill(resp.stopIndex, resp.startIndex);
+        self.importer.backFill(resp.stopIndex, resp.startIndex, function(err) {
+          if (err) {
+            log.error(err);
+            process.exit(1);
+          }
+        });
+
         self.count   = 0;
         self.total   = resp.startIndex - resp.stopIndex + 1;
         self.section = resp;

lib/ripple-importer.js

@@ -124,17 +124,17 @@ var Importer = function (options) {
     */
     function getLedger(index, count) {
       if (!count) count = 0;
-
+      var max = 5;
       setTimeout(function() {
         self.getLedger({index:index || 'validated'}, function (err, ledger) {
           if (ledger) handleLedger(ledger);
           else {
             log.error(err);
-            if (count++<30) {
+            if (count ++< max) {
               log.error('backfiller failed to get ledger, retrying: ' + count);
               getLedger(index, count);
             } else {
-              log.error('backfiller failed to get ledger, stopping after 30 attempts');
+              log.error('backfiller failed to get ledger, stopping after ' + max + ' attempts');
               if (typeof callback === 'function') {
                 callback('import failure');
               }
@@ -427,8 +427,7 @@ var Importer = function (options) {
         }
 
         if (!valid) {
-          log.error('unable to validate ledger:', resp.ledger.ledger_index);
-          retry(Number(resp.ledger.ledger_index), attempts, callback);
+          callback('unable to validate ledger: ' + resp.ledger.ledger_index);
           return;
         }