feat: Use network_id in the Validation subscripton stream
#1160
ckeshavaAnnotations
21 errors and 20 warnings
|
build (20.x):
src/connection-manager/agreement.ts#L314
Replace `'DEBUG:·Validations·received·by·the·Ripple·validator:·',·Array.from(validations.keys())` with `⏎········'DEBUG:·Validations·received·by·the·Ripple·validator:·',⏎········Array.from(validations.keys()),⏎······`
|
|
build (20.x):
src/connection-manager/agreement.ts#L313
Replace `'DEBUG:·Number·of·Validations·received·from·the·Ripple·validator:·',·validations.size` with `⏎········'DEBUG:·Number·of·Validations·received·from·the·Ripple·validator:·',⏎········validations.size,⏎······`
|
|
build (20.x):
src/connection-manager/agreement.ts#L312
Replace `'DEBUG:·XRPL·Mainnet·received·the·following·ledgers:·',·Array.from(ledgerHashIndexMap)` with `⏎········'DEBUG:·XRPL·Mainnet·received·the·following·ledgers:·',⏎········Array.from(ledgerHashIndexMap),⏎······`
|
|
build (20.x):
src/connection-manager/agreement.ts#L311
Expected '===' and instead saw '=='
|
|
build (20.x):
src/connection-manager/agreement.ts#L311
Expected '===' and instead saw '=='
|
|
build (20.x):
src/connection-manager/agreement.ts#L311
Replace `validator_keys.master_key·==·'nHU4bLE3EmSqNwfL4AP1UZeTNPrSPPP6FXLKXo2uqfHuvBQxDVKd'·||·validator_keys.signing_key·==·'n9LbM9S5jeGopF5J1vBDoGxzV6rNS8K1T5DzhNynkFLqR9N2fywX'` with `⏎······validator_keys.master_key·==⏎········'nHU4bLE3EmSqNwfL4AP1UZeTNPrSPPP6FXLKXo2uqfHuvBQxDVKd'·||⏎······validator_keys.signing_key·==⏎········'n9LbM9S5jeGopF5J1vBDoGxzV6rNS8K1T5DzhNynkFLqR9N2fywX'⏎····`
|
|
|
|
build (20.x):
src/connection-manager/agreement.ts#L304
'ledgers' is never reassigned. Use 'const' instead
|
|
build (20.x):
src/connection-manager/agreement.ts#L293
Expected @param names to be "validator_keys, validations, ledgerHashIndexMap, incomplete". Got "validator_keys, validations, ledgers, incomplete"
|
|
build (20.x):
src/connection-manager/agreement.ts#L288
Missing JSDoc @param "ledgerHashIndexMap" declaration
|
|
build (22.x)
The strategy configuration was canceled because "build._20_x" failed
|
|
build (22.x):
src/connection-manager/agreement.ts#L314
Replace `'DEBUG:·Validations·received·by·the·Ripple·validator:·',·Array.from(validations.keys())` with `⏎········'DEBUG:·Validations·received·by·the·Ripple·validator:·',⏎········Array.from(validations.keys()),⏎······`
|
|
build (22.x):
src/connection-manager/agreement.ts#L313
Replace `'DEBUG:·Number·of·Validations·received·from·the·Ripple·validator:·',·validations.size` with `⏎········'DEBUG:·Number·of·Validations·received·from·the·Ripple·validator:·',⏎········validations.size,⏎······`
|
|
build (22.x):
src/connection-manager/agreement.ts#L312
Replace `'DEBUG:·XRPL·Mainnet·received·the·following·ledgers:·',·Array.from(ledgerHashIndexMap)` with `⏎········'DEBUG:·XRPL·Mainnet·received·the·following·ledgers:·',⏎········Array.from(ledgerHashIndexMap),⏎······`
|
|
build (22.x):
src/connection-manager/agreement.ts#L311
Expected '===' and instead saw '=='
|
|
build (22.x):
src/connection-manager/agreement.ts#L311
Expected '===' and instead saw '=='
|
|
build (22.x):
src/connection-manager/agreement.ts#L311
Replace `validator_keys.master_key·==·'nHU4bLE3EmSqNwfL4AP1UZeTNPrSPPP6FXLKXo2uqfHuvBQxDVKd'·||·validator_keys.signing_key·==·'n9LbM9S5jeGopF5J1vBDoGxzV6rNS8K1T5DzhNynkFLqR9N2fywX'` with `⏎······validator_keys.master_key·==⏎········'nHU4bLE3EmSqNwfL4AP1UZeTNPrSPPP6FXLKXo2uqfHuvBQxDVKd'·||⏎······validator_keys.signing_key·==⏎········'n9LbM9S5jeGopF5J1vBDoGxzV6rNS8K1T5DzhNynkFLqR9N2fywX'⏎····`
|
|
|
|
build (22.x):
src/connection-manager/agreement.ts#L304
'ledgers' is never reassigned. Use 'const' instead
|
|
build (22.x):
src/connection-manager/agreement.ts#L293
Expected @param names to be "validator_keys, validations, ledgerHashIndexMap, incomplete". Got "validator_keys, validations, ledgers, incomplete"
|
|
build (22.x):
src/connection-manager/agreement.ts#L288
Missing JSDoc @param "ledgerHashIndexMap" declaration
|
|
build (20.x):
src/connection-manager/chains.ts#L203
This line has a length of 87. Maximum allowed is 80
|
|
build (20.x):
src/connection-manager/chains.ts#L201
This line has a length of 111. Maximum allowed is 80
|
|
build (20.x):
src/connection-manager/chains.ts#L199
Member updateChains should be declared before all private instance method definitions
|
|
build (20.x):
src/connection-manager/chains.ts#L178
This line has a length of 122. Maximum allowed is 80
|
|
build (20.x):
src/connection-manager/chains.ts#L140
Blocks are nested too deeply (4). Maximum allowed is 2
|
|
build (20.x):
src/connection-manager/chains.ts#L134
Blocks are nested too deeply (4). Maximum allowed is 2
|
|
build (20.x):
src/connection-manager/chains.ts#L131
Blocks are nested too deeply (3). Maximum allowed is 2
|
|
build (20.x):
src/connection-manager/chains.ts#L104
Method 'calculateChainsFromLedgers' has a complexity of 12. Maximum allowed is 10
|
|
build (20.x):
src/connection-manager/chains.ts#L104
Method 'calculateChainsFromLedgers' has too many statements (22). Maximum allowed is 20
|
|
build (20.x):
src/connection-manager/chains.ts#L19
This line has a length of 110. Maximum allowed is 80
|
|
build (22.x):
src/connection-manager/chains.ts#L203
This line has a length of 87. Maximum allowed is 80
|
|
build (22.x):
src/connection-manager/chains.ts#L201
This line has a length of 111. Maximum allowed is 80
|
|
build (22.x):
src/connection-manager/chains.ts#L199
Member updateChains should be declared before all private instance method definitions
|
|
build (22.x):
src/connection-manager/chains.ts#L178
This line has a length of 122. Maximum allowed is 80
|
|
build (22.x):
src/connection-manager/chains.ts#L140
Blocks are nested too deeply (4). Maximum allowed is 2
|
|
build (22.x):
src/connection-manager/chains.ts#L134
Blocks are nested too deeply (4). Maximum allowed is 2
|
|
build (22.x):
src/connection-manager/chains.ts#L131
Blocks are nested too deeply (3). Maximum allowed is 2
|
|
build (22.x):
src/connection-manager/chains.ts#L104
Method 'calculateChainsFromLedgers' has a complexity of 12. Maximum allowed is 10
|
|
build (22.x):
src/connection-manager/chains.ts#L104
Method 'calculateChainsFromLedgers' has too many statements (22). Maximum allowed is 20
|
|
build (22.x):
src/connection-manager/chains.ts#L19
This line has a length of 110. Maximum allowed is 80
|