remove references to missing-ledgers table

Author: ckeshava

ARCHITECTURE.md

@@ -211,16 +211,5 @@ This table keeps track of all validated ledgers received from streaming subscrip
 | `txn_count`     | The number of transactions in this ledger.                              |
 | `received_at`   | The time when this ledgerClosed message was received by the VHS.                    |
 
-### `missing_ledgers`
-
-This table keeps track of missing validated ledgers detected across different networks.
-
-| Key                          | Definition                                                              |
-|------------------------------|-------------------------------------------------------------------------|
-| `network`                    | The network on which the ledger is missing.                             |
-| `ledger_index`               | The index of the missing ledger.                                        |
-| `previous_ledger_index`      | The index of the previous ledger that was received.                     |
-| `previous_ledger_received_at`| The time when the previous ledger was received by the VHS.              |
-
 *Partial validations are not meant to vote for any particular ledger. A partial validation indicates that the validator is still online but not keeping up with consensus.
 **A chain is a group of validators validating the same set of ledgers. `main`, `test`, and `dev` represent the validated versions of mainnet, testnet, and devnet respectively. Validators on a fork/validating an alternate version of the ledger will have a different value, usually of the form `chain.[num]`.

src/connection-manager/connections.ts

@@ -18,7 +18,6 @@ import { FeeVote, WsNode } from '../shared/types'
 import { getIPv4Address } from '../shared/utils'
 import logger from '../shared/utils/logger'
 
-import checkForMissingLedgers from './scanMissingLedgers'
 import {
   backtrackAmendmentStatus,
   fetchAmendmentsFromLedgerEntry,
@@ -236,7 +235,6 @@ export default async function startConnections(): Promise<void> {
     }, BACKTRACK_INTERVAL)
 
     setInterval(pruneValidatedLedgersTable, 1000 * 60 * 60 * 24)
-    setInterval(checkForMissingLedgers, 1000 * 60)
   }
 }
 

src/connection-manager/scanMissingLedgers.ts

@@ -27,7 +27,6 @@ export default async function setupTables(): Promise<void> {
   await addAmendmentsDataFromJSON()
   await setupConnectionHealthTable()
   await setupValidatedLedgersTable()
-  await setupMissingLedgersTable()
 }
 
 async function setupCrawlsTable(): Promise<void> {
@@ -300,16 +299,3 @@ export async function setupValidatedLedgersTable(): Promise<void> {
     })
   }
 }
-
-async function setupMissingLedgersTable(): Promise<void> {
-  const hasTable = await db().schema.hasTable('missing_ledgers')
-  if (!hasTable) {
-    await db().schema.createTable('missing_ledgers', (table) => {
-      table.string('network').notNullable()
-      table.bigInteger('ledger_index').notNullable()
-      table.bigInteger('previous_ledger_index').notNullable()
-      table.dateTime('previous_ledger_received_at').notNullable()
-      table.primary(['network', 'ledger_index'])
-    })
-  }
-}

src/shared/database/setup.ts

@@ -1,6 +1,6 @@
 import { rippleTimeToUnixTime } from 'xrpl'
 
-import { StreamLedger, MissingLedger } from '../types'
+import { StreamLedger } from '../types'
 import logger from '../utils/logger'
 
 import { query } from './utils'
@@ -88,56 +88,3 @@ export async function insertValidations(
     )
   }
 }
-
-/**
- * Retrieves the most recent validated ledgers for a network, up to a specified limit.
- *
- * @param network - The network identifier.
- * @param limit - Optional limit on the number of ledgers to return (default: 100).
- * @returns A promise resolving to an array of recent validated ledgers.
- */
-export async function getRecentValidatedLedgers(
-  network: string,
-  limit?: number,
-): Promise<StreamLedger[]> {
-  return query('validated_ledgers')
-    .where('network', network)
-    .orderBy('ledger_index', 'desc')
-    .select('*')
-    .limit(limit ?? 100)
-}
-
-/**
- * Inserts a missing ledger record into the database, ignoring if it already exists.
- *
- * @param missedLedger - The missing ledger data to insert.
- * @returns A promise that resolves when the insertion is complete.
- */
-export async function insertMissingLedger(
-  missedLedger: MissingLedger,
-): Promise<void> {
-  await query('missing_ledgers')
-    .insert({
-      network: missedLedger.network,
-      ledger_index: missedLedger.ledger_index,
-      previous_ledger_index: missedLedger.previous_ledger_index,
-      previous_ledger_received_at: missedLedger.previous_ledger_received_at,
-    })
-    .onConflict(['network', 'ledger_index'])
-    .ignore()
-}
-
-/**
- * Retrieves all missing ledgers for a network, ordered by ledger index descending.
- *
- * @param network - The network identifier.
- * @returns A promise resolving to an array of missing ledgers.
- */
-export async function getMissingLedgers(
-  network: string,
-): Promise<MissingLedger[]> {
-  return query('missing_ledgers')
-    .where('network', network)
-    .orderBy('ledger_index', 'desc')
-    .select('*')
-}

src/shared/database/validatedLedgers.ts

@@ -27,17 +27,9 @@ interface StreamLedger {
   reserve_inc: number
   txn_id: number
   type: string
-  // Note: The VHS code base needs to be updated to include this field in the LedgerStream response.
   validated_ledgers?: string
 }
 
-interface MissingLedger {
-  network: string
-  ledger_index: number
-  previous_ledger_index: number
-  previous_ledger_received_at: Date
-}
-
 interface AmendmentEnabled {
   amendment_id: string
   networks: string
@@ -279,5 +271,4 @@ export {
   AmendmentInfo,
   ConnectionHealth,
   WsNode,
-  MissingLedger,
 }