fix(data): many instruction assembly have unneeded space #1274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Converted to a draft. More changes coming. Many of the instruction definitions in |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1274 +/- ##
=======================================
Coverage 46.05% 46.05%
=======================================
Files 11 11
Lines 4942 4942
Branches 1345 1345
=======================================
Hits 2276 2276
Misses 2666 2666
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ThinkOpenly
force-pushed
the
c.ebreak-space
branch
from
d7430e1 to
36c07e2
Compare
ThinkOpenly
changed the title
Instructions with no operands just need an empty string for the "assembly" field, and all but one are implemented like that. Fix c.ebreak to be like all of the others. Signed-off-by: Paul A. Clarke <[email protected]>
The "assembly" attribute of instruction YAML are simply strings representing the syntactic list of operands, or an empty string if the instruction has no operands. Fix instructions that have extra, unneeded spaces. Signed-off-by: Paul A. Clarke <[email protected]>
ThinkOpenly
force-pushed
the
c.ebreak-space
branch
from
36c07e2 to
a42e648
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "assembly" attribute of instruction YAML are simply strings
representing the syntactic list of operands, or an empty string if the
instruction has no operands.
Fix instructions that have extra, unneeded spaces.