Skip to content

Commit beecda0

Browse files
atoulmerite7sh
authored andcommitted
[chore] update codeowners check (open-telemetry#46731)
Use main Makefile to check codeowners.
1 parent 4aff0ce commit beecda0

2 files changed

Lines changed: 7 additions & 7 deletions

File tree

.github/workflows/check-codeowners.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,7 @@ jobs:
5656

5757
- name: Gen CODEOWNERS
5858
run: |
59-
cd pr
60-
GITHUB_TOKEN=${{ steps.otelbot-token.outputs.token }} make codeowners
59+
GITHUB_TOKEN=${{ steps.otelbot-token.outputs.token }} GITHUBGEN_ARGS="-folder=./pr" make codeowners
6160
git diff -s --exit-code || (echo 'Generated code is out of date, please run "make gencodeowners" or apply this diff and commit the changes in this PR.' && git diff && exit 1)
6261
6362
- run: ./.github/workflows/scripts/check-disk-space.sh

Makefile

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -393,14 +393,15 @@ docker-golden:
393393
cd cmd/golden && docker build --platform linux/$(GOARCH) --build-arg="TARGETOS=$(GOOS)" --build-arg="TARGETARCH=$(GOARCH)" -t golden:latest .
394394
rm cmd/golden/golden_*
395395

396+
GITHUBGEN_ARGS ?= -skipgithub
396397

397398
.PHONY: gengithub
398399
gengithub:
399-
$(GITHUBGEN)
400+
$(GITHUBGEN) $(GITHUBGEN_ARGS)
400401

401402
.PHONY: gendistributions
402403
gendistributions:
403-
$(GITHUBGEN) distributions
404+
$(GITHUBGEN) $(GITHUBGEN_ARGS) distributions
404405

405406
.PHONY: gencodecov
406407
gencodecov:
@@ -412,15 +413,15 @@ update-codeowners: generate gengithub
412413

413414
.PHONY: gencodeowners
414415
gencodeowners:
415-
$(GITHUBGEN) -skipgithub
416+
$(GITHUBGEN) $(GITHUBGEN_ARGS)
416417

417418
.PHONY: codeowners
418419
codeowners:
419-
$(GITHUBGEN) codeowners
420+
$(GITHUBGEN) $(GITHUBGEN_ARGS) codeowners
420421

421422
.PHONY: generate-chloggen-components
422423
generate-chloggen-components:
423-
$(GITHUBGEN) chloggen-components
424+
$(GITHUBGEN) $(GITHUBGEN_ARGS) chloggen-components
424425

425426
FILENAME?=$(shell git branch --show-current)
426427
.PHONY: chlog-new

0 commit comments

Comments
 (0)