Merge pull request #121 from cobainayush-dotcom/main

Improving test coverage

Author: ritik4ever

.github/workflows/backend-tests.yml

@@ -1,28 +1,47 @@
-name: Backend Tests
-
-on:
-  pull_request:
-    paths:
-      - 'backend/**'
-
-      - '.github/workflows/backend-tests.yml'
-  push:
-    branches:
-      - main
-      - develop
-    paths:
-      - 'backend/**'
-
-      - name: Upload test results
-        if: always()
-        uses: actions/upload-artifact@v4
-        with:
-          name: test-results-${{ matrix.node-version }}
-          path: backend/coverage/
-          if-no-files-found: ignore
-
-      - name: Validate deployment compose config and build
-        if: matrix.node-version == '20.x'
-        run: |
-          docker compose -f deployment/docker-compose.yml config
-          docker compose -f deployment/docker-compose.yml build frontend backend
+name: Backend Tests
+
+on:
+  pull_request:
+    paths:
+      - 'backend/**'
+      - '.github/workflows/backend-tests.yml'
+  push:
+    branches:
+      - main
+      - develop
+    paths:
+      - 'backend/**'
+      - '.github/workflows/backend-tests.yml'
+
+jobs:
+  backend-tests:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        node-version: ['20.x']
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Setup Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: ${{ matrix.node-version }}
+          cache: npm
+          cache-dependency-path: backend/package-lock.json
+
+      - name: Install dependencies
+        working-directory: ./backend
+        run: npm ci
+
+      - name: Run backend tests with coverage
+        working-directory: ./backend
+        run: npm run test:coverage
+
+      - name: Upload backend coverage artifact
+        if: always()
+        uses: actions/upload-artifact@v4
+        with:
+          name: backend-coverage-${{ matrix.node-version }}
+          path: backend/coverage/
+          if-no-files-found: error

.github/workflows/e2e-tests.yml

@@ -57,7 +57,13 @@ jobs:
         npm run build
         npm start &
         echo "Backend started"
-        sleep 5
+        for i in {1..20}; do
+          if curl -sf http://localhost:3001/health > /dev/null; then
+            echo "Backend healthy"
+            break
+          fi
+          sleep 2
+        done
       working-directory: ./backend
 
     - name: Run Playwright tests
@@ -67,10 +73,18 @@ jobs:
       run: npx playwright test
       working-directory: ./frontend
 
-    - name: Upload artifact on failure
+    - name: Upload Playwright report
       uses: actions/upload-artifact@v4
       if: always()
       with:
         name: playwright-report
         path: frontend/playwright-report/
         retention-days: 30
+
+    - name: Upload Playwright test results
+      uses: actions/upload-artifact@v4
+      if: always()
+      with:
+        name: playwright-test-results
+        path: frontend/test-results/
+        retention-days: 30

.github/workflows/frontend-tests.yml

@@ -0,0 +1,44 @@
+name: Frontend Tests
+
+on:
+  pull_request:
+    paths:
+      - 'frontend/**'
+      - '.github/workflows/frontend-tests.yml'
+  push:
+    branches:
+      - main
+      - develop
+    paths:
+      - 'frontend/**'
+      - '.github/workflows/frontend-tests.yml'
+
+jobs:
+  frontend-tests:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Setup Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: 20
+          cache: npm
+          cache-dependency-path: frontend/package-lock.json
+
+      - name: Install dependencies
+        working-directory: ./frontend
+        run: npm ci
+
+      - name: Run frontend unit tests with coverage
+        working-directory: ./frontend
+        run: npm run test:coverage
+
+      - name: Upload frontend coverage artifact
+        if: always()
+        uses: actions/upload-artifact@v4
+        with:
+          name: frontend-coverage
+          path: frontend/coverage/
+          if-no-files-found: error