Added flow to start recording during ongoing call and some state validations on recording start

Author: riul88

src/com/callrecorder/android/Constants.java

@@ -32,8 +32,9 @@ public class Constants {
 	public static final int STATE_INCOMING_NUMBER = 1;
 	public static final int STATE_CALL_START = 2;
 	public static final int STATE_CALL_END = 3;
-	public static final int STATE_STOP_RECORDING = 4;
-	public static final int RECORDING_ENABLED = 5;
-	public static final int RECORDING_DISABLED = 6;
+	public static final int STATE_START_RECORDING = 4;
+	public static final int STATE_STOP_RECORDING = 5;
+	public static final int RECORDING_ENABLED = 6;
+	public static final int RECORDING_DISABLED = 7;
 
 }

src/com/callrecorder/android/MainActivity.java

@@ -78,7 +78,8 @@ public void onCreate(Bundle savedInstanceState) {
 				Constants.LISTEN_ENABLED, 0);
 		boolean silentMode = settings.getBoolean("silentMode", true);
 
-		if (silentMode) showDialog(CATEGORY_DETAIL);
+		if (silentMode)
+			showDialog(CATEGORY_DETAIL);
 
 		context = this.getBaseContext();
 		// showDialog(TERMS);
@@ -281,6 +282,7 @@ private void setSharedPreferences(boolean silentMode) {
 		myIntent.putExtra("commandType",
 				silentMode ? Constants.RECORDING_DISABLED
 						: Constants.RECORDING_ENABLED);
+		myIntent.putExtra("silentMode", silentMode);
 		context.startService(myIntent);
 	}
 

src/com/callrecorder/android/RecordService.java

@@ -55,34 +55,37 @@ public void onCreate() {
 
 	@Override
 	public int onStartCommand(Intent intent, int flags, int startId) {
+		Log.d(Constants.TAG, "RecordService onStartCommand");
 		if (intent != null) {
 			int commandType = intent.getIntExtra("commandType", 0);
 			if (commandType != 0) {
-				Log.d(Constants.TAG, "RecordService onStartCommand");
 				if (commandType == Constants.RECORDING_ENABLED) {
 					Log.d(Constants.TAG, "RecordService RECORDING_ENABLED");
-					silentMode = false;
-					if (onCall && phoneNumber != null && !recording)
-						commandType = Constants.STATE_CALL_START;
+					silentMode = intent.getBooleanExtra("silentMode", true);
+					if (!silentMode && phoneNumber != null && onCall
+							&& !recording)
+						commandType = Constants.STATE_START_RECORDING;
+
 				} else if (commandType == Constants.RECORDING_DISABLED) {
 					Log.d(Constants.TAG, "RecordService RECORDING_DISABLED");
-					silentMode = true;
-					if (onCall && phoneNumber != null)
+					silentMode = intent.getBooleanExtra("silentMode", true);
+					if (onCall && phoneNumber != null && recording)
 						commandType = Constants.STATE_STOP_RECORDING;
 				}
-				
+
 				if (commandType == Constants.STATE_INCOMING_NUMBER) {
-					startService();
 					Log.d(Constants.TAG, "RecordService STATE_INCOMING_NUMBER");
+					startService();
 					if (phoneNumber == null)
 						phoneNumber = intent.getStringExtra("phoneNumber");
-	
+
 					silentMode = intent.getBooleanExtra("silentMode", true);
 				} else if (commandType == Constants.STATE_CALL_START) {
 					Log.d(Constants.TAG, "RecordService STATE_CALL_START");
 					onCall = true;
-	
-					if (!silentMode && phoneNumber != null) {
+
+					if (!silentMode && phoneNumber != null && onCall
+							&& !recording) {
 						startService();
 						startRecording(intent);
 					}
@@ -93,6 +96,12 @@ public int onStartCommand(Intent intent, int flags, int startId) {
 					stopAndReleaseRecorder();
 					recording = false;
 					stopService();
+				} else if (commandType == Constants.STATE_START_RECORDING) {
+					Log.d(Constants.TAG, "RecordService STATE_START_RECORDING");
+					if (!silentMode && phoneNumber != null && onCall) {
+						startService();
+						startRecording(intent);
+					}
 				} else if (commandType == Constants.STATE_STOP_RECORDING) {
 					Log.d(Constants.TAG, "RecordService STATE_STOP_RECORDING");
 					stopAndReleaseRecorder();