add [MetaJSON] to [@basic]

Author: karenetheridge

Changes

@@ -3,6 +3,8 @@ Revision history for {{$dist->name}}
 {{$NEXT}}
         - restrict [MetaYAML] to metaspec v1.4, [MetaJSON] to v2.0+, as other
           version combinations are not well-supported by the toolchain
+        - [MetaJSON] is now in [@Basic], with special handling to handle the
+          possibility the plugin is loaded twice
 
 6.006     2016-07-04 10:56:36-04:00 America/New_York
         - add some documentation to Dist::Zilla::App::Tester (thanks, Alberto

lib/Dist/Zilla/Plugin/MetaJSON.pm

@@ -5,6 +5,7 @@ use Moose;
 with 'Dist::Zilla::Role::FileGatherer';
 use Moose::Util::TypeConstraints;
 
+use List::Util 'first';
 use namespace::autoclean;
 
 =head1 DESCRIPTION
@@ -54,6 +55,12 @@ sub gather_files {
 
   my $zilla = $self->zilla;
 
+  # gracefully handle there being more than one of us (e.g. one via [@Basic])
+  if ((first { $_->isa(__PACKAGE__) } @{ $self->zilla->plugins }) != $self) {
+    $self->log('doing nothing: another [MetaJSON] already ran...');
+    return;
+  }
+
   require JSON::MaybeXS;
   require Dist::Zilla::File::FromCode;
   require CPAN::Meta::Converter;

lib/Dist/Zilla/PluginBundle/Basic.pm

@@ -14,6 +14,7 @@ sub configure {
     PruneCruft
     ManifestSkip
     MetaYAML
+    MetaJSON
     License
     Readme
     ExtraTests
@@ -45,6 +46,7 @@ It includes the following plugins with their default configuration:
 * L<Dist::Zilla::Plugin::PruneCruft>
 * L<Dist::Zilla::Plugin::ManifestSkip>
 * L<Dist::Zilla::Plugin::MetaYAML>
+* L<Dist::Zilla::Plugin::MetaJSON>
 * L<Dist::Zilla::Plugin::License>
 * L<Dist::Zilla::Plugin::Readme>
 * L<Dist::Zilla::Plugin::ExtraTests>

t/plugins/metajson.t

@@ -0,0 +1,37 @@
+use strict;
+use warnings;
+
+use Test::More 0.88;
+use if $ENV{AUTHOR_TESTING}, 'Test::Warnings';
+use Test::DZil;
+use Test::Fatal;
+use Path::Tiny;
+
+{
+  my $tzil = Builder->from_config(
+    { dist_root => 'does-not-exist' },
+    {
+      add_files => {
+        'source/dist.ini' => simple_ini(
+          '@Basic',
+          'MetaJSON',
+        ),
+      },
+    },
+  );
+
+  $tzil->chrome->logger->set_debug(1);
+  is(
+    exception { $tzil->build },
+    undef,
+    'build proceeds normally',
+  );
+
+  my $build_dir = path($tzil->tempdir)->child('build');
+  ok(-e $build_dir->child('META.json'), 'META.json was created successfully');
+
+  diag 'got log messages: ', explain $tzil->log_messages
+    if not Test::Builder->new->is_passing;
+}
+
+done_testing;