Remove use of obsolete overload Compilation.WithAnalyzers using a CancellationToken

Author: rjmurillo

Diff for: Directory.Packages.props

@@ -12,14 +12,17 @@
       These items impact our compatibility with SDK versions, so follow
       to strike a balance between compatibility and modernity.
 
-      These are the two main documents to reference how the Public API impacts users:
-      - https://github.com/dotnet/roslyn/blob/main/docs/wiki/NuGet-packages.md
+      These are the three main documents to reference how the Public API impacts users:
+      - https://github.com/dotnet/roslyn/blob/main/docs/wiki/NuGet-packages.md?plain=1
+      - https://learn.microsoft.com/en-us/dotnet/core/porting/versioning-sdk-msbuild-vs#lifecycle
       - https://learn.microsoft.com/en-us/visualstudio/productinfo/vs-servicing
     -->
-    <PackageVersion Include="Microsoft.Bcl.HashCode" Version="1.1.1" />
-    <PackageVersion Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.3.1" />
+    <!-- We are using 4.8, which introduces .NET 8 and supports VS 2022 17.8 -->
+    <PackageVersion Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.8" />
+    <PackageVersion Include="Microsoft.CodeAnalysis.CSharp" Version="4.8" />
   </ItemGroup>
   <ItemGroup>
+    <PackageVersion Include="Microsoft.Bcl.HashCode" Version="1.1.1" />
     <PackageVersion Include="BenchmarkDotNet" Version="0.13.12" />
     <PackageVersion Include="BenchmarkDotNet.Diagnostics.dotTrace" Version="0.13.12" />
     <PackageVersion Include="GetPackFromProject" Version="1.0.6" />

Diff for: tests/EffectiveCSharp.Analyzers.Benchmarks/Helpers/BenchmarkCSharpCompilationFactory.cs

@@ -16,8 +16,8 @@ internal static class BenchmarkCSharpCompilationFactory
             throw new InvalidOperationException("Failed to create compilation");
         }
 
-        CompilationWithAnalyzers baseline = compilation.WithAnalyzers([new EmptyDiagnosticAnalyzer()], options, CancellationToken.None);
-        CompilationWithAnalyzers test = compilation.WithAnalyzers([new TAnalyzer()], options, CancellationToken.None);
+        CompilationWithAnalyzers baseline = compilation.WithAnalyzers([new EmptyDiagnosticAnalyzer()], options);
+        CompilationWithAnalyzers test = compilation.WithAnalyzers([new TAnalyzer()], options);
 
         return (baseline, test);
     }
@@ -35,9 +35,9 @@ internal static class BenchmarkCSharpCompilationFactory
             throw new InvalidOperationException("Failed to create compilation");
         }
 
-        CompilationWithAnalyzers baseline = compilation.WithAnalyzers([new EmptyDiagnosticAnalyzer()], options, CancellationToken.None);
-        CompilationWithAnalyzers test1 = compilation.WithAnalyzers([new TAnalyzer1()], options, CancellationToken.None);
-        CompilationWithAnalyzers test2 = compilation.WithAnalyzers([new TAnalyzer2()], options, CancellationToken.None);
+        CompilationWithAnalyzers baseline = compilation.WithAnalyzers([new EmptyDiagnosticAnalyzer()], options);
+        CompilationWithAnalyzers test1 = compilation.WithAnalyzers([new TAnalyzer1()], options);
+        CompilationWithAnalyzers test2 = compilation.WithAnalyzers([new TAnalyzer2()], options);
 
         return (baseline, test1, test2);
     }