Skip to content

Commit 6c9445e

Browse files
authored
Updating for new functionality from dotnet/orleans#9870
1 parent e39e768 commit 6c9445e

File tree

2 files changed

+34
-5
lines changed

2 files changed

+34
-5
lines changed

docs/orleans/host/monitoring/index.md

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -369,8 +369,22 @@ builder.Services.AddOpenTelemetry()
369369
ResourceBuilder.CreateDefault()
370370
.AddService(serviceName: "GPSTracker", serviceVersion: "1.0"));
371371

372-
tracing.AddSource("Microsoft.Orleans.Runtime");
373-
tracing.AddSource("Microsoft.Orleans.Application");
372+
// Good baseline for general Orleans observability
373+
tracing.AddSource(Orleans.Diagnostics.ActivitySources.ApplicationGrainActivitySourceName);
374+
tracing.AddSource(Orleans.Diagnostics.ActivitySources.LifecycleActivitySourceName);
375+
376+
/*
377+
// Other source also available
378+
// Persistence spans
379+
tracing.AddSource(Orleans.Diagnostics.ActivitySources.StorageActivitySourceName);
380+
// Internal Runtime spans
381+
tracing.AddSource(Orleans.Diagnostics.ActivitySources.RuntimeActivitySourceName);
382+
*/
383+
384+
/*
385+
// Optionally add all Microsoft.Orleans.* Sources at once
386+
tracing.AddSource(Orleans.Diagnostics.ActivitySources.AllActivitySourceName);
387+
*/
374388

375389
tracing.AddZipkinExporter(zipkin =>
376390
{

docs/orleans/migration-guide.md

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -282,8 +282,23 @@ builder.Services.AddOpenTelemetry()
282282
.AddService(serviceName: "ExampleService", serviceVersion: "1.0"));
283283

284284
tracing.AddAspNetCoreInstrumentation();
285-
tracing.AddSource("Microsoft.Orleans.Runtime");
286-
tracing.AddSource("Microsoft.Orleans.Application");
285+
286+
// Good baseline for general Orleans observability
287+
tracing.AddSource(Orleans.Diagnostics.ActivitySources.ApplicationGrainActivitySourceName);
288+
tracing.AddSource(Orleans.Diagnostics.ActivitySources.LifecycleActivitySourceName);
289+
290+
/*
291+
// Other source also available
292+
// Persistence spans
293+
tracing.AddSource(Orleans.Diagnostics.ActivitySources.StorageActivitySourceName);
294+
// Internal Runtime spans
295+
tracing.AddSource(Orleans.Diagnostics.ActivitySources.RuntimeActivitySourceName);
296+
*/
297+
298+
/*
299+
// Optionally add all Microsoft.Orleans.* Sources at once
300+
tracing.AddSource(Orleans.Diagnostics.ActivitySources.AllActivitySourceName);
301+
*/
287302

288303
tracing.AddZipkinExporter(options =>
289304
{
@@ -294,8 +309,8 @@ builder.Services.AddOpenTelemetry()
294309

295310
In the preceding code, OpenTelemetry is configured to monitor:
296311

297-
- `Microsoft.Orleans.Runtime`
298312
- `Microsoft.Orleans.Application`
313+
- `Microsoft.Orleans.Lifecycle`
299314

300315
To propagate activity, call <xref:Orleans.Hosting.ClientBuilderExtensions.AddActivityPropagation%2A>:
301316

0 commit comments

Comments
 (0)