Help With Ruby 3.4 test compatability

[arielvalentin]

I am working on adding test converation for Ruby 3.4 to OTel Ruby and am running into some issues with our test setup and was wondering if you could take a look

https://github.com/open-telemetry/opentelemetry-ruby-contrib/actions/runs/13046294152/job/36397339951?pr=1347

/opt/hostedtoolcache/Ruby/3.4.1/x64/lib/ruby/gems/3.4.0/gems/graphql-2.0.18/lib/graphql/schema/interface.rb:74:in 'GraphQL::Schema::Interface::DefinitionMethods#included': Attach interfaces using `implements(Vehicle)`, not `include(Vehicle)` (RuntimeError)
  	from /opt/hostedtoolcache/Ruby/3.4.1/x64/lib/ruby/gems/3.4.0/gems/graphql-2.0.18/lib/graphql/schema/member/has_interfaces.rb:20:in 'Module#include'
  	from /opt/hostedtoolcache/Ruby/3.4.1/x64/lib/ruby/gems/3.4.0/gems/graphql-2.0.18/lib/graphql/schema/member/has_interfaces.rb:20:in 'block in GraphQL::Schema::Member::HasInterfaces#implements'
  	from /opt/hostedtoolcache/Ruby/3.4.1/x64/lib/ruby/gems/3.4.0/gems/graphql-2.0.18/lib/graphql/schema/member/has_interfaces.rb:9:in 'Array#each'
  	from /opt/hostedtoolcache/Ruby/3.4.1/x64/lib/ruby/gems/3.4.0/gems/graphql-2.0.18/lib/graphql/schema/member/has_interfaces.rb:9:in 'GraphQL::Schema::Member::HasInterfaces#implements'
  	from /home/runner/work/opentelemetry-ruby-contrib/opentelemetry-ruby-contrib/instrumentation/graphql/test/test_helper.rb:49:in '<class:Car>'
  	from /home/runner/work/opentelemetry-ruby-contrib/opentelemetry-ruby-contrib/instrumentation/graphql/test/test_helper.rb:48:in '<top (required)>'
  	from /opt/hostedtoolcache/Ruby/3.4.1/x64/lib/ruby/3.4.0/bundled_gems.rb:82:in 'Kernel.require'
  	from /opt/hostedtoolcache/Ruby/3.4.1/x64/lib/ruby/3.4.0/bundled_gems.rb:82:in 'block (2 levels) in Kernel#replace_require'
  	from /home/runner/work/opentelemetry-ruby-contrib/opentelemetry-ruby-contrib/instrumentation/graphql/test/instrumentation/graphql/instrumentation_test.rb:7:in '<top (required)>'
  	from /opt/hostedtoolcache/Ruby/3.4.1/x64/lib/ruby/3.4.0/bundled_gems.rb:82:in 'Kernel.require'
  	from /opt/hostedtoolcache/Ruby/3.4.1/x64/lib/ruby/3.4.0/bundled_gems.rb:82:in 'block (2 levels) in Kernel#replace_require'
  	from /opt/hostedtoolcache/Ruby/3.4.1/x64/lib/ruby/gems/3.4.0/gems/rake-13.2.1/lib/rake/rake_test_loader.rb:21:in 'block in <main>'
  	from /opt/hostedtoolcache/Ruby/3.4.1/x64/lib/ruby/gems/3.4.0/gems/rake-13.2.1/lib/rake/rake_test_loader.rb:6:in 'Array#select'
  	from /opt/hostedtoolcache/Ruby/3.4.1/x64/lib/ruby/gems/3.4.0/gems/rake-13.2.1/lib/rake/rake_test_loader.rb:6:in '<main>'

Should we be setting our test types up differently here?

[rmosolgo]

Hey, thanks for reporting this and sorry for the trouble. 2.2.10+ has this patch to fix the issue: #4846. That change can be backported to 2.0.x and 2.1.x -- feel free to give it a try if you have time, or I'll follow up here as soon as I get a chance.

[arielvalentin]

No worries! I appreciate the help.

One thing I'd like to review with you is our test coverage. We have a policy that we aren't going to guarantee coverage or comparability for EoL versions of Ruby or gems.

Would you mind having a look at our appraisals file to make sure we're covering all of the versions you are supporting as part of this repo?

[rmosolgo]

I honestly don't have a support policy for old versions. If it's out there, and someone is using it, and the work is do-able between us, then I'm game to ship a patch!

[arielvalentin]

Ok so if I understand this correctly we will need to restrict Ruby 3.4 compatibility to a min version of +2.2.10

Is that right?

[arielvalentin]

I have updated our appraisal files with what I think are the correct configurations.

open-telemetry/opentelemetry-ruby-contrib#1347

Please take a look when you have a moment.

[rmosolgo]

IIUC, yes, out-of-the-box, using GraphQL-Ruby < 2.2.10 with Ruby 3.4 won't work. If you want to get 2.0.x and 2.1.x going on Ruby 3.4, we totally could.

That test coverage looks good to me -- 2.0.x to 2.4.x, plus latest, and a couple of graphql-c_parser builds 👍

[rmosolgo]

I think we're in good shape here, so I'll close this out. Please let me know if I've overlooked anything I can help with!