setCamera doesn't take effect if followUserLocation set to true

[mkraina]

Describe the bug
setCamera doesn't take effect if followUserLocation set to true

To Reproduce
set Camera's component followUserLocation prop to true and try to call setCamera on it's ref

Example:

const MapView = (props) => {
  const resetRotation = useCallback(() => {
    camera.current?.setCamera({
      heading: 0,
      animationDuration: 200,
    });
  }, []);

  return (
    <MapboxGL.MapView>
      <MapboxGL.Camera
        ref={camera}
        followUserLocation
        followUserMode={'normal'}
      />
    </MapboxGL.MapView>
  );
};

Expected behavior
it should be possible to setCamera or at least some of it's props in case followUserLocation===true
while i see there can be some conflict updating the coords (which one should be prioritized?) at least zoomLevel, pitch and rotation should be just fine

Screenshots

Versions (please complete the following information):

• Platform:both ios and android
• react-native-mapbox-gl 8.1.0-rc.4, 8.1.0-rc.6
• React Native Version 0.62

[mkraina]

inspecting the code i've found following

  _createStopConfig(config = {}, ignoreFollowUserLocation = false) {
    if (this.props.followUserLocation && !ignoreFollowUserLocation) {
      return null;
    }
    ...
  }

  setCamera(config = {}) {
    this._setCamera(config);
  }

  _setCamera(config = {}) {
    let cameraConfig = {};

    if (config.stops) {
      cameraConfig.stops = [];

      for (const stop of config.stops) {
        cameraConfig.stops.push(this._createStopConfig(stop));
      }
    } else {
      cameraConfig = this._createStopConfig(config);
    }

    this.refs.camera.setNativeProps({stop: cameraConfig});
  }

wouldn't it make sense to at least provide possibility to pass ignoreFollowUserLocation as the Camera.setCamera fc parameter?

[ferdicus]

hey @nasmuris, sounds reasonable to me - would you be willing to open a PR for this?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[SethArchambault]

I'd say this is a particularly important feature right now because in order for UserLocation renderMode to be native on android, Camera followUserLocation must be true, but if followUserLocation is true, setCamera can't be used! Can we reopen?

[systemlevel]

Right, I believe that is the current status on setCamera. I'm wondering if we can get it consistent with how the iOS version works?

[ferdicus]

I'll reopen this - and yes, would be great if someone could take a jab at this.
I could try, however I can't make any promises to when it would be done

[ferdicus]

as a workaround for not being able to use setCamera atm, did you see, that you could simply use these three, they would work for exactly the settings you'd like to edit @nasmuris :

Prop	Type	Default	Required	Description
followZoomLevel	number	none	false	The zoomLevel on map while followUserLocation is set to true
followPitch	number	none	false	The pitch on map while followUserLocation is set to true
followHeading	number	none	false	The heading on map while followUserLocation is set to true

[manarfalah]

Same issue here, as a workaround could you please give an example how to use these attributes ?, I have navigation mode map which use followUserLocation, if user moved the map and clicked on center button I want to get back to current location. @ferdicus