fix(migrations): Fixed missing DB indexes drop in existing migrations

Author: roadiz-ci

config/routing.yaml

@@ -17,11 +17,6 @@ nodesRoutes:
     resource: "routing/nodes.yml"
     prefix: /rz-admin/nodes
 
-## Ajax
-ajaxRequestsRoutes:
-    resource: "routing/ajax.yml"
-    prefix: /rz-admin/ajax
-
 # Node TYPES
 nodeTypesHomePage:
     path:     /rz-admin/node-types
@@ -57,15 +52,6 @@ settingGroupsRoutes:
     resource: "routing/setting-groups.yml"
     prefix: /rz-admin/setting-groups
 
-
-# TAGS
-tagsHomePage:
-    path:     /rz-admin/tags
-    controller: RZ\Roadiz\RozierBundle\Controller\Tag\TagController::indexAction
-tagsRoutes:
-    resource: "routing/tags.yml"
-    prefix: /rz-admin/tags
-
 # USERS
 usersHomePage:
     path:     /rz-admin/users

config/routing/ajax.yml

@@ -6,10 +6,12 @@
 
 use RZ\Roadiz\CoreBundle\Entity\AttributeValue;
 use RZ\Roadiz\CoreBundle\Security\Authorization\Voter\NodeVoter;
+use Symfony\Bridge\Doctrine\Attribute\MapEntity;
 use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
+use Symfony\Component\Routing\Attribute\Route;
 
 final class AjaxAttributeValuesController extends AbstractAjaxController
 {
@@ -23,22 +25,22 @@ final class AjaxAttributeValuesController extends AbstractAjaxController
      *
      * @return Response JSON response
      */
-    public function editAction(Request $request, int $attributeValueId): Response
-    {
-        /*
-         * Validate
-         */
+    #[Route(
+        path: '/rz-admin/ajax/attribute-values/edit/{attributeValueId}',
+        name: 'attributeValueAjaxEdit',
+        requirements: ['attributeValueId' => '\d+'],
+        format: 'json',
+    )]
+    public function editAction(
+        Request $request,
+        #[MapEntity(
+            expr: 'repository.find(attributeValueId)',
+            evictCache: true,
+            message: 'AttributeValue does not exist'
+        )]
+        AttributeValue $attributeValue,
+    ): Response {
         $this->validateRequest($request, 'POST', false);
-
-        /** @var AttributeValue|null $attributeValue */
-        $attributeValue = $this->managerRegistry
-            ->getRepository(AttributeValue::class)
-            ->find($attributeValueId);
-
-        if (null === $attributeValue) {
-            throw $this->createNotFoundException($this->translator->trans('attribute_value.%attributeValueId%.not_exists', ['%attributeValueId%' => $attributeValueId]));
-        }
-
         $this->denyAccessUnlessGranted(NodeVoter::EDIT_ATTRIBUTE, $attributeValue->getAttributable());
 
         $responseArray = [];

config/routing/tags.yml

@@ -5,8 +5,10 @@
 namespace RZ\Roadiz\RozierBundle\Controller\Ajax;
 
 use RZ\Roadiz\CoreBundle\Entity\CustomFormField;
+use Symfony\Bridge\Doctrine\Attribute\MapEntity;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
+use Symfony\Component\Routing\Attribute\Route;
 
 final class AjaxCustomFormFieldsController extends AjaxAbstractFieldsController
 {
@@ -16,18 +18,29 @@ final class AjaxCustomFormFieldsController extends AjaxAbstractFieldsController
      *
      * @return Response JSON response
      */
-    public function editAction(Request $request, int $customFormFieldId): Response
-    {
+    #[Route(
+        path: '/rz-admin/ajax/custom-forms/fields/edit/{customFormFieldId}',
+        name: 'customFormFieldAjaxEdit',
+        requirements: ['customFormFieldId' => '\d+'],
+        format: 'json'
+    )]
+    public function editAction(
+        Request $request,
+        #[MapEntity(
+            expr: 'repository.find(customFormFieldId)',
+            evictCache: true,
+            message: 'field.%customFormFieldId%.not_exists'
+        )]
+        CustomFormField $field,
+    ): Response {
         $this->validateRequest($request);
         $this->denyAccessUnlessGranted('ROLE_ACCESS_CUSTOMFORMS_DELETE');
 
-        $field = $this->findEntity((int) $customFormFieldId);
-
-        if (null !== $field && null !== $response = $this->handleFieldActions($request, $field)) {
+        if (null !== $response = $this->handleFieldActions($request, $field)) {
             return $response;
         }
 
-        throw $this->createNotFoundException($this->translator->trans('field.%customFormFieldId%.not_exists', ['%customFormFieldId%' => $customFormFieldId]));
+        throw $this->createNotFoundException($this->translator->trans('field.%customFormFieldId%.not_exists', ['%customFormFieldId%' => $field->getId()]));
     }
 
     #[\Override]