refactor: refactor all NodeType and NodesSources class-name resolution and improve nodetypes:validate-files (#262)

Author: roadiz-ci

src/Controller/Node/NodesSourcesController.php

@@ -5,6 +5,7 @@
 namespace RZ\Roadiz\RozierBundle\Controller\Node;
 
 use Doctrine\Persistence\ManagerRegistry;
+use RZ\Roadiz\Contracts\NodeType\NodeTypeClassLocatorInterface;
 use RZ\Roadiz\Core\AbstractEntities\PersistableInterface;
 use RZ\Roadiz\CoreBundle\Bag\DecoratedNodeTypes;
 use RZ\Roadiz\CoreBundle\Entity\Node;
@@ -60,6 +61,7 @@ public function __construct(
         private readonly AllStatusesNodesSourcesRepository $allStatusesNodesSourcesRepository,
         private readonly AllStatusesNodeRepository $allStatusesNodeRepository,
         private readonly TranslationRepository $translationRepository,
+        private readonly NodeTypeClassLocatorInterface $nodeTypeClassLocator,
         private readonly ?string $customPublicScheme,
         private readonly ?string $customPreviewScheme,
     ) {
@@ -129,7 +131,7 @@ public function editSourceAction(Request $request, int $nodeId, int $translation
             NodeSourceType::class,
             $source,
             [
-                'class' => $nodeType->getSourceEntityFullQualifiedClassName(),
+                'class' => $this->nodeTypeClassLocator->getSourceEntityFullQualifiedClassName($nodeType),
                 'nodeType' => $nodeType,
                 'withVirtual' => true,
                 'withTitle' => true,

src/Controller/NodeType/NodeTypeExportController.php

@@ -4,6 +4,7 @@
 
 namespace RZ\Roadiz\RozierBundle\Controller\NodeType;
 
+use RZ\Roadiz\Contracts\NodeType\NodeTypeClassLocatorInterface;
 use RZ\Roadiz\CoreBundle\Bag\DecoratedNodeTypes;
 use RZ\Roadiz\Documentation\Generators\DocumentationGenerator;
 use RZ\Roadiz\Typescript\Declaration\DeclarationGeneratorFactory;
@@ -23,6 +24,7 @@ final class NodeTypeExportController extends AbstractController
     public function __construct(
         private readonly DecoratedNodeTypes $nodeTypesBag,
         private readonly TranslatorInterface $translator,
+        private readonly NodeTypeClassLocatorInterface $nodeTypeClassLocator,
     ) {
     }
 
@@ -79,7 +81,8 @@ public function exportTypeScriptDeclarationAction(Request $request): Response
         $this->denyAccessUnlessGranted('ROLE_ACCESS_NODETYPES');
 
         $documentationGenerator = new DeclarationGenerator(
-            new DeclarationGeneratorFactory($this->nodeTypesBag)
+            new DeclarationGeneratorFactory($this->nodeTypesBag, $this->nodeTypeClassLocator),
+            $this->nodeTypeClassLocator
         );
 
         $fileName = 'roadiz-app-'.date('Ymd-His').'.d.ts';

src/Controller/SearchController.php

@@ -5,9 +5,11 @@
 namespace RZ\Roadiz\RozierBundle\Controller;
 
 use Doctrine\Persistence\ManagerRegistry;
+use RZ\Roadiz\Contracts\NodeType\NodeTypeClassLocatorInterface;
 use RZ\Roadiz\Core\Handlers\HandlerFactoryInterface;
 use RZ\Roadiz\CoreBundle\Bag\NodeTypes;
 use RZ\Roadiz\CoreBundle\Entity\Node;
+use RZ\Roadiz\CoreBundle\Entity\NodesSources;
 use RZ\Roadiz\CoreBundle\Entity\NodeType;
 use RZ\Roadiz\CoreBundle\Entity\NodeTypeField;
 use RZ\Roadiz\CoreBundle\Entity\Tag;
@@ -63,6 +65,7 @@ public function __construct(
         private readonly Registry $workflowRegistry,
         private readonly EntityListManagerFactoryInterface $entityListManagerFactory,
         private readonly AllStatusesNodeRepository $allStatusesNodeRepository,
+        private readonly NodeTypeClassLocatorInterface $nodeTypeClassLocator,
         private readonly array $csvEncoderOptions,
     ) {
     }
@@ -415,9 +418,11 @@ protected function handleNodeForm(
         }
         $data = $this->processCriteria($data, $pagination, $itemPerPage, 'node.');
         $data = $this->processCriteriaNodeType($data, $nodeType);
+        /** @var class-string<NodesSources> $entityClassName */
+        $entityClassName = $this->nodeTypeClassLocator->getSourceEntityFullQualifiedClassName($nodeType);
 
         $listManager = $this->entityListManagerFactory->createEntityListManager(
-            $nodeType->getSourceEntityFullQualifiedClassName(),
+            $entityClassName,
             $data
         );
         $listManager->setDisplayingNotPublishedNodes(true);