Skip to content

Commit 50efc9a

Browse files
dawidprzybylorlubos
authored andcommitted
CODEOWNERS: Fix shields ownership overwrite
This commit fixes an issue with shield ownership assignments in the CODEOWNERS file: - Moved the general shields pattern (**/shields/) above specific shield entries - Modified specific shield entries to include both teams: - Added @nrfconnect/ncs-co-build-system to each specific shield entry - Preserved original team assignments (@nrfconnect/ncs-low-level-test and @nrfconnect/ncs-radio-sw) - Removed misleading comment about shield entry positioning The previous configuration caused specific shield owners to be overwritten by the general @nrfconnect/ncs-co-build-system entry. Signed-off-by: Dawid Przybylo <dawid.przybylo@nordicsemi.no>
1 parent 77e0736 commit 50efc9a

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

CODEOWNERS

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -54,14 +54,14 @@
5454
/boards/nordic/nrf54l*/ @nrfconnect/ncs-co-boards @kl-cruz
5555
/boards/nordic/nrf52* @nrfconnect/ncs-co-boards @nrfconnect/ncs-si-bluebagel
5656
/boards/nordic/thingy91*/ @nrfconnect/ncs-co-boards @nrfconnect/ncs-cia
57-
/boards/shields/coverage_support/ @nrfconnect/ncs-low-level-test
58-
/boards/shields/nrf2220ek/ @nrfconnect/ncs-radio-sw
59-
/boards/shields/nrf2240ek/ @nrfconnect/ncs-radio-sw
60-
/boards/shields/nrf21540ek/ @nrfconnect/ncs-radio-sw
6157

62-
# This shield entry must be below other shield entries (excluding doc), do not move
6358
**/shields/ @nrfconnect/ncs-co-build-system
6459

60+
/boards/shields/coverage_support/ @nrfconnect/ncs-co-build-system @nrfconnect/ncs-low-level-test
61+
/boards/shields/nrf2220ek/ @nrfconnect/ncs-co-build-system @nrfconnect/ncs-radio-sw
62+
/boards/shields/nrf2240ek/ @nrfconnect/ncs-co-build-system @nrfconnect/ncs-radio-sw
63+
/boards/shields/nrf21540ek/ @nrfconnect/ncs-co-build-system @nrfconnect/ncs-radio-sw
64+
6565
/boards/shields/pca63566/doc/*.rst @nrfconnect/ncs-doc-leads
6666

6767
# SUIT configuration files

0 commit comments

Comments
 (0)