Skip to content

Commit 074c205

Browse files
authored
Merge pull request #99 from robbdimitrov/fixes/update
Fixes/update
2 parents 8fabf57 + c7b7818 commit 074c205

7 files changed

Lines changed: 27 additions & 11 deletions

File tree

Example/Classes/Controllers/RDVDetailsViewController.m

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,11 @@ @implementation RDVDetailsViewController
1818
- (void)viewDidLoad {
1919
[super viewDidLoad];
2020

21-
self.title = @"Details";
21+
self.title = NSLocalizedString(@"Details", nil);
2222
self.view.backgroundColor = [UIColor colorWithRed:250/255.0 green:250/255.0 blue:250/255.0 alpha:1.0];
2323

2424
UILabel *label = [[UILabel alloc] init];
25-
label.text = @"Detail View Controller";
25+
label.text = NSLocalizedString(@"Detail View Controller", nil);
2626
label.frame = CGRectMake(20, 150, CGRectGetWidth(self.view.frame) - 2 * 20, 20);
2727
label.autoresizingMask = UIViewAutoresizingFlexibleWidth;
2828
label.textAlignment = NSTextAlignmentCenter;

Example/Classes/Controllers/RDVFirstViewController.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ @implementation RDVFirstViewController
3030
- (instancetype)init {
3131
self = [super init];
3232
if (self) {
33-
self.title = @"First";
33+
self.title = NSLocalizedString(@"First", nil);
3434
}
3535
return self;
3636
}

Example/Classes/Controllers/RDVSecondViewController.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ @implementation RDVSecondViewController
2929
- (instancetype)init {
3030
self = [super init];
3131
if (self) {
32-
self.title = @"Second";
32+
self.title = NSLocalizedString(@"Second", nil);
3333
}
3434
return self;
3535
}

Example/Classes/Controllers/RDVThirdViewController.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ @implementation RDVThirdViewController
3030
- (instancetype)init {
3131
self = [super init];
3232
if (self) {
33-
self.title = @"Third";
33+
self.title = NSLocalizedString(@"Third", nil);
3434
}
3535
return self;
3636
}

RDVTabBarController.podspec

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
Pod::Spec.new do |s|
22
s.name = "RDVTabBarController"
3-
s.version = "1.2.0"
3+
s.version = "1.3.0"
44
s.summary = "Highly customizable tabBar and tabBarController for iOS"
55
s.description = "RDVTabBarController is iPad and iPhone compatible. Supports landscape and portrait orientations and can be used inside UINavigationController."
66
s.homepage = "https://github.com/robbdimitrov/RDVTabBarController"
77
s.license = { :type => 'MIT', :file => 'LICENSE' }
88
s.author = { "Robert Dimitrov" => "robert_dimitrov@me.com" }
99
s.platform = :ios, '8.0'
10-
s.source = { :git => "https://github.com/robbdimitrov/RDVTabBarController.git", :tag => "v1.2.0" }
10+
s.source = { :git => "https://github.com/robbdimitrov/RDVTabBarController.git", :tag => "v1.3.0" }
1111
s.source_files = 'RDVTabBarController', 'RDVTabBarController/**/*.{h,m}'
1212
s.framework = 'UIKit', 'CoreGraphics', 'Foundation'
1313
s.requires_arc = true

RDVTabBarController.xcodeproj/project.pbxproj

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -290,15 +290,21 @@
290290
isa = PBXProject;
291291
attributes = {
292292
CLASSPREFIX = RDV;
293-
LastUpgradeCheck = 1000;
293+
LastUpgradeCheck = 1100;
294294
ORGANIZATIONNAME = "Robert Dimitrov";
295+
TargetAttributes = {
296+
B4616BAA17228DF700863892 = {
297+
ProvisioningStyle = Automatic;
298+
};
299+
};
295300
};
296301
buildConfigurationList = B4616BA617228DF700863892 /* Build configuration list for PBXProject "RDVTabBarController" */;
297302
compatibilityVersion = "Xcode 3.2";
298-
developmentRegion = English;
303+
developmentRegion = en;
299304
hasScannedForEncodings = 0;
300305
knownRegions = (
301306
en,
307+
Base,
302308
);
303309
mainGroup = B4616BA217228DF700863892;
304310
productRefGroup = B4616BAC17228DF700863892 /* Products */;
@@ -387,6 +393,7 @@
387393
isa = XCBuildConfiguration;
388394
buildSettings = {
389395
ALWAYS_SEARCH_USER_PATHS = NO;
396+
CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
390397
CLANG_CXX_LANGUAGE_STANDARD = "gnu++0x";
391398
CLANG_CXX_LIBRARY = "libc++";
392399
CLANG_ENABLE_OBJC_ARC = YES;
@@ -437,6 +444,7 @@
437444
isa = XCBuildConfiguration;
438445
buildSettings = {
439446
ALWAYS_SEARCH_USER_PATHS = NO;
447+
CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
440448
CLANG_CXX_LANGUAGE_STANDARD = "gnu++0x";
441449
CLANG_CXX_LIBRARY = "libc++";
442450
CLANG_ENABLE_OBJC_ARC = YES;
@@ -479,25 +487,33 @@
479487
B4616BC917228DF700863892 /* Debug */ = {
480488
isa = XCBuildConfiguration;
481489
buildSettings = {
490+
CODE_SIGN_IDENTITY = "Apple Development";
491+
CODE_SIGN_STYLE = Automatic;
492+
DEVELOPMENT_TEAM = "";
482493
GCC_PRECOMPILE_PREFIX_HEADER = YES;
483494
GCC_PREFIX_HEADER = "Example/RDVTabBarController-Prefix.pch";
484495
INFOPLIST_FILE = "$(SRCROOT)/Example/RDVTabBarController-Info.plist";
485496
IPHONEOS_DEPLOYMENT_TARGET = 8.0;
486497
PRODUCT_BUNDLE_IDENTIFIER = "com.robbdimitrov.${PRODUCT_NAME:rfc1034identifier}";
487498
PRODUCT_NAME = "$(TARGET_NAME)";
499+
PROVISIONING_PROFILE_SPECIFIER = "";
488500
WRAPPER_EXTENSION = app;
489501
};
490502
name = Debug;
491503
};
492504
B4616BCA17228DF700863892 /* Release */ = {
493505
isa = XCBuildConfiguration;
494506
buildSettings = {
507+
CODE_SIGN_IDENTITY = "Apple Development";
508+
CODE_SIGN_STYLE = Automatic;
509+
DEVELOPMENT_TEAM = "";
495510
GCC_PRECOMPILE_PREFIX_HEADER = YES;
496511
GCC_PREFIX_HEADER = "Example/RDVTabBarController-Prefix.pch";
497512
INFOPLIST_FILE = "$(SRCROOT)/Example/RDVTabBarController-Info.plist";
498513
IPHONEOS_DEPLOYMENT_TARGET = 8.0;
499514
PRODUCT_BUNDLE_IDENTIFIER = "com.robbdimitrov.${PRODUCT_NAME:rfc1034identifier}";
500515
PRODUCT_NAME = "$(TARGET_NAME)";
516+
PROVISIONING_PROFILE_SPECIFIER = "";
501517
WRAPPER_EXTENSION = app;
502518
};
503519
name = Release;

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,8 +105,8 @@ tabBar.backgroundView.backgroundColor = [UIColor colorWithRed:245/255.0
105105
## Requirements
106106
107107
* ARC
108-
* iOS 5.0 or later
109-
* Xcode 5
108+
* iOS 8.0 or later
109+
* Xcode 11
110110
111111
## Contact
112112

0 commit comments

Comments
 (0)