About roundf() in RDVTabBarItem

[kirinzer]

Description

I found that use roundf() to calculate rect in RDVTabBarItem is not perfect. Image and title have a different center point in the horizontal. I use floor() to replace roundf(). It works fine. Image and title look like on the right position.

So, could you tell me why not you choice floor()? Thx.

Steps to Reproduce

Use iPhone Plus, X and X Max can reproduce it.

[robbdimitrov]

round did the job, but floor should be equally good solution.

[kirinzer]

All right, do you need a pull request to enhance that?

[kirinzer]

And I had another question. Why do you set 58 for the tabbar height? In my opinion, the default height is 49 without a safe area. So as a result, I create a subclass and rewrite viewDidLayoutSubviews to change the height. I am not sure it's the right way to use it. So do you agree with it?