Removing tiger geocoder

Author: robe2

.codespellrc

@@ -4,7 +4,6 @@ skip =
     ./deps/**,
     ./extensions/*/sql/**,
     ./extensions/*/sql_bits/*.sql,
-    ./extensions/postgis_tiger_geocoder/sql_bits/*.sql.in,
     ./doc/html/**,
     ./doc/po/**,
     ./doc/postgis-out.xml,

AGENTS.md

@@ -162,7 +162,7 @@ Execute the same test targets used in CI:
 
 ```bash
 # Standard compile + regression suite
-make check RUNTESTFLAGS="--verbose --extension --raster --topology --sfcgal --tiger"
+make check RUNTESTFLAGS="--verbose --extension --raster --topology --sfcgal"
 
 # Undefined behaviour sanitiser runs
 CC=clang ./configure CFLAGS="-g3 -O0 -fno-omit-frame-pointer -fsanitize=undefined" LDFLAGS="-fsanitize=undefined"

GNUmakefile.in

@@ -276,7 +276,6 @@ postgis_revision.h:
 include $(top_builddir)/regress/core/tests.mk
 include $(top_srcdir)/regress/loader/tests.mk
 include $(top_srcdir)/regress/dumper/tests.mk
-include $(top_srcdir)/extensions/postgis_tiger_geocoder/tests.mk
 ifeq ($(HAVE_SFCGAL),yes)
 	override RUNTESTFLAGS := $(RUNTESTFLAGS) --sfcgal
 	include $(top_builddir)/sfcgal/regress/tests.mk

LICENSE.TXT

@@ -55,7 +55,7 @@ The documentation for PostGIS is under a creative commons share-alike
 3.0 license.  http://creativecommons.org/licenses/by-sa/3.0/
 
 Data used in documentation falls in one of the following categories
-- Many of the examples in the topology and tiger geocoder section utilize
+- Many of the examples in the topology section utilize
   data from US Census Tiger data 2010
   https://www.census.gov/geo/www/tiger/tgrshp2010/tgrshp2010.html
 - data or snapshots generated by community

README.postgis

@@ -16,8 +16,7 @@ Directory structure::
   ./doc         PostGIS Documentation
   ./extensions  Support for the PostgreSQL Extensions framework
   ./extras      Various pieces that didn't belong to mainstream
-                (package management specfiles, sample WKB parser,
-                postgis_tiger_geocoder)
+                (package management specfiles, sample WKB parser)
   ./fuzzers     Google fuzz tests for liblwgeom
   ./liblwgeom   LWGEOM geometry library
   ./libpgcommon PostGIS library to bridge LWGEOM to PostgreSQL

ci/winnie/package_postgis.sh

@@ -171,7 +171,7 @@ value=${value//UPGRADEABLE_VERSIONS = /}
 export UPGRADEABLE_VERSIONS=$value
 #echo "Versions are:  $UPGRADEABLE_VERSIONS"
 export WIN_RELEASED_VERSIONS="2.0.0 2.0.1 2.0.3 2.0.4 2.0.6 2.1.4 2.1.7 2.1.8 2.2.0 2.2.3 2.3.0 2.3.7 2.4.0 2.4.4"
-for EXTNAME in postgis postgis_raster postgis_topology postgis_sfcgal postgis_tiger_geocoder ; do
+for EXTNAME in postgis postgis_raster postgis_topology postgis_sfcgal; do
 	cp extensions/$EXTNAME/sql/*  ${RELDIR}/${RELVERDIR}/share/extension
 
 	cp extensions/$EXTNAME/sql/$EXTNAME--ANY--${POSTGIS_MICRO_VER}.sql  ${RELDIR}/${RELVERDIR}/share/extension/$EXTNAME--${POSTGIS_MINOR_MAX_VER}--${POSTGIS_MICRO_VER}.sql

ci/winnie/regress_postgis.sh

@@ -135,7 +135,7 @@ value=${value//UPGRADEABLE_VERSIONS = /}
 #echo $value
 export UPGRADEABLE_VERSIONS=$value
 export WIN_RELEASED_VERSIONS="2.0.0 2.0.1 2.0.3 2.0.4 2.0.6 2.1.4 2.1.7 2.1.8 2.2.0 2.2.3 2.3.0 2.3.7 2.4.0 2.4.4"
-export extensions_to_install="postgis postgis_sfcgal postgis_tiger_geocoder"
+export extensions_to_install="postgis postgis_sfcgal"
 
 if [ $REGRESS_WITHOUT_TOPOLOGY == "0" ]; then
   extensions_to_install="${extensions_to_install} postgis_topology"
@@ -170,14 +170,6 @@ if [ "$UPGRADE_TEST" == "1" ]; then
   RUNTESTFLAGS='--extension' ${POSTGIS_SRC}/utils/check_all_upgrades.sh -s "${CURRENTVERSION}" --skip "unpackaged"
 fi
 
-#test tiger geocoder
-#  cd ${POSTGIS_SRC}
-#  cd extensions/postgis_tiger_geocoder
-#  make installcheck
-#  if [ "$?" != "0" ]; then
-#   exit $?
-#  fi
-#end extension
 fi
 
 if [ "$DUMP_RESTORE" == "1" ]; then

configure.ac

@@ -1422,23 +1422,6 @@ AC_SUBST([POSTGIS_BUILD_DATE])
 AC_SUBST([POSTGIS_SCRIPTS_VERSION])
 
 
-dnl ====================================
-dnl tiger_geocoder stuff
-dnl ====================================
-AC_ARG_WITH([tiger],
-    [AS_HELP_STRING([--without-tiger],
-                    [Disable the tiger geocoder extension])],
-    [], [])
-
-if test "x$with_tiger" != "xno"; then
-    TIGER="tiger"
-    AC_MSG_RESULT([TIGER: Tiger geocoder support requested])
-else
-    AC_MSG_RESULT([TIGER: Tiger geocoder support disabled])
-fi
-
-AC_SUBST([TIGER])
-
 CPPFLAGS="$PGSQL_CPPFLAGS $GEOS_CPPFLAGS $PROJ_CPPFLAGS $PROTOBUF_CPPFLAGS $XML2_CPPFLAGS $SFCGAL_CPPFLAGS $JSON_CPPFLAGS $CPPFLAGS"
 dnl AC_MSG_RESULT([CPPFLAGS: $CPPFLAGS])
 
@@ -1863,7 +1846,6 @@ AC_CONFIG_FILES([GNUmakefile
    extensions/Makefile
    extensions/postgis/Makefile
    extensions/postgis_topology/Makefile
-   extensions/postgis_tiger_geocoder/Makefile
    $ADDRESS_STANDARDIZER_MAKEFILE_LIST
    liblwgeom/Makefile
    liblwgeom/cunit/Makefile
@@ -1990,12 +1972,6 @@ else
     AC_MSG_RESULT([  Address Standardizer support:       disabled])
 fi
 
-if test "x$TIGER" = "xtiger"; then
-    AC_MSG_RESULT([  PostGIS Tiger Geocoder:                   enabled])
-else
-    AC_MSG_RESULT([  PostGIS Tiger Geocoder:                   disabled])
-fi
-
 AC_MSG_RESULT()
 AC_MSG_RESULT([ -------- Documentation Generation -------- ])
 AC_MSG_RESULT([  xsltproc:             ${XSLTPROC}])

doc/Makefile.in

@@ -163,7 +163,6 @@ XML_SOURCES = \
 	administration.xml \
 	database_tuning.xml \
 	extras_historytable.xml \
-	extras_tigergeocoder.xml \
 	extras_topology.xml \
 	extras.xml \
 	installation.xml \
@@ -538,8 +537,7 @@ comments-install:
 	if test -e postgis_comments.sql  -a \
 	        -e raster_comments.sql   -a \
 	        -e topology_comments.sql -a \
-	        -e sfcgal_comments.sql -a \
-	        -e tiger_geocoder_comments.sql; then \
+	        -e sfcgal_comments.sql ; then \
 	  $(MAKE) -f Makefile.comments install; \
 	fi
 else

doc/developer.md

@@ -100,7 +100,6 @@ run ALTER EXTENSION or SELECT postgis_extensions_upgrade() in a micro, so taking
   * For postgis_raster, raster/rt_pg/rtpg_legacy.c
   * postgis_topology extension has never had any deprecated functions so there is currently no legacy file for it.
     If there comes a need to deprecate C functions, then a file topology/postgis_topology_legacy.c will be created to store these.
-  * postgis_tiger_geocoder is all sql and plpgsql so it has no C backing functions.
 
 Why do we even bother replacing a good function with a function that throws an error?  Because of pg_upgrade tool used
 to upgrade PostgreSQL clusters. When pg_upgrade runs, it does not use the regular CREATE EXTENSION routine that loads function definitions from