chore: remove XML fallback parser and quick-xml dependency

Drop the lightweight XML fallback parser (liquibase_xml.rs, 3,463 lines)
and quick-xml dependency. Liquibase now requires a JRE with a two-tier
strategy: bridge JAR -> update-sql. Update docs, config, and tests to
reflect the two-tier approach. Fix bridge Dockerfile to skip tests that
need project-root fixtures.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: 2 people

.github/workflows/ci.yml

@@ -37,7 +37,7 @@ jobs:
         run: cargo fmt --check
 
       - name: Run Clippy
-        run: cargo clippy --all-targets -- -D warnings
+        run: cargo clippy --all-targets --features bridge-tests -- -D warnings
 
       - name: Check compilation
         run: cargo check

Cargo.lock

@@ -27,9 +27,6 @@ serde = { version = "1.0", features = ["derive"] }
 serde_json = "1.0"
 toml = "0.9.12"
 
-# XML parsing for Liquibase
-quick-xml = "0.39.0"
-
 # Error handling
 thiserror = "2.0"
 anyhow = "1.0"

Cargo.toml

@@ -216,16 +216,12 @@ strategy = "auto"
 
 For Liquibase, `paths` must point to the root changelog file (e.g. `migrations.xml`), not the directory containing it. The tool follows `<include>` elements from this entrypoint to discover changesets in order.
 
-The tool uses a three-tier approach for Liquibase XML processing:
+The tool uses a two-tier approach for Liquibase XML processing (JRE required):
 
 1. **Bridge JAR (preferred)** -- A small Java CLI that embeds Liquibase to extract exact changeset-to-SQL-to-line mappings. Download `liquibase-bridge.jar` from the [releases page](https://github.com/robert-sjoblom/pg-migration-lint/releases) and place it at the configured `bridge_jar_path`. Requires a JRE.
 
 2. **`liquibase update-sql` (secondary)** -- If the bridge JAR is unavailable but the Liquibase binary is on the PATH, the tool invokes `liquibase update-sql` for less structured but functional output.
 
-3. **XML fallback** -- If Java is unavailable, a lightweight built-in XML parser handles common change types (`<createTable>`, `<addColumn>`, `<createIndex>`, etc.). Exotic change types are skipped and the catalog is marked as potentially incomplete. Note: `<includeAll>` does not recurse into subdirectories in this mode — use the bridge JAR or `liquibase update-sql` for nested directory layouts.
-
-Set `strategy = "xml-only"` under `[liquibase]` to skip Java entirely.
-
 ## Configuration Reference
 
 Default config file: `pg-migration-lint.toml` in the working directory. Override with `--config <path>`.
@@ -279,10 +275,9 @@ bridge_jar_path = "tools/liquibase-bridge.jar"
 binary_path = "/usr/local/bin/liquibase"
 
 # Liquibase processing strategy.
-#   "auto" - tries bridge -> update-sql -> xml-fallback in order
+#   "auto" - tries bridge -> update-sql in order
 #   "bridge" - bridge JAR only
 #   "update-sql" - liquibase update-sql only
-#   "xml-fallback" - lightweight XML parser only
 # Default: "auto"
 strategy = "auto"
 

README.md

@@ -9,7 +9,7 @@ RUN mvn dependency:go-offline -q
 
 # Copy source and build the shaded JAR
 COPY src/ src/
-RUN mvn package -q
+RUN mvn package -q -DskipTests
 
 # Stage 2: Slim runtime image with just JRE and the JAR
 FROM eclipse-temurin:21-jre-alpine

bridge/Dockerfile

@@ -92,7 +92,7 @@ pub struct LiquibaseConfig {
     /// Path to liquibase properties file (passed as --defaults-file to liquibase CLI)
     pub properties_file: Option<PathBuf>,
 
-    /// Strategy: "auto", "bridge", "update-sql", "xml-fallback"
+    /// Strategy: "auto", "bridge", "update-sql"
     #[serde(default = "default_liquibase_strategy")]
     pub strategy: String,
 }
@@ -241,8 +241,8 @@ const SECTION_LIQUIBASE: &str = "\
   strategy = \"auto\"
     Liquibase sub-strategy: which method to use for SQL extraction.
     Type: string
-    Values: \"auto\", \"bridge\", \"update-sql\", \"xml-fallback\"
-    Default: \"auto\" (tries bridge -> update-sql -> xml-fallback)
+    Values: \"auto\", \"bridge\", \"update-sql\"
+    Default: \"auto\" (tries bridge -> update-sql)
 ";
 
 const SECTION_OUTPUT: &str = "\

src/config.rs

@@ -134,8 +134,7 @@ pub fn resolve_source_paths(units: &mut [RawMigrationUnit], base_dir: &Path) {
 /// Strategy selection:
 /// - `"bridge"`: Use bridge JAR only, fail if unavailable.
 /// - `"update-sql"`: Use `liquibase update-sql` only.
-/// - `"xml-fallback"`: Use the lightweight XML parser only.
-/// - `"auto"` (default): Try bridge -> update-sql -> xml-fallback in order.
+/// - `"auto"` (default): Try bridge -> update-sql in order.
 ///
 /// The `paths` parameter should contain paths to changelog files.
 pub fn load_liquibase(
@@ -147,15 +146,14 @@ pub fn load_liquibase(
     match strategy {
         "bridge" => load_with_bridge(config, paths),
         "update-sql" => load_with_updatesql(config, paths),
-        "xml-fallback" => load_with_xml_fallback(paths),
         "auto" => load_auto(config, paths),
         other => Err(LoadError::Config {
             message: format!("Unknown liquibase strategy: '{}'", other),
         }),
     }
 }
 
-/// Try bridge -> update-sql -> xml-fallback in order.
+/// Try bridge -> update-sql in order.
 fn load_auto(
     config: &LiquibaseConfig,
     paths: &[PathBuf],
@@ -172,12 +170,15 @@ fn load_auto(
     if config.binary_path.is_some() {
         match load_with_updatesql(config, paths) {
             Ok(units) => return Ok(units),
-            Err(_) => { /* fall through to XML fallback */ }
+            Err(_) => { /* fall through to error */ }
         }
     }
 
-    // Fall back to XML
-    load_with_xml_fallback(paths)
+    Err(LoadError::Config {
+        message: "Liquibase strategy 'auto' failed: neither bridge JAR nor update-sql succeeded. \
+                  Ensure a JRE is available and either bridge_jar_path or binary_path is configured."
+            .to_string(),
+    })
 }
 
 /// Load using the bridge JAR strategy.
@@ -233,19 +234,6 @@ fn load_with_updatesql(
     Ok(all_units)
 }
 
-/// Load using the lightweight XML fallback parser.
-fn load_with_xml_fallback(paths: &[PathBuf]) -> Result<Vec<RawMigrationUnit>, LoadError> {
-    let loader = super::liquibase_xml::XmlFallbackLoader;
-    let mut all_units = Vec::new();
-
-    for path in paths {
-        let units = loader.load(path)?;
-        all_units.extend(units);
-    }
-
-    Ok(all_units)
-}
-
 #[cfg(test)]
 mod tests {
     use super::*;