Skip to content

Commit 2e749d1

Browse files
committed
fix: HasSubscriber should be true when any subscriber exists
1 parent bbf4140 commit 2e749d1

2 files changed

Lines changed: 10 additions & 5 deletions

File tree

manager_internal.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,9 @@ func (m *manager) HasSubscriber(events ...Event) bool {
5454
if len(events) == 0 {
5555
return len(m.subscribers) != 0
5656
}
57+
if m.subscribers[anyType] != nil {
58+
return true
59+
}
5760
for _, event := range events {
5861
if m.subscribers[typeOf(event)] != nil {
5962
return true

manager_test.go

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,13 @@ func TestPriorityAndCorrectType(t *testing.T) {
2020
m := New()
2121
require.False(t, m.HasSubscriber(&myEvent{}))
2222

23+
var calledAny int
24+
m.Subscribe(any(nil), 10, func(e Event) {
25+
calledAny++
26+
})
27+
28+
require.True(t, m.HasSubscriber(&myEvent{}))
29+
2330
m.Subscribe(typeOf(&myEvent{}), -1, func(e Event) {
2431
ev := e.(*myEvent)
2532
ev.s += "c"
@@ -42,11 +49,6 @@ func TestPriorityAndCorrectType(t *testing.T) {
4249
noPtr = true
4350
})
4451

45-
var calledAny int
46-
m.Subscribe(any(nil), 10, func(e Event) {
47-
calledAny++
48-
})
49-
5052
e := &myEvent{s: "_"}
5153
m.Fire(e)
5254
require.False(t, noPtr)

0 commit comments

Comments
 (0)