[php8.2][compatability] Changes to support php 8.2

- Remove depricated utf8_decode function call
- Explicit cast to int for result of division
- returned result from differential.query appears to have changed to
array's and not keyed objects. Patch needs to search the array

Author: Daniel Kozlowski

src/differential/ArcanistDifferentialDependencyGraph.php

@@ -66,6 +66,11 @@ private function getCommitHashFromDict($dict) {
       $key = null;
     }
 
+    foreach ($hashes as $hash) {
+      if ($hash[0] == $key) {
+        return $hash[1];
+      }
+    }
     return idx($hashes, $key);
   }
 

src/land/engine/ArcanistPhlqLandEngine.php

@@ -213,7 +213,8 @@ function execute() {
         $timestamp_diff = $commit_unix_date - $diff_date_modified;
         # allow for small theshold before tripping the warning
         if ($timestamp_diff > 5) {
-          $pretty_diff = sprintf('%02dh %02dm %02ds', ($timestamp_diff/3600),($timestamp_diff/60%60), $timestamp_diff%60);
+          $pretty_diff = sprintf('%02dh %02dm %02ds',$timestamp_diff/3600,(int)($timestamp_diff/60) % 60, $timestamp_diff%60.0);
+
           echo tsprintf(
             "\n%!\n%W\n",
             pht('POTENTIAL UNPUSHED LOCAL CHANGES FOR D%s', $revision_id),

src/utils/utf8.php

@@ -288,9 +288,11 @@ function phutil_is_utf8_slowly($string, $only_bmp = false) {
  * @return int   The character length of the string.
  */
 function phutil_utf8_strlen($string) {
-  if (function_exists('utf8_decode')) {
-    return strlen(utf8_decode($string));
-  }
+  //utf8_decode is depricated as of php 8.2
+  //https://www.php.net/releases/8.2/en.php#deprecations_and_bc_breaks
+  //if (function_exists('utf8_decode')) {
+  // return strlen(utf8_decode($string));
+  //}
   return count(phutil_utf8v($string));
 }