Skip to content

Commit 611de4b

Browse files
Remove CI matrix again
1 parent 02b852e commit 611de4b

File tree

2 files changed

+2
-11
lines changed

2 files changed

+2
-11
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,18 +5,14 @@ on:
55
jobs:
66
test-suite:
77
name: PHPStan, PHPcs & Testsuite
8-
strategy:
9-
matrix:
10-
operating-system: ['ubuntu-latest']
11-
php-versions: [ '8.1', '8.2' ]
128
runs-on: ubuntu-latest
139

1410
steps:
1511
# https://github.com/marketplace/actions/setup-php-action
16-
- name: Setup PHP ${{ matrix.php-versions }} with Xdebug 3.x
12+
- name: Setup PHP 8.1 with Xdebug 3.x
1713
uses: shivammathur/setup-php@v2
1814
with:
19-
php-version: ${{ matrix.php-versions }}
15+
php-version: '8.1'
2016
coverage: xdebug
2117

2218
# https://github.com/marketplace/actions/checkout
@@ -37,7 +33,6 @@ jobs:
3733

3834
# https://github.com/marketplace/actions/codecov
3935
- name: Send test coverage to codecov.io
40-
if: matrix.php-versions == '8.1'
4136
uses: codecov/codecov-action@v3
4237
with:
4338
files: clover.xml,!tests/clover.xml,!tests/clover-invalid.xml

src/Subscriber/Application/ApplicationFinishedSubscriber.php

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,16 +45,12 @@ public function notify(Finished $event): void
4545
$reader = new \XMLReader();
4646
$reader->open($absolutePathToCloverXml);
4747
while ($reader->read()) {
48-
// Ignore this line until https://github.com/phpstan/phpstan/issues/8629 lands.
49-
/** @@phpstan-ignore-next-line */
5048
if ($this->minCoverageRules->hasTotalRule() && \XMLReader::ELEMENT == $reader->nodeType && 'metrics' == $reader->name && 2 === $reader->depth) {
5149
/** @var \SimpleXMLElement $node */
5250
$node = simplexml_load_string($reader->readOuterXml());
5351
$metricTotal = CoverageMetric::fromCloverXmlNode($node, MinCoverageRules::TOTAL);
5452
continue;
5553
}
56-
// Ignore this line until https://github.com/phpstan/phpstan/issues/8629 lands.
57-
/** @@phpstan-ignore-next-line */
5854
if ($this->minCoverageRules->hasOtherRulesThanTotalRule() && \XMLReader::ELEMENT == $reader->nodeType && 'class' == $reader->name && 3 === $reader->depth) {
5955
/** @var \SimpleXMLElement $node */
6056
$node = simplexml_load_string($reader->readInnerXml());

0 commit comments

Comments
 (0)