Render execution time the proper way

Author: robiningelbrecht

src/ConsoleOutput.php

@@ -14,7 +14,7 @@
 use Symfony\Component\Console\Helper\TableStyle;
 use Symfony\Component\Console\Output\OutputInterface;
 
-class ConsoleOutput
+final class ConsoleOutput
 {
     public function __construct(
         private readonly OutputInterface $output,
@@ -38,6 +38,11 @@ public function __construct(
         );
     }
 
+    public static function create(): self
+    {
+        return new self(new \Symfony\Component\Console\Output\ConsoleOutput());
+    }
+
     /**
      * @param \RobinIngelbrecht\PHPUnitCoverageTools\MinCoverage\MinCoverageResult[] $results
      */

src/Subscriber/Application/ApplicationFinishedSubscriber.php

@@ -14,7 +14,8 @@
 use RobinIngelbrecht\PHPUnitCoverageTools\MinCoverage\MinCoverageRule;
 use RobinIngelbrecht\PHPUnitCoverageTools\MinCoverage\MinCoverageRules;
 use RobinIngelbrecht\PHPUnitCoverageTools\MinCoverage\ResultStatus;
-use SebastianBergmann\Timer\Timer;
+use RobinIngelbrecht\PHPUnitCoverageTools\Timer\SystemTimer;
+use RobinIngelbrecht\PHPUnitCoverageTools\Timer\Timer;
 use Symfony\Component\Console\Helper\FormatterHelper;
 
 final class ApplicationFinishedSubscriber extends FormatterHelper implements FinishedSubscriber
@@ -25,13 +26,13 @@ public function __construct(
         private readonly bool $cleanUpCloverXml,
         private readonly Exitter $exitter,
         private readonly ConsoleOutput $consoleOutput,
+        private readonly Timer $timer,
     ) {
     }
 
     public function notify(Finished $event): void
     {
-        $timer = new Timer();
-        $timer->start();
+        $this->timer->start();
         /** @var string $reflectionFileName */
         $reflectionFileName = (new \ReflectionClass(ClassLoader::class))->getFileName();
         $absolutePathToCloverXml = dirname($reflectionFileName, 3).'/'.$this->relativePathToCloverXml;
@@ -51,15 +52,21 @@ public function notify(Finished $event): void
             if ($this->minCoverageRules->hasTotalRule() && \XMLReader::ELEMENT == $reader->nodeType && 'metrics' == $reader->name && 2 === $reader->depth) {
                 /** @var \SimpleXMLElement $node */
                 $node = simplexml_load_string($reader->readOuterXml());
-                $metricTotal = CoverageMetric::fromCloverXmlNode($node, MinCoverageRule::TOTAL);
+                $metricTotal = CoverageMetric::fromCloverXmlNode(
+                    node: $node,
+                    forClass: MinCoverageRule::TOTAL
+                );
                 continue;
             }
             if ($this->minCoverageRules->hasOtherRulesThanTotalRule() && \XMLReader::ELEMENT == $reader->nodeType && 'class' == $reader->name && 3 === $reader->depth) {
                 /** @var \SimpleXMLElement $node */
                 $node = simplexml_load_string($reader->readInnerXml());
                 /** @var string $className */
                 $className = $reader->getAttribute('name');
-                $metrics[] = CoverageMetric::fromCloverXmlNode($node, $className);
+                $metrics[] = CoverageMetric::fromCloverXmlNode(
+                    node: $node,
+                    forClass: $className
+                );
             }
         }
         $reader->close();
@@ -78,7 +85,10 @@ public function notify(Finished $event): void
             metricTotal: $metricTotal,
         );
 
-        $this->consoleOutput->print($results, $timer->stop());
+        $this->consoleOutput->print(
+            results: $results,
+            duration: $this->timer->stop()
+        );
 
         $needsExit = !empty(array_filter(
             $results,
@@ -138,7 +148,8 @@ public static function fromConfigurationAndParameters(
             minCoverageRules: $rules,
             cleanUpCloverXml: $cleanUpCloverXml,
             exitter: new Exitter(),
-            consoleOutput: new ConsoleOutput(new \Symfony\Component\Console\Output\ConsoleOutput()),
+            consoleOutput: ConsoleOutput::create(),
+            timer: SystemTimer::create(),
         );
     }
 }

src/Timer/SystemTimer.php

@@ -0,0 +1,29 @@
+<?php
+
+namespace RobinIngelbrecht\PHPUnitCoverageTools\Timer;
+
+use SebastianBergmann\Timer\Duration;
+use SebastianBergmann\Timer\Timer as PhpUnitTimer;
+
+final class SystemTimer implements Timer
+{
+    private function __construct(
+        private readonly PhpUnitTimer $timer,
+    ) {
+    }
+
+    public function start(): void
+    {
+        $this->timer->start();
+    }
+
+    public function stop(): Duration
+    {
+        return $this->timer->stop();
+    }
+
+    public static function create(): self
+    {
+        return new self(new PhpUnitTimer());
+    }
+}

src/Timer/Timer.php

@@ -0,0 +1,12 @@
+<?php
+
+namespace RobinIngelbrecht\PHPUnitCoverageTools\Timer;
+
+use SebastianBergmann\Timer\Duration;
+
+interface Timer
+{
+    public function start(): void;
+
+    public function stop(): Duration;
+}

tests/PausedTimer.php

@@ -0,0 +1,28 @@
+<?php
+
+namespace Tests;
+
+use RobinIngelbrecht\PHPUnitCoverageTools\Timer\Timer;
+use SebastianBergmann\Timer\Duration;
+
+final class PausedTimer implements Timer
+{
+    private function __construct(
+        private readonly Duration $duration
+    ) {
+    }
+
+    public static function withDuration(Duration $duration): self
+    {
+        return new self($duration);
+    }
+
+    public function start(): void
+    {
+    }
+
+    public function stop(): Duration
+    {
+        return $this->duration;
+    }
+}