Address delayed mask creation review comments

Author: tstanczyk95

src/trackers/core/mcbyte/mask_manager.py

@@ -84,6 +84,8 @@ def __init__(
     ) -> None:
         self.mask_generator = mask_generator
         self.mask_propagator = mask_propagator
+        if not 0.0 <= mask_creation_bbox_overlap_threshold <= 1.0:
+            raise ValueError("mask_creation_bbox_overlap_threshold must be between 0 and 1.")
         self.mask_creation_bbox_overlap_threshold = mask_creation_bbox_overlap_threshold
         self._initialized = False
         self._pending_tracklet_ids: set[int] = set()
@@ -147,17 +149,17 @@ def get_updated_masks(
         if previous_frame is None:
             return None
 
+        new_tracklets = [] if new_tracklets is None else new_tracklets
+        removed_tracklet_ids = [] if removed_tracklet_ids is None else removed_tracklet_ids
+
+        self._remove_pending_tracklets(removed_tracklet_ids)
+
         if not self._initialized and len(previous_tracklets) == 0:
             return None
 
         if self.mask_propagator is None:
             return None
 
-        new_tracklets = [] if new_tracklets is None else new_tracklets
-        removed_tracklet_ids = [] if removed_tracklet_ids is None else removed_tracklet_ids
-
-        self._remove_pending_tracklets(removed_tracklet_ids)
-
         if not self._initialized:
             candidates = previous_tracklets
             clean_tracklets = self._select_clean_tracklets(candidates, previous_tracklets)

tests/core/test_mcbyte_mask_manager.py

@@ -432,3 +432,23 @@ def test_mask_manager_removes_terminated_tracklet_from_pending_pool() -> None:
     assert output is not None
     assert output.tracklet_mask_dict == {2: 0}
     assert manager._pending_tracklet_ids == set()
+
+
+def test_mask_manager_removes_terminated_tracklet_from_pending_pool_before_initialization() -> None:
+    manager = MaskManager(
+        mask_generator=DummyBoxMaskGenerator(),
+        mask_propagator=DummyIdentityMaskPropagator(),
+        mask_creation_bbox_overlap_threshold=0.6,
+    )
+
+    manager._pending_tracklet_ids = {1}
+
+    output = manager.get_updated_masks(
+        frame=_make_frame(),
+        previous_frame=_make_frame(),
+        previous_tracklets=[],
+        removed_tracklet_ids=[1],
+    )
+
+    assert output is None
+    assert manager._pending_tracklet_ids == set()