refactor: extract shared column slice, named constant, and package-level styles

- Extract toggleableColumns var to replace 3 duplicate column order slices
- Replace -1 magic number with colOptionBorders named constant
- Remove redundant colOptionsFrom field (always viewQueue)
- Hoist errorStyle/flashStyle/updateStyle to package-level vars,
  eliminating per-render allocations across queue, review, and tasks views

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: mariusvniekerk

cmd/roborev/tui/handlers_queue.go

@@ -161,7 +161,7 @@ func (m model) handleColumnOptionsKey() (tea.Model, tea.Cmd) {
 	}
 	// Build option list from toggleable columns
 	var opts []columnOption
-	for _, col := range []int{colRef, colBranch, colRepo, colAgent, colStatus, colQueued, colElapsed, colPF, colHandled} {
+	for _, col := range toggleableColumns {
 		opts = append(opts, columnOption{
 			id:      col,
 			name:    columnDisplayName(col),
@@ -170,21 +170,20 @@ func (m model) handleColumnOptionsKey() (tea.Model, tea.Cmd) {
 	}
 	// Add borders toggle
 	opts = append(opts, columnOption{
-		id:      -1,
+		id:      colOptionBorders,
 		name:    "Column borders",
 		enabled: m.colBordersOn,
 	})
 	m.colOptionsList = opts
 	m.colOptionsIdx = 0
-	m.colOptionsFrom = m.currentView
 	m.currentView = viewColumnOptions
 	return m, nil
 }
 
 func (m model) handleColumnOptionsInput(msg tea.KeyMsg) (tea.Model, tea.Cmd) {
 	switch msg.String() {
 	case "esc":
-		m.currentView = m.colOptionsFrom
+		m.currentView = viewQueue
 		return m, nil
 	case "ctrl+c":
 		return m, tea.Quit
@@ -202,7 +201,7 @@ func (m model) handleColumnOptionsInput(msg tea.KeyMsg) (tea.Model, tea.Cmd) {
 		if m.colOptionsIdx >= 0 && m.colOptionsIdx < len(m.colOptionsList) {
 			opt := &m.colOptionsList[m.colOptionsIdx]
 			opt.enabled = !opt.enabled
-			if opt.id == -1 {
+			if opt.id == colOptionBorders {
 				// Borders toggle
 				m.colBordersOn = opt.enabled
 			} else {

cmd/roborev/tui/render_queue.go

@@ -127,7 +127,6 @@ func (m model) renderQueueView() string {
 	b.WriteString(titleStyle.Render(title.String()))
 	// In compact mode, show version mismatch inline since the status area is hidden
 	if compact && m.versionMismatch {
-		errorStyle := lipgloss.NewStyle().Foreground(lipgloss.AdaptiveColor{Light: "124", Dark: "196"}).Bold(true)
 		b.WriteString(" ")
 		b.WriteString(errorStyle.Render(fmt.Sprintf("MISMATCH: TUI %s != Daemon %s", version.Version, m.daemonVersion)))
 	}
@@ -177,7 +176,6 @@ func (m model) renderQueueView() string {
 
 		// Update notification on line 3 (above the table)
 		if m.updateAvailable != "" {
-			updateStyle := lipgloss.NewStyle().Foreground(lipgloss.AdaptiveColor{Light: "136", Dark: "226"}).Bold(true)
 			var updateMsg string
 			if m.updateIsDevBuild {
 				updateMsg = fmt.Sprintf("Dev build - latest release: %s - run 'roborev update --force'", m.updateAvailable)
@@ -533,10 +531,8 @@ func (m model) renderQueueView() string {
 		// Status line: flash message (temporary)
 		// Version mismatch takes priority over flash messages (it's persistent and important)
 		if m.versionMismatch {
-			errorStyle := lipgloss.NewStyle().Foreground(lipgloss.AdaptiveColor{Light: "124", Dark: "196"}).Bold(true) // Red
 			b.WriteString(errorStyle.Render(fmt.Sprintf("VERSION MISMATCH: TUI %s != Daemon %s - restart TUI or daemon", version.Version, m.daemonVersion)))
 		} else if m.flashMessage != "" && time.Now().Before(m.flashExpiresAt) && m.flashView == viewQueue {
-			flashStyle := lipgloss.NewStyle().Foreground(lipgloss.AdaptiveColor{Light: "28", Dark: "46"}) // Green
 			b.WriteString(flashStyle.Render(m.flashMessage))
 		}
 		b.WriteString("\x1b[K\n") // Clear to end of line
@@ -641,6 +637,10 @@ func stripControlChars(s string) string {
 	return b.String()
 }
 
+// toggleableColumns is the ordered list of columns the user can show/hide.
+// colSel and colJobID are always visible and not included here.
+var toggleableColumns = []int{colRef, colBranch, colRepo, colAgent, colStatus, colQueued, colElapsed, colPF, colHandled}
+
 // columnNames maps column constants to display names.
 var columnNames = map[int]string{
 	colRef:     "Ref",
@@ -694,7 +694,7 @@ func parseHiddenColumns(names []string) map[int]bool {
 func hiddenColumnsToNames(hidden map[int]bool) []string {
 	var names []string
 	// Maintain stable order
-	for _, col := range []int{colRef, colBranch, colRepo, colAgent, colStatus, colQueued, colElapsed, colPF, colHandled} {
+	for _, col := range toggleableColumns {
 		if hidden[col] {
 			names = append(names, columnConfigNames[col])
 		}
@@ -706,7 +706,7 @@ func hiddenColumnsToNames(hidden map[int]bool) []string {
 // always including colSel and colJobID, plus any non-hidden toggleable columns.
 func (m model) visibleColumns() []int {
 	cols := []int{colSel, colJobID}
-	for _, c := range []int{colRef, colBranch, colRepo, colAgent, colStatus, colQueued, colElapsed, colPF, colHandled} {
+	for _, c := range toggleableColumns {
 		if !m.hiddenColumns[c] {
 			cols = append(cols, c)
 		}
@@ -749,7 +749,7 @@ func (m model) renderColumnOptionsView() string {
 			line = selectedStyle.Render(line)
 		}
 		// Separator before "Column borders" item
-		if opt.id == -1 && i > 0 {
+		if opt.id == colOptionBorders && i > 0 {
 			b.WriteString("\n")
 		}
 		b.WriteString(prefix)

cmd/roborev/tui/render_review.go

@@ -236,10 +236,8 @@ func (m model) renderReviewView() string {
 
 	// Status line: version mismatch (persistent) takes priority, then flash message, then scroll indicator
 	if m.versionMismatch {
-		errorStyle := lipgloss.NewStyle().Foreground(lipgloss.AdaptiveColor{Light: "124", Dark: "196"}).Bold(true) // Red
 		b.WriteString(errorStyle.Render(fmt.Sprintf("VERSION MISMATCH: TUI %s != Daemon %s - restart TUI or daemon", version.Version, m.daemonVersion)))
 	} else if m.flashMessage != "" && time.Now().Before(m.flashExpiresAt) && m.flashView == viewReview {
-		flashStyle := lipgloss.NewStyle().Foreground(lipgloss.AdaptiveColor{Light: "28", Dark: "46"}) // Green
 		b.WriteString(flashStyle.Render(m.flashMessage))
 	} else if len(lines) > visibleLines {
 		scrollInfo := fmt.Sprintf("[%d-%d of %d lines]", start+1, end, len(lines))

cmd/roborev/tui/render_tasks.go

@@ -151,7 +151,6 @@ func (m model) renderTasksView() string {
 
 	// Flash message
 	if m.flashMessage != "" && time.Now().Before(m.flashExpiresAt) && m.flashView == viewTasks {
-		flashStyle := lipgloss.NewStyle().Foreground(lipgloss.AdaptiveColor{Light: "28", Dark: "46"})
 		b.WriteString(flashStyle.Render(m.flashMessage))
 	}
 	b.WriteString("\x1b[K\n")

cmd/roborev/tui/tui.go

@@ -59,6 +59,15 @@ var (
 			Foreground(lipgloss.AdaptiveColor{Light: "242", Dark: "246"}) // Gray (matches status/scroll text)
 	helpDescStyle = lipgloss.NewStyle().
 			Foreground(lipgloss.AdaptiveColor{Light: "248", Dark: "240"}) // Dimmer gray for descriptions
+
+	errorStyle = lipgloss.NewStyle().
+			Foreground(lipgloss.AdaptiveColor{Light: "124", Dark: "196"}).Bold(true) // Red
+
+	flashStyle = lipgloss.NewStyle().
+			Foreground(lipgloss.AdaptiveColor{Light: "28", Dark: "46"}) // Green
+
+	updateStyle = lipgloss.NewStyle().
+			Foreground(lipgloss.AdaptiveColor{Light: "136", Dark: "226"}).Bold(true) // Yellow/Gold
 )
 
 // reflowHelpRows redistributes items across rows so that when rendered
@@ -379,7 +388,6 @@ type model struct {
 	// Column options modal
 	colOptionsIdx  int            // Cursor in modal
 	colOptionsList []columnOption // Items in modal (columns + borders toggle)
-	colOptionsFrom viewKind       // Return view
 	colBordersOn   bool           // Column borders enabled
 	hiddenColumns  map[int]bool   // Set of hidden column IDs
 }

cmd/roborev/tui/types.go

@@ -73,10 +73,13 @@ type logLine struct {
 	text string
 }
 
+// colOptionBorders is the sentinel ID for the borders toggle in the column options modal.
+const colOptionBorders = -1
+
 // columnOption represents an item in the column options modal.
-// id is the column constant (colRef..colHandled) or -1 for the borders toggle.
+// id is a column constant (colRef..colHandled) or colOptionBorders.
 type columnOption struct {
-	id      int    // column constant or -1 for borders toggle
+	id      int    // column constant or colOptionBorders
 	name    string // display label
 	enabled bool   // visible/on
 }