fix: make --all-branches imply --unaddressed (#345)

## Summary
- `roborev fix --all-branches` now implies `--unaddressed` instead of
erroring, removing an unnecessary sharp edge
- Validation order fixed so `--all-branches --branch main` correctly
returns the mutual-exclusion error
- Added positive test for `--all-branches` alone and updated existing
flag-validation tests

Closes #344

## Test plan
- [x] `TestFixCmdFlagValidation` passes (all error cases)
- [x] `TestFixAllBranchesImpliesUnaddressed` passes (positive case with
mock daemon)
- [x] Full `TestFix*` suite passes

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Author: wesm

cmd/roborev/fix.go

@@ -55,20 +55,20 @@ Examples:
   roborev fix --agent claude-code 123    # Use a specific agent
   roborev fix --unaddressed              # Fix all unaddressed on current branch
   roborev fix --unaddressed --branch main
-  roborev fix --unaddressed --all-branches
+  roborev fix --all-branches              # Fix all unaddressed across all branches
   roborev fix --batch 123 124 125        # Batch multiple jobs into one prompt
   roborev fix --batch                    # Batch all unaddressed on current branch
   roborev fix --list                     # List unaddressed jobs without fixing
   roborev fix --unaddressed --list       # Same as above
 `,
 		Args: cobra.ArbitraryArgs,
 		RunE: func(cmd *cobra.Command, args []string) error {
+			if allBranches && !unaddressed && !batch && !list {
+				unaddressed = true
+			}
 			if branch != "" && !unaddressed && !batch && !list {
 				return fmt.Errorf("--branch requires --unaddressed, --batch, or --list")
 			}
-			if allBranches && !unaddressed && !batch && !list {
-				return fmt.Errorf("--all-branches requires --unaddressed, --batch, or --list")
-			}
 			if allBranches && branch != "" {
 				return fmt.Errorf("--all-branches and --branch are mutually exclusive")
 			}
@@ -179,7 +179,7 @@ Examples:
 	cmd.Flags().BoolVarP(&quiet, "quiet", "q", false, "suppress progress output")
 	cmd.Flags().BoolVar(&unaddressed, "unaddressed", false, "fix all unaddressed completed jobs for the current repo")
 	cmd.Flags().StringVar(&branch, "branch", "", "filter by branch (default: current branch; requires --unaddressed)")
-	cmd.Flags().BoolVar(&allBranches, "all-branches", false, "include unaddressed jobs from all branches (requires --unaddressed)")
+	cmd.Flags().BoolVar(&allBranches, "all-branches", false, "include unaddressed jobs from all branches (implies --unaddressed)")
 	cmd.Flags().BoolVar(&newestFirst, "newest-first", false, "process jobs newest first instead of oldest first (requires --unaddressed)")
 	cmd.Flags().BoolVar(&batch, "batch", false, "concatenate reviews into a single prompt for the agent")
 	cmd.Flags().BoolVar(&list, "list", false, "list unaddressed jobs without fixing (implies --unaddressed)")

cmd/roborev/fix_test.go

@@ -308,9 +308,9 @@ func TestFixCmdFlagValidation(t *testing.T) {
 			wantErr: "--branch requires --unaddressed",
 		},
 		{
-			name:    "--all-branches without --unaddressed",
-			args:    []string{"--all-branches"},
-			wantErr: "--all-branches requires --unaddressed",
+			name:    "--all-branches with positional args",
+			args:    []string{"--all-branches", "123"},
+			wantErr: "--unaddressed cannot be used with positional job IDs",
 		},
 		{
 			name:    "--unaddressed with positional args",
@@ -323,8 +323,8 @@ func TestFixCmdFlagValidation(t *testing.T) {
 			wantErr: "--newest-first requires --unaddressed",
 		},
 		{
-			name:    "--all-branches with --branch",
-			args:    []string{"--unaddressed", "--all-branches", "--branch", "main"},
+			name:    "--all-branches with --branch (no explicit --unaddressed)",
+			args:    []string{"--all-branches", "--branch", "main"},
 			wantErr: "--all-branches and --branch are mutually exclusive",
 		},
 	}
@@ -374,6 +374,27 @@ func TestFixNoArgsDefaultsToUnaddressed(t *testing.T) {
 	}
 }
 
+func TestFixAllBranchesImpliesUnaddressed(t *testing.T) {
+	// --all-branches alone should imply --unaddressed and pass
+	// validation, routing through unaddressed discovery.
+	_, cleanup := setupMockDaemon(t, http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		json.NewEncoder(w).Encode(map[string]any{
+			"jobs":     []any{},
+			"has_more": false,
+		})
+	}))
+	defer cleanup()
+
+	cmd := fixCmd()
+	cmd.SilenceUsage = true
+	cmd.SilenceErrors = true
+	cmd.SetArgs([]string{"--all-branches"})
+	err := cmd.Execute()
+	if err != nil {
+		t.Errorf("--all-branches should not fail validation: %v", err)
+	}
+}
+
 func TestRunFixUnaddressed(t *testing.T) {
 	repo := createTestRepo(t, map[string]string{"f.txt": "x"})