fix: defer column options save to modal close and report config errors

Avoid race condition from concurrent saves on each keypress by deferring
saveColumnOptions() to when the modal closes (esc). Report config
load/save failures via flash message instead of silently swallowing them.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: mariusvniekerk

cmd/roborev/tui/handlers_queue.go

@@ -199,6 +199,10 @@ func (m model) handleColumnOptionsInput(msg tea.KeyMsg) (tea.Model, tea.Cmd) {
 	switch msg.String() {
 	case "esc":
 		m.currentView = m.colOptionsReturnView
+		if m.colOptionsDirty {
+			m.colOptionsDirty = false
+			return m, m.saveColumnOptions()
+		}
 		return m, nil
 	case "ctrl+c":
 		return m, tea.Quit
@@ -219,7 +223,7 @@ func (m model) handleColumnOptionsInput(msg tea.KeyMsg) (tea.Model, tea.Cmd) {
 				m.colOptionsList[m.colOptionsIdx+1], m.colOptionsList[m.colOptionsIdx]
 			m.colOptionsIdx++
 			m.syncColumnOrderFromOptions()
-			return m, m.saveColumnOptions()
+			m.colOptionsDirty = true
 		}
 		return m, nil
 	case "k":
@@ -229,7 +233,7 @@ func (m model) handleColumnOptionsInput(msg tea.KeyMsg) (tea.Model, tea.Cmd) {
 				m.colOptionsList[m.colOptionsIdx-1], m.colOptionsList[m.colOptionsIdx]
 			m.colOptionsIdx--
 			m.syncColumnOrderFromOptions()
-			return m, m.saveColumnOptions()
+			m.colOptionsDirty = true
 		}
 		return m, nil
 	case " ", "enter":
@@ -238,6 +242,7 @@ func (m model) handleColumnOptionsInput(msg tea.KeyMsg) (tea.Model, tea.Cmd) {
 			if opt.id == colOptionBorders {
 				opt.enabled = !opt.enabled
 				m.colBordersOn = opt.enabled
+				m.colOptionsDirty = true
 			} else if m.colOptionsReturnView == viewTasks {
 				// Tasks view: no visibility toggle (all columns always shown)
 				return m, nil
@@ -251,8 +256,8 @@ func (m model) handleColumnOptionsInput(msg tea.KeyMsg) (tea.Model, tea.Cmd) {
 					}
 					m.hiddenColumns[opt.id] = true
 				}
+				m.colOptionsDirty = true
 			}
-			return m, m.saveColumnOptions()
 		}
 		return m, nil
 	}

cmd/roborev/tui/render_queue.go

@@ -777,13 +777,15 @@ func (m model) saveColumnOptions() tea.Cmd {
 	return func() tea.Msg {
 		cfg, err := config.LoadGlobal()
 		if err != nil {
-			return nil
+			return configSaveErrMsg{err: fmt.Errorf("load config: %w", err)}
 		}
 		cfg.HiddenColumns = hidden
 		cfg.ColumnBorders = borders
 		cfg.ColumnOrder = colOrd
 		cfg.TaskColumnOrder = taskColOrd
-		config.SaveGlobal(cfg)
+		if err := config.SaveGlobal(cfg); err != nil {
+			return configSaveErrMsg{err: fmt.Errorf("save config: %w", err)}
+		}
 		return nil
 	}
 }

cmd/roborev/tui/tui.go

@@ -388,6 +388,7 @@ type model struct {
 	// Column options modal
 	colOptionsIdx        int            // Cursor in modal
 	colOptionsList       []columnOption // Items in modal (columns + borders toggle)
+	colOptionsDirty      bool           // True if options changed since modal opened
 	colBordersOn         bool           // Column borders enabled
 	hiddenColumns        map[int]bool   // Set of hidden column IDs
 	columnOrder          []int          // Ordered toggleable queue columns
@@ -659,6 +660,9 @@ func (m model) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
 		return m.handlePatchResultMsg(msg)
 	case applyPatchResultMsg:
 		return m.handleApplyPatchResultMsg(msg)
+	case configSaveErrMsg:
+		m.setFlash("Config save failed: "+msg.err.Error(), 5*time.Second, m.currentView)
+		return m, nil
 	}
 	return m, nil
 }

cmd/roborev/tui/types.go

@@ -148,6 +148,7 @@ type rerunResultMsg struct {
 	err           error
 }
 type errMsg error
+type configSaveErrMsg struct{ err error }
 type jobsErrMsg struct {
 	err error
 	seq int // fetch sequence number for staleness check