Fix queue cursor behavior when hide-addressed active and addressing review from review screen (#52)

The cursor was getting "swallowed" if that makes sense. Also adds an
AGENTS.md file to help Codex work better.

---------

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>

Author: wesm

AGENTS.md

@@ -0,0 +1,52 @@
+# AGENTS.md
+
+## Purpose
+
+This repo hosts roborev, a local daemon + CLI for AI-assisted code review. Use this guide to
+stay aligned with project conventions when reviewing code or addressing feedback.
+
+## Project Orientation
+
+- CLI entry point: `cmd/roborev/main.go`
+- Daemon entry point: `cmd/roborevd/main.go`
+- HTTP API: `internal/daemon/server.go`
+- Worker pool + job processing: `internal/daemon/worker.go`
+- SQLite storage: `internal/storage/`
+- Agent interface + implementations: `internal/agent/`
+- Config loading/agent resolution: `internal/config/config.go`
+
+Runtime:
+- Daemon listens on `127.0.0.1:7373` (auto-increment if busy)
+- Runtime info at `~/.roborev/daemon.json`
+- DB at `~/.roborev/reviews.db` (WAL mode)
+- Data dir override via `ROBOREV_DATA_DIR`
+
+## Development Preferences
+
+- Keep changes simple; avoid over-engineering.
+- Prefer Go stdlib over new dependencies.
+- No emojis in code or output (commit messages are fine).
+- Never amend commits; fixes should be new commits.
+- Never push/pull or change branches unless explicitly asked.
+- Release builds use `CGO_ENABLED=0` (SQLite requires CGO locally).
+
+## Testing
+
+- Tests should be fast and isolated; use `t.TempDir()`.
+- Use the `agent = "test"` path to avoid calling real AI agents.
+- Suggested commands: `go test ./...`, `go build ./...`, `make install`.
+
+## Review/Refine Guidance
+
+When reviewing or fixing issues:
+- Focus on correctness, concurrency safety, and error handling in daemon/worker code.
+- For storage changes, keep migrations minimal and validate schema/queries.
+- For API changes, preserve HTTP/JSON conventions (no gRPC).
+- When addressing review feedback, update tests if behavior changes.
+- If diffs are large or truncated, inspect with `git show <sha>`.
+
+## Config + Runtime Notes
+
+- Config priority: CLI flags → `.roborev.toml` → `~/.roborev/config.toml`.
+- Reasoning defaults: reviews = thorough, refine = standard.
+- `roborev refine` runs agents without sandboxing; only use on trusted code.

cmd/roborev/tui.go

@@ -686,6 +686,25 @@ func (m *tuiModel) findPrevViewableJob() int {
 	return -1
 }
 
+// normalizeSelectionIfHidden adjusts selectedIdx/selectedJobID if the current
+// selection is hidden (e.g., marked addressed with hideAddressed filter active).
+// Call this when returning to queue view from review view.
+func (m *tuiModel) normalizeSelectionIfHidden() {
+	if m.selectedIdx >= 0 && m.selectedIdx < len(m.jobs) && !m.isJobVisible(m.jobs[m.selectedIdx]) {
+		nextIdx := m.findNextVisibleJob(m.selectedIdx)
+		if nextIdx < 0 {
+			nextIdx = m.findPrevVisibleJob(m.selectedIdx)
+		}
+		if nextIdx < 0 {
+			nextIdx = m.findFirstVisibleJob()
+		}
+		if nextIdx >= 0 {
+			m.selectedIdx = nextIdx
+			m.updateSelectedJobID()
+		}
+	}
+}
+
 // cancelJob sends a cancel request to the server
 func (m tuiModel) cancelJob(jobID int64, oldStatus storage.JobStatus, oldFinishedAt *time.Time) tea.Cmd {
 	return func() tea.Msg {
@@ -952,6 +971,7 @@ func (m tuiModel) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
 				m.currentView = tuiViewQueue
 				m.currentReview = nil
 				m.reviewScroll = 0
+				m.normalizeSelectionIfHidden()
 				return m, nil
 			}
 			if m.currentView == tuiViewPrompt {
@@ -1287,6 +1307,7 @@ func (m tuiModel) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
 				m.currentView = tuiViewQueue
 				m.currentReview = nil
 				m.reviewScroll = 0
+				m.normalizeSelectionIfHidden()
 			} else if m.currentView == tuiViewPrompt {
 				// Go back to where we came from
 				if m.promptFromQueue {

cmd/roborev/tui_test.go

@@ -189,6 +189,170 @@ func TestTUIToggleAddressedNoReview(t *testing.T) {
 	}
 }
 
+func TestTUIAddressFromReviewViewWithHideAddressed(t *testing.T) {
+	// When hideAddressed is on and user marks a review as addressed from review view,
+	// selection should move to next visible job when returning to queue (on escape),
+	// not immediately on 'a' press (so j/k navigation still works in review view)
+	m := newTuiModel("http://localhost")
+	m.currentView = tuiViewReview
+	m.hideAddressed = true
+	addr1, addr2, addr3 := false, false, false
+	m.jobs = []storage.ReviewJob{
+		{ID: 1, Status: storage.JobStatusDone, Addressed: &addr1},
+		{ID: 2, Status: storage.JobStatusDone, Addressed: &addr2},
+		{ID: 3, Status: storage.JobStatusDone, Addressed: &addr3},
+	}
+	m.selectedIdx = 1 // Currently viewing job 2
+	m.selectedJobID = 2
+	m.currentReview = &storage.Review{
+		ID:       10,
+		JobID:    2,
+		Addressed: false,
+		Job:      &m.jobs[1],
+	}
+
+	// Press 'a' to mark as addressed - selection should NOT move yet
+	updated, _ := m.Update(tea.KeyMsg{Type: tea.KeyRunes, Runes: []rune{'a'}})
+	m2 := updated.(tuiModel)
+
+	// Selection stays at index 1 so j/k navigation still works relative to current review
+	if m2.selectedIdx != 1 {
+		t.Errorf("After 'a': expected selectedIdx=1 (unchanged), got %d", m2.selectedIdx)
+	}
+	if m2.selectedJobID != 2 {
+		t.Errorf("After 'a': expected selectedJobID=2 (unchanged), got %d", m2.selectedJobID)
+	}
+
+	// Press escape to return to queue - NOW selection should move
+	updated2, _ := m2.Update(tea.KeyMsg{Type: tea.KeyEscape})
+	m3 := updated2.(tuiModel)
+
+	// Selection should have moved to next visible job (job 3, index 2)
+	// since job 2 is now addressed and hidden
+	if m3.selectedIdx != 2 {
+		t.Errorf("After escape: expected selectedIdx=2 (next visible job), got %d", m3.selectedIdx)
+	}
+	if m3.selectedJobID != 3 {
+		t.Errorf("After escape: expected selectedJobID=3, got %d", m3.selectedJobID)
+	}
+	if m3.currentView != tuiViewQueue {
+		t.Errorf("After escape: expected view=queue, got %d", m3.currentView)
+	}
+}
+
+func TestTUIAddressFromReviewViewFallbackToPrev(t *testing.T) {
+	// When at end of list and marking addressed, should fall back to previous visible job
+	m := newTuiModel("http://localhost")
+	m.currentView = tuiViewReview
+	m.hideAddressed = true
+	addr1, addr2, addr3 := false, false, false
+	m.jobs = []storage.ReviewJob{
+		{ID: 1, Status: storage.JobStatusDone, Addressed: &addr1},
+		{ID: 2, Status: storage.JobStatusDone, Addressed: &addr2},
+		{ID: 3, Status: storage.JobStatusDone, Addressed: &addr3},
+	}
+	m.selectedIdx = 2 // Currently viewing job 3 (last one)
+	m.selectedJobID = 3
+	m.currentReview = &storage.Review{
+		ID:       10,
+		JobID:    3,
+		Addressed: false,
+		Job:      &m.jobs[2],
+	}
+
+	// Press 'a' then escape
+	updated, _ := m.Update(tea.KeyMsg{Type: tea.KeyRunes, Runes: []rune{'a'}})
+	m2 := updated.(tuiModel)
+	updated2, _ := m2.Update(tea.KeyMsg{Type: tea.KeyEscape})
+	m3 := updated2.(tuiModel)
+
+	// Should fall back to previous visible job (job 2, index 1)
+	if m3.selectedIdx != 1 {
+		t.Errorf("Expected selectedIdx=1 (prev visible job), got %d", m3.selectedIdx)
+	}
+	if m3.selectedJobID != 2 {
+		t.Errorf("Expected selectedJobID=2, got %d", m3.selectedJobID)
+	}
+}
+
+func TestTUIAddressFromReviewViewExitWithQ(t *testing.T) {
+	// Same as TestTUIAddressFromReviewViewWithHideAddressed but exits with 'q'
+	m := newTuiModel("http://localhost")
+	m.currentView = tuiViewReview
+	m.hideAddressed = true
+	addr1, addr2, addr3 := false, false, false
+	m.jobs = []storage.ReviewJob{
+		{ID: 1, Status: storage.JobStatusDone, Addressed: &addr1},
+		{ID: 2, Status: storage.JobStatusDone, Addressed: &addr2},
+		{ID: 3, Status: storage.JobStatusDone, Addressed: &addr3},
+	}
+	m.selectedIdx = 1
+	m.selectedJobID = 2
+	m.currentReview = &storage.Review{
+		ID:       10,
+		JobID:    2,
+		Addressed: false,
+		Job:      &m.jobs[1],
+	}
+
+	// Press 'a' to mark as addressed
+	updated, _ := m.Update(tea.KeyMsg{Type: tea.KeyRunes, Runes: []rune{'a'}})
+	m2 := updated.(tuiModel)
+
+	// Press 'q' to return to queue - selection should normalize
+	updated2, _ := m2.Update(tea.KeyMsg{Type: tea.KeyRunes, Runes: []rune{'q'}})
+	m3 := updated2.(tuiModel)
+
+	if m3.selectedIdx != 2 {
+		t.Errorf("Expected selectedIdx=2 (next visible job), got %d", m3.selectedIdx)
+	}
+	if m3.selectedJobID != 3 {
+		t.Errorf("Expected selectedJobID=3, got %d", m3.selectedJobID)
+	}
+	if m3.currentView != tuiViewQueue {
+		t.Errorf("Expected view=queue, got %d", m3.currentView)
+	}
+}
+
+func TestTUIAddressFromReviewViewExitWithCtrlC(t *testing.T) {
+	// Same as TestTUIAddressFromReviewViewExitWithQ but exits with ctrl+c
+	m := newTuiModel("http://localhost")
+	m.currentView = tuiViewReview
+	m.hideAddressed = true
+	addr1, addr2, addr3 := false, false, false
+	m.jobs = []storage.ReviewJob{
+		{ID: 1, Status: storage.JobStatusDone, Addressed: &addr1},
+		{ID: 2, Status: storage.JobStatusDone, Addressed: &addr2},
+		{ID: 3, Status: storage.JobStatusDone, Addressed: &addr3},
+	}
+	m.selectedIdx = 1
+	m.selectedJobID = 2
+	m.currentReview = &storage.Review{
+		ID:       10,
+		JobID:    2,
+		Addressed: false,
+		Job:      &m.jobs[1],
+	}
+
+	// Press 'a' to mark as addressed
+	updated, _ := m.Update(tea.KeyMsg{Type: tea.KeyRunes, Runes: []rune{'a'}})
+	m2 := updated.(tuiModel)
+
+	// Press ctrl+c to return to queue - selection should normalize
+	updated2, _ := m2.Update(tea.KeyMsg{Type: tea.KeyCtrlC})
+	m3 := updated2.(tuiModel)
+
+	if m3.selectedIdx != 2 {
+		t.Errorf("Expected selectedIdx=2 (next visible job), got %d", m3.selectedIdx)
+	}
+	if m3.selectedJobID != 3 {
+		t.Errorf("Expected selectedJobID=3, got %d", m3.selectedJobID)
+	}
+	if m3.currentView != tuiViewQueue {
+		t.Errorf("Expected view=queue, got %d", m3.currentView)
+	}
+}
+
 // addressRequest is used to decode and validate POST body in tests
 type addressRequest struct {
 	ReviewID  int64 `json:"review_id"`